Re: [PATCH v3 1/4] KVM: selftests: arm64: Report set_id_reg reads of test registers as tests

[Ben Horgan <ben.horgan@arm.com>]

Hi Mark,

On 12/19/25 19:28, Mark Brown wrote:
> Currently when we run guest code to validate that the values we wrote to
> the registers are seen by the guest we assert that these values match using
> a KVM selftests level assert, resulting in unclear diagnostics if the test
> fails. Replace this assert with reporting a kselftest test per register.
> 
> In order to support getting the names of the registers we repaint the array
> of ID_ registers to store the names and open code the rest.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
>  tools/testing/selftests/kvm/arm64/set_id_regs.c | 74 +++++++++++++++++++------
>  1 file changed, 57 insertions(+), 17 deletions(-)
> 

Looks like an improvement to me.

Reviewed-by: Ben Horgan <ben.horgan@arm.com>

Thanks,

Ben