From: Mike Looijmans <mike.looijmans@topic.nl>
To: AKASH KUMAR <quic_akakum@quicinc.com>, Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: usb: Add microchip USB5807 HUB
Date: Thu, 21 Nov 2024 10:54:00 +0100 [thread overview]
Message-ID: <e3c88450-fbe3-42b9-a2ed-901ffdadfe1c@topic.nl> (raw)
In-Reply-To: <96bc29bf-b601-4852-ac9a-50091698529d@quicinc.com>
Hi Akash,
I was planning to, but the project was terminated so there was no budget to
finalize it. You're free to take over and make the required changes.
M.
On 21-11-2024 09:34, AKASH KUMAR wrote:
> Hi @Mike
>
> Do you have plans to mainline this change?
>
> We are using microchip hub in one of our project and we need this driver,
> we have taken your change and able to enable usb hub.
> Please check if you can push updated patchset addressing the comments from Rob.
>
> On 5/22/2023 1:58 PM, Rob Herring wrote:
>> On Mon, 22 May 2023 09:45:09 +0200, Mike Looijmans wrote:
>>> The USB5807 is a 7-port USB 3.1 hub that can be configured by I2C.
>>> This driver resets the chip, optionally allows D+/D- lines to be
>>> swapped in the devicetree config, and then sends an ATTACH command to
>>> put the device in operational mode.
>>>
>>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>>>
>>> ---
>>>
>>> Changes in v3:
>>> Add minItems
>>>
>>> Changes in v2:
>>> Rename to microchip,usb5807.yaml
>>> Remove reset-gpios description
>>> Add maxItems
>>> Add vddXX-supply properties
>>>
>>> .../bindings/usb/microchip,usb5807.yaml | 58 +++++++++++++++++++
>>> 1 file changed, 58 insertions(+)
>>> create mode 100644
>>> Documentation/devicetree/bindings/usb/microchip,usb5807.yaml
>>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/usb251xb.example.dtb:
>> usb-hub@2d: swap-dx-lanes: size is 32, expected 8
>> From schema:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/usb251xb.yaml
>>
>> doc reference errors (make refcheckdocs):
>>
>> See
>> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230522074510.16367-1-mike.looijmans@topic.nl
>>
>> The base for the series is generally the latest rc1. A different dependency
>> should be noted in *this* patch.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade
>>
>> Please check and re-submit after running the above command yourself. Note
>> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
>> your schema. However, it must be unset to test all examples with your schema.
> Thanks,
> Akash
next prev parent reply other threads:[~2024-11-21 9:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.656f2a13-85bf-42a3-8490-f97f2538d8c3@emailsignatures365.codetwo.com>
2023-05-22 7:45 ` Mike Looijmans
[not found] ` <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.6bd20433-e21f-423b-bdd5-c30faf9d0dc2@emailsignatures365.codetwo.com>
2023-05-22 7:45 ` [PATCH v3 2/2] usb: misc: usb5807: Add driver Mike Looijmans
2023-05-22 8:28 ` [PATCH v3 1/2] dt-bindings: usb: Add microchip USB5807 HUB Rob Herring
2024-11-21 8:34 ` AKASH KUMAR
2024-11-21 9:54 ` Mike Looijmans [this message]
2024-11-21 15:26 ` AKASH KUMAR
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3c88450-fbe3-42b9-a2ed-901ffdadfe1c@topic.nl \
--to=mike.looijmans@topic.nl \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_akakum@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®