From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA055333730 for ; Fri, 29 May 2026 10:16:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780049774; cv=none; b=n5DUfnxZwPGC4Ah/FJ1K4KByQJmYIU3nqNIFOZP1BMONnMZd5o3nlcItZPUAHIlWtcONaybLjZXt3NjQt5CAH1DSDvWJQUiaVUowL2TTFVmqb6+EbjaUNAepcH5jJdVJwBe1y9EYlakuabsxLC2HSqKMpoMrc1FqG0HLPWQ1rp0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780049774; c=relaxed/simple; bh=Rb9pRMEWHB/11ewFIykCa7O3GdM34VtT66K9ppLOmLc=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=olkOlan0zSpOWiHA76SYYDrSvQWVoKewkGj46p6WOfduSaPr3z0mf8wZVq7lv+dud1O+oP9eDP0A/Vgy76KkkIgVIO0LAmb8i0fPCEMw6qx2jaCQvb0/eKzWA4F1Q/Gcukn1JKMBNoBsK/hc4TL2TzOuImub8/wrprPQ5Ngvdyo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uIUL9CNH; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uIUL9CNH" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4906869f0cbso60295125e9.1 for ; Fri, 29 May 2026 03:16:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780049770; x=1780654570; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=zY32vo4wGSfZ5uOAVtxfFcwmsUjSGjI2ELbc4pDk6qU=; b=uIUL9CNHpLGPRwdFb21rsg/w1BFlOt1dVNsPtSC8bR0gaDfEyjuAvjL7TAGrOYQBJi XaFsGfdVrd+jzrnyuQl6NpJ3a2ATJlgdiiLsmIQUGTRVLQiusevdlTUOT0fzmm7x8zdN TjuaaHTQMpQe/rc+Tw5boYCMdTyKOLNVQUQjYsxTUjU0vImb64e9TFPCSWo1H6Es5r2K /qSjhGOxub+PgpW2+lI7/Q27b41te3+eNChnOnsi6asLTOlIguidxvD8QqhzDOk9SKuH gzFGhIMLi90cl4WQZFXDrKUCioONUrvY16oYLEowm++FcTK+6s9h8TwF0fXUh0/0YuO9 Ncog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780049770; x=1780654570; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zY32vo4wGSfZ5uOAVtxfFcwmsUjSGjI2ELbc4pDk6qU=; b=L3N0rTQW8uybDRhhJ/LRhsWpOr2GgFzipbFJ5/9Tod0ycfmLxo06G2TKfFsD5TUBAs JXmvclRiS0/j+v+WqSC9A9HEVN25S31ct7rZ5/xH/9qeN9D+CQvUpifusC9/U9r2Q96m G3TJLinGYb51kR7KcEQftjI3Gbn1ZDUpjzE6HvPNLJz3yHJ8CTKbEMJhxSuytU5dgWns vQn6wbV2432cFZWVpPsC+Ul5UUN31VZtGXRPeLcy+KS9UBpUwvYJfkoeq63R+uGMhhU9 oE/8IWtc7WicG4hObyh+41ex5y14op6xcD8p4bmxJOv2+lntIDzxThQf9+aZ4e2LKiK7 acWg== X-Forwarded-Encrypted: i=1; AFNElJ92iIM9J1URuRAM1m/x3MU8aox8kHvEtbJyQNX8is0t19rp8ImtqKgcNKmdpDn8HSmlsol690+Ybu4M+Js=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2UEMiAulUhlWI6VDfLEWr21q0DC1rJmwhxjramD9u/SyXrfH9 NtzWmUt1dVSKUl72VdJSn1GVsb5Ffh6+jOOi/PxTSP2rFEYbvhUiwJ0j+zlkhx5fevc= X-Gm-Gg: Acq92OEOKGx8nyyiOlshYwaAX0Lo5cjAqJ4QpcvNKNeuMRhgbSRlPmaPqo/bTZZHYZv qJGMVAdioNBVeIztj7bUdIr2dy9jbupNns2zE/GOtLZ5iVji/gFc5l6HRG70jQzzikE+p/Fzyr2 p32H1UBXLS75Cq9g7ZCH/5hAPZERb4Eyfasn5hn9LzKl5QuD5oWfso70J1r/NgUN2Llveo16XUs VyF2/EJK5sZRfoVcXSE+SAD5CrXnl+0pWnJtwMuLWGN3eLXCC5KAqGZg0JIOUa12OQxCe7D+Bvy WaYHAUixnK045Gpez5qLj15lGxC7D+r+RdZi1WDU+fdJQLu3qnw/sfwLIChZ/SFtYsc5tcHarFg ibEowfNiytHgiYPrzqJAsfZppKBynHI/WN4nc5vXlwUQsTybxn3fhpVD3od4/vDjXIzN1QEKoAS BKxuekWva2BAKu4M+UhnGFg+3E813P4hbLB7NaTT/3Q7s= X-Received: by 2002:a05:600c:81c5:b0:490:3bad:3784 with SMTP id 5b1f17b1804b1-4909c0a7e03mr36047785e9.18.1780049770022; Fri, 29 May 2026 03:16:10 -0700 (PDT) Received: from [172.20.10.3] ([37.167.116.21]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef354b7edsm2332881f8f.22.2026.05.29.03.16.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 May 2026 03:16:09 -0700 (PDT) Message-ID: Date: Fri, 29 May 2026 12:16:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v3 1/2] dt-bindings: leds: backlight: document the SY7758 6-channel High Efficiency LED Driver To: Daniel Thompson Cc: Lee Jones , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, KancyJoe , Krzysztof Kozlowski References: <20260519-topic-sm8650-ayaneo-pocket-s2-sy7758-v3-0-ec8194bbc885@linaro.org> <20260519-topic-sm8650-ayaneo-pocket-s2-sy7758-v3-1-ec8194bbc885@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/29/26 12:07, Daniel Thompson wrote: > On Tue, May 19, 2026 at 10:43:38AM +0200, Neil Armstrong wrote: >> Document the Silergy SY7758 6-channel High Efficiency LED Driver >> used for backlight brightness control. >> >> Reviewed-by: Krzysztof Kozlowski >> Signed-off-by: Neil Armstrong >> --- >> .../bindings/leds/backlight/silergy,sy7758.yaml | 53 ++++++++++++++++++++++ >> 1 file changed, 53 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/leds/backlight/silergy,sy7758.yaml b/Documentation/devicetree/bindings/leds/backlight/silergy,sy7758.yaml >> new file mode 100644 >> index 000000000000..80e978d691c2 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/backlight/silergy,sy7758.yaml >> @@ -0,0 +1,53 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/leds/backlight/silergy,sy7758.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Silergy SY7758 6-channel High Efficiency LED Driver >> + >> +maintainers: >> + - Neil Armstrong >> + >> +description: >> + Silergy SY7758 is a high efficiency 6-channels LED backlight >> + driver with I2C brightness control. >> + >> +allOf: >> + - $ref: common.yaml# >> + >> +properties: >> + compatible: >> + const: silergy,sy7758 >> + >> + reg: >> + maxItems: 1 >> + >> + vddio-supply: true >> + >> + enable-gpios: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - vddio-supply > > Sorry for missing this in v2 but is vddio-supply really a required > property? > > It's unusual for supplies to be mandatory (and the it is not mandatory > in the driver implementation). This device is a little bit special, the VDDIO regulator is used to provide power for the I/O via the enable input, so basically the enable gpio power level is provided by VDDIO. This is the recommended way from the datasheet, and I assume it will be used like that on other platforms (if it exists...) This is why it's mandatory and enabled first before setting the enable pin. This should probably be a comment in the code. Neil > > > Daniel.