From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753042AbcIAJGG (ORCPT <rfc822;w@1wt.eu>);
        Thu, 1 Sep 2016 05:06:06 -0400
Received: from mailout1.w1.samsung.com ([210.118.77.11]:25640 "EHLO
        mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751004AbcIAJGD (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 1 Sep 2016 05:06:03 -0400
X-AuditID: cbfec7f4-f79cb6d000001359-e6-57c7ef78e6c5
Subject: Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for
 Exynos5440 boards
To: Javier Martinez Canillas <javier@osg.samsung.com>
References: <1472645679-5696-1-git-send-email-javier@osg.samsung.com>
 <1472645679-5696-2-git-send-email-javier@osg.samsung.com>
 <20160831174657.GA19969@kozik-lap>
 <c043b569-fbad-23bb-5807-5dda9cc8b37f@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        Kukjin Kim <kgene@kernel.org>, linux-samsung-soc@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>
From: Krzysztof Kozlowski <krzk@kernel.org>
Message-id: <e3cdab3d-f1ef-f751-b169-e3328178b835@kernel.org>
Date: Thu, 01 Sep 2016 11:05:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-version: 1.0
In-reply-to: <c043b569-fbad-23bb-5807-5dda9cc8b37f@osg.samsung.com>
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLLMWRmVeSWpSXmKPExsVy+t/xK7oV74+HG3w7JGsx/8g5Vos3b9cw
        Wbx+YWjR//g1s8XlXXPYLGac38dksfT6RSaL1r1H2B04PNbMW8PosWlVJ5vHlv677B59W1Yx
        enzeJBfAGsVlk5Kak1mWWqRvl8CVMetxJ0tBE3vF6pN97A2Mt1m7GDk4JARMJG7c1e9i5AQy
        xSQu3FvP1sXIxSEksJRR4vmLFcwgCSGBZ4wSX65mg9jCAlESpw6uAouLCJhK/Fr7ghWi4T6j
        xOaO6UwgDrPASUaJjRM3s4BsYBPQlvi3pRikgVfAVmLj6rNsIDaLgKpE569T7CC2qECExK1V
        HxkhagQlfky+xwJicwo4SyyetB9sDLOAusSUKbkgYWYBeYnNa94yT2AUmIWkYxZC1SwkVQsY
        mVcxiqaWJhcUJ6XnGuoVJ+YWl+al6yXn525ihAT6lx2Mi49ZHWIU4GBU4uF1eHMsXIg1say4
        MvcQowQHs5IIL9e74+FCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeefueh8iJJCeWJKanZpakFoE
        k2Xi4JRqYNzgPf1DdN67p25n53Ku+yAclMHmyRZ2/K553Delad06j5/O21Xw+cbRuTxJndKt
        Jz/fT+N9Grh8ikmIzLtvPD+31F48cL3ukWD9W7v4wCc3ujwnG03cfv3sEt/oUP7C2L02k79v
        VNn9b/EZAzXOf1bhWrfCq55m1CdanT54aHvR25vVa2aly/oosRRnJBpqMRcVJwIAXPHOOHAC        AAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/01/2016 10:43 AM, Javier Martinez Canillas wrote:
>>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>> @@ -21,6 +21,11 @@
>>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>>  	};
>>>  
>>> +	memory {
>>> +		device_type = "memory";
>>> +		reg = <0 0>;
>>> +	};
>>
>> This looks okay, but the default size and address cells won't be
>> present. Won't that be a problem?
>>
> 
> They will be present since at this point exynos5440.dtsi is still including
> exynos5440.dtsi, we are just overriding the memory node with the same values
> than skeleton.dtsi so this can be removed later in patch 7/7.

I don't get it. exynos5440.dtsi does not set size/address cells in top node.

Best regards,
Krzysztof