From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Johannes Holland <johannes.holland@infineon.com>,
jarkko@kernel.org, linux-integrity@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: peterhuewe@gmx.de, jgg@ziepe.ca
Subject: Re: [PATCH] tpm: sleep at least <...> ms in tpm_msleep()
Date: Wed, 11 May 2022 16:12:18 -0400 [thread overview]
Message-ID: <e3ce7c535e27369c07500064dc25c2fc8e7b3f86.camel@HansenPartnership.com> (raw)
In-Reply-To: <20220510112902.23213-1-johannes.holland@infineon.com>
On Tue, 2022-05-10 at 13:29 +0200, Johannes Holland wrote:
> To comply with protocol requirements, minimum polling times must
> often be adhered to. Therefore, a macro like tpm_msleep() should
> sleep at least the given amount of time (not up to the given period).
> Have tpm_msleep() sleep at least the given number of milliseconds.
>
> Signed-off-by: Johannes Holland <johannes.holland@infineon.com>
This seems to fix the problem I reported years ago with my Nuvoton
laptop TPM.
https://lore.kernel.org/linux-integrity/1531328689.3260.8.camel@HansenPartnership.com/
It probably needs to soak a bit longer to declare victory (this timeout
failure is very intermittent), but it looks hopeful.
Regards,
James
prev parent reply other threads:[~2022-05-11 20:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 11:29 Johannes Holland
2022-05-11 15:16 ` Jarkko Sakkinen
2022-05-12 12:21 ` Mimi Zohar
2022-05-12 12:32 ` James Bottomley
2022-05-12 16:52 ` Mimi Zohar
2022-05-16 17:57 ` Jarkko Sakkinen
2022-05-18 19:26 ` Nayna
2022-05-18 20:21 ` James Bottomley
2022-05-27 21:37 ` Ken Goldman
2022-05-16 17:54 ` Jarkko Sakkinen
2022-06-20 15:58 ` Stefan Mahnke-Hartmann
2022-05-11 20:12 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3ce7c535e27369c07500064dc25c2fc8e7b3f86.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=johannes.holland@infineon.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®