From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f228.google.com (mail-qk1-f228.google.com [209.85.222.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C54CF386435 for ; Fri, 13 Mar 2026 22:48:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.228 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773442120; cv=none; b=tHHcQol0FDS0NdBzAUja6HCZj5A3r3zGiNfLH+NwY5LU7SXREg9aS7gnDkAl75EMgOcYJA8kuqXqNHJQJE7m0Nxu5m/c3ymUGl9DhtpiZsorf3Tofzo5pbUhMM3bU5sgFYJxBR7HRLdlnLyyA1IcjE5XQoins7eRkKaLKCuRbd4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773442120; c=relaxed/simple; bh=k7sRZjep4Pl5nGo253/uSYed2ycRs08gBT9ck3+RJg0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QEy/VNEyn/5eHXcCbsn5NjQLp1H9WcyEjKABPp/QJzpwLJKnvSLTEJ5b8IA8yOkbWdM6y3q3vZ+lFWSXU0jIqZdf2zmD/g1JFuQJs4rY7WB9MbKfPiNd3hZ9I5Dzkffiu4gpcRtW10FtEo8S/jdc0Oita3bpbqw1xAMSN0y0/Kk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Qsk7lrA6; arc=none smtp.client-ip=209.85.222.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Qsk7lrA6" Received: by mail-qk1-f228.google.com with SMTP id af79cd13be357-8cd73c4a827so260143385a.3 for ; Fri, 13 Mar 2026 15:48:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773442118; x=1774046918; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=AyfyTnnei5rK6RAUwWwpGmxvvM7+xZXb2sEOU+VWGg0=; b=NZavuFqOws0O++AEGALsCXjXr7gwiW8jDXC/FmFvetwS+PQnZrTtyu3cRgoT0njw3b wIyEj4rOcx8nIE9eVtTKoJcHEhwB00XVBkXfBuQXK7apjtUw/iTpg0xMY9pM6q1fCl65 TIsrJr9PPgDJYPqwIBRUIXy8pwpIzZKQa/duU4YeCgWLg/O4czUgDs0Bxvrv0wrIlBnX e3aecpzWh3/Ple1Dv3AFSlTQWq8VgyZKZrcpGvk3R7zPehsm0RmgreERFi3aPzymAtro lT3kTnQzUZCyl9VQWs9cvMxueMAdk3hwYaYn+JhrQEgZK4IH+g+ZOIbBNak3IWhPiUut +0ng== X-Forwarded-Encrypted: i=1; AJvYcCWXQE6AkobuRR/V3a/fa4+TkBZkB2zRuOyYem4QqVFG3MxZF8Kb14XHiEuk8Dm663rZE7unuewpRa/yrvE=@vger.kernel.org X-Gm-Message-State: AOJu0YzQA+mzbrIC7vYMnzgzfVDDWXqPZMQ3JNKTfOk2vbRD6gwVQZ7O 44duG/C2TKG11GrN3flTEEGq112raJE9f0r+n2fygwu5Yy64Ye+4nDEisbePiCwjNJZjP6VTtfL Oiuo2lN1fyhyvbP5SO/6KBG5FpKZqhcuXkj5BAWX/YTxujqinqk3AaBPxgATcyXzFeFxf3NFAvU GRkbC5BYK8ODxB2JahWDLM4lvNGY+viBaCuXtKzawJAunolbQcK4PEcBauJY0r1Zfo9uZcribIZ 8He1Gbeke+tiT5NWIagGlVm X-Gm-Gg: ATEYQzw+e7pVZW08/rEQf2KvHvNM7xo15qZTCZ70mv0ukAID4c0bGBi4ILht7mUnDsM tPLAZJdKz6f/ARu4HORwmDSsbemYZgYFmZai453SVLEQy6+FDx2u6PQrFAwjyNf/n1Wvp+aIorX LVSYbWiXPwLJtvoTmnuWM1XAKfEIFnLtOeEM9NAt1hFdpZGAWXct2Ixm3brgqfOAu6vyXMLsIdX +EsWeL7+diQb+y3GRxcE192Kk2ipr5b1ThDs3E45Pd3FK45dBQKRLPxJ6CH1lmDJI4/YPrQAgLm A8Lrp1iQcCyOAj4xT4vHla0F4YiBPeklINQwwF/bQRFpPvQjVXMRqaEJA0Sv731cTi/s3HmswIu PCjADYgBEgvrgXeyQbKe9WaqMQXS9wEzB+HZ/SVlb2FfSdUFc52IRCuiLjbtfdeQ49Wb4PkNRMe nNBDMZyPHCBmLpCKoFNsnTS974lj25jaujIbgGIKE2oJWoZGeHdf9D4mK9zcbN3bbp X-Received: by 2002:a05:620a:1707:b0:8cd:9322:d443 with SMTP id af79cd13be357-8cdb5b6f8b6mr639304485a.60.1773442117448; Fri, 13 Mar 2026 15:48:37 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-117.dlp.protect.broadcom.com. [144.49.247.117]) by smtp-relay.gmail.com with ESMTPS id af79cd13be357-8cda207418esm89113085a.4.2026.03.13.15.48.37 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Mar 2026 15:48:37 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5093025ffecso188190641cf.0 for ; Fri, 13 Mar 2026 15:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1773442116; x=1774046916; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=AyfyTnnei5rK6RAUwWwpGmxvvM7+xZXb2sEOU+VWGg0=; b=Qsk7lrA6spPmDGStXG9hTlQ+qDqd8R/Jn6VrKi+PHFSTKNhr2j4ZXAI06bcu/G5TG8 cog2GA2absGxuEzfoEEQa2WPd5W695vI+GyREUQ0BF6AwGaZJX4vDZqkfy++aTB2GPY9 gUdvZrP1BBse++v8XQBbB/FV58BZlrb2nlGMY= X-Forwarded-Encrypted: i=1; AJvYcCXctTWLLHGeuWqwkgiIGl1X5jMlRlsWwJvHB6FN1qoVlzZYd27MFHUAHNPBmn5bvLuRRAYics3BQ0630jw=@vger.kernel.org X-Received: by 2002:ac8:580a:0:b0:509:3dfd:ab83 with SMTP id d75a77b69052e-50957b90a43mr67948531cf.7.1773442116698; Fri, 13 Mar 2026 15:48:36 -0700 (PDT) X-Received: by 2002:ac8:580a:0:b0:509:3dfd:ab83 with SMTP id d75a77b69052e-50957b90a43mr67948241cf.7.1773442116175; Fri, 13 Mar 2026 15:48:36 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5093a11cc4esm73940211cf.27.2026.03.13.15.48.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 15:48:35 -0700 (PDT) Message-ID: Date: Fri, 13 Mar 2026 15:48:31 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 3/6] net: bcmgenet: add basic XDP support (PASS/DROP) To: Nicolai Buchwitz , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Doug Berger Cc: Broadcom internal kernel review list , Vikas Gupta , Bhargava Marreddy , Rajashekar Hudumula , Eric Biggers , Heiner Kallweit , =?UTF-8?Q?Markus_Bl=C3=B6chl?= , Arnd Bergmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260313092101.1344954-1-nb@tipi-net.de> <20260313092101.1344954-4-nb@tipi-net.de> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20260313092101.1344954-4-nb@tipi-net.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 3/13/26 02:20, Nicolai Buchwitz wrote: > Add XDP program attachment via ndo_bpf and execute XDP programs in the > RX path. Supported actions: > > - XDP_PASS: build SKB from the (possibly modified) xdp_buff and pass > to the network stack, handling xdp_adjust_head/tail correctly > - XDP_DROP: return the page to page_pool, no SKB allocated > - XDP_ABORTED: same as DROP with trace_xdp_exception > > XDP_TX and XDP_REDIRECT are not yet supported and will return > XDP_ABORTED. > > The XDP hook runs after the HW error checks but before SKB construction, > so dropped packets avoid all SKB allocation overhead. > > Advertise NETDEV_XDP_ACT_BASIC in xdp_features. > > Signed-off-by: Nicolai Buchwitz > --- [snip] > @@ -2345,12 +2397,6 @@ static unsigned int bcmgenet_desc_rx(struct bcmgenet_rx_ring *ring, > hard_start = page_address(rx_page) + rx_off; > status = (struct status_64 *)hard_start; > dma_length_status = status->length_status; > - if (dev->features & NETIF_F_RXCSUM) { > - rx_csum = (__force __be16)(status->rx_csum & 0xffff); > - if (rx_csum) { > - /* defer csum setup to after skb is built */ > - } > - } Did you intend for that hunk to be deleted? -- Florian