From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 952AD363C63 for ; Thu, 18 Jun 2026 08:18:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781770708; cv=none; b=sPYT563g3D+TYFsl4X/C5/7kWSZae70HknlbhtsHHFXAaFVd6HIxJgnxvPDeJ8L/WVnKHD4tKU8n+pNvcwmgkSIwS9VvWPGuRCAf388DKDdJdmcfO48BL4BgGrAmFgOLwsWtzh7h3IzBSGUl8RIsMdIHhrp12lYAqYcu09kI4aw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781770708; c=relaxed/simple; bh=Jr8MuSN0f1khlBWhNBWG9mP/rjBRDgaRgJESu0THHwE=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=U6j2WKpPFsLu//ZVRWASYQOghEUcf2kOSPiPmWWe+rtkGCjR+qofvQyEHvF1GtTPD/pm530T2iokiYWRVXEPR3vZDVJkXYW4l4lBCRs/KMbsf4Z5WxFNJBuEqiv5h2zMnLxyy1KsSum4diSILdgFsMYiIgn3DjFRZSee51S+VY0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=p9vw+VG0; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="p9vw+VG0" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id BD6BA4E42F95; Thu, 18 Jun 2026 08:18:21 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 896215FF03; Thu, 18 Jun 2026 08:18:21 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3C99A106C88AD; Thu, 18 Jun 2026 10:18:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1781770700; h=from:subject:date:message-id:to:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=lRVKmEoMOHx3NUrr6vG//IJN/FXejwsmjpLhQB0fvl4=; b=p9vw+VG02qJbJO1ZMpkg1Z310QH86FPGFwlV7WPw4gzLnnWQ+iaabmNvdP0UgWG2UIbAbi p4lgLFLb3ZxbBeYpXjEZWw7n4ttXGq/q5tsLwNWGq+oVsscEz6uGeyZx/C8cfQue0ikBtS 0mgUNr61RC6ZxZZOBsV4fi4Y8/NKDfSe/jKgxecyAZtex71nFAJtIcP8mJip/Ck6BVvosb +TD9xN1dm0kWqk3Y+KlJnXP+SYT+lJOUNhOUbC5Z45o5EYKZJpJ8QGfBtyoNMdbqqMdgQk AX4SWYSrDYV0BptsHQhP1St8pc2SC0qHjwL/OdaUF5uhmiM0jFovv60F0Q5EVQ== Message-ID: Date: Thu, 18 Jun 2026 10:18:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2] net: marvell: prestera: initialize err in prestera_port_sfp_bind To: Ruoyu Wang , Taras Chornyi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Oleksandr Mazur , Yevhen Orlov , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260617193228.1653582-1-ruoyuw560@gmail.com> Content-Language: en-US From: Maxime Chevallier In-Reply-To: <20260617193228.1653582-1-ruoyuw560@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi, On 6/17/26 21:32, Ruoyu Wang wrote: > prestera_port_sfp_bind() returns err after walking the ports node. If no > child node matches the port's front-panel id, err is never assigned. > > Initialize err to 0 because absence of a matching optional port device > tree node is not an error. In that case no phylink is created and port > creation should continue with port->phy_link left NULL. Errors from > malformed matched nodes and phylink_create() still propagate. > > Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support") > Signed-off-by: Ruoyu Wang Sorry for the grumpiness, but Andrew did ask you to read : https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html and one of the first things it says it to wait 24h before a repost :/ The patch in itself LGTM, so : Reviewed-by: Maxime Chevallier Please wait 24h next time, Maxime