From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757738AbdJKUpO (ORCPT ); Wed, 11 Oct 2017 16:45:14 -0400 Received: from mail-bn3nam01on0069.outbound.protection.outlook.com ([104.47.33.69]:61022 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751386AbdJKUpI (ORCPT ); Wed, 11 Oct 2017 16:45:08 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Part2 PATCH v5.1 12.4/31] crypto: ccp: Implement SEV_PLATFORM_STATUS ioctl command To: Borislav Petkov References: <20171004131412.13038-13-brijesh.singh@amd.com> <20171007010607.78088-1-brijesh.singh@amd.com> <20171007010607.78088-4-brijesh.singh@amd.com> <20171011170205.qpu677qiqe4ludwm@pd.tnic> <20171011200444.3njniblsvxn2vhl6@pd.tnic> <20171011202836.d3ur3ndrnea25ywi@pd.tnic> From: Brijesh Singh Message-ID: Date: Wed, 11 Oct 2017 15:45:00 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171011202836.d3ur3ndrnea25ywi@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CO2PR05CA0080.namprd05.prod.outlook.com (10.166.88.176) To BY2PR12MB0147.namprd12.prod.outlook.com (10.162.82.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 56bfd5aa-26a5-485d-a1f9-08d510e8f466 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:BY2PR12MB0147; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0147;3:sxzMTpdGy2q9KJm1w3Nytxyxd/DZraK7APyYCU6OSHbATZkDcO5mMxBnpSDQJ+UGeWtmSAsKk+P9sq6hEsnLQD2/gIisPhKky8ARbfzJYy2Zgwh9cdMw7CJnKM2D5hmEuapwTF2vIlfcx0vFT2a1VMhc44mZCBinmIAFpszpfpm2X6ypPmaWMhRDCBryh8T8Z/khxyIia7N42ZSHgxEkdv0tFBIsydTCERAIcos5O+si0hsD2rt6OQ3tqTzerV7Q;25:/p8CZPwHzleI3yKziwkKE5X02knKkhQETrMEnMmG7MM7kf3uWM9U97Xy/fEJfQhlbidJNlqx7POg/75+o1f4SeJcERMjVNmtZ0Hd9FWPAV0Lq/jZ9/LRwcCC9f0lrsQRr9sBUbA+TX58B970KvLXF4EU9AugdvOF5UpFrlBYQ6w3nM+A0bJS1oGuKp3BbkUI/XL3ZD/fIevF4m2Mds6DVCop7zZ+M9WL8gy4gImvAcf89v5wJEiwKhXO+nk38gUCBcZWz4mdT+nMKhoVQsGK/HMmDdxWAzHMDqCxSRcmfLIPTjU7lmzN4y97KrFhuZbgf9ld7kcxGUEICcqRjC8uJg==;31:hBVZy0WQxdehq3jyDfPWyE0UrO99hgw8ET1OUf2O+e5DomhUSAWt5Nba4MsH6B1LwWS/s3EAGb/Egjqbtp1ahmIe8woo4w5t3k7e83dniDnR0A2xPsXqNHaphoT2LrVlM+J6KdEkRl+3ztnfHHOXcHLumRdu+FnQYtwQV8RAbTpXU+XmmtxuXC9LGwvZYqeI+6y6tpbU3kvBFeV8LazEdZc7/uKzoOtOYWpKdssIyUA= X-MS-TrafficTypeDiagnostic: BY2PR12MB0147: X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0147;20:a0rzJzxVJ4qODgZB+5bEv0d4p9qumHrd0Z3B72khd2bMP2Gds+GYhAtcrjOiao0bFIkRQsJhxobOGt5UgM+NW7jnevHIgsX1CmJDEP9Lg9ONzCW0hrIPWsJtiKutbAKzpCIw9XfYpsE/uVbyu2aFPvA5RE9yofIP2bMYSF+EDtlayq40pH4TwyNrwsr1z3HuN76LxdqLgJt8KoRT+k2OowCDjIk/THCGWMLj48QD75tTgJVj7bWeIyuTcL5B5O8GfbrolHY8ai7y1+ryzk/sFwyiX5sgq8Tu94Ep7qOWIdEDn857lWY0GTUaUEsKbTka4Up7RWlR4pmO5/fuoq7rIHILK0Lcy//5DqUfaril1u01nGDXe+1fMhBQitbSeS0fdIEHmMPp1JPNw71upSEdsWqgvYyaFmf91dP5WlIs/j4qiOivHy9lWRCZPatCP29FuMyUNgZZ2cFImHMhzOb6VNbG8rRhXneDctNEDBq2WXPmeNQDArsABV2w+7U8SRb9;4:lyiyk/OPFsNMawe024YC4k8a/R97aN8nAVPfyda/56X/u6Ofox+noQoThDcWr5SnAjWu7ZRbA+i62cfudx8nrIW+N3zJV4Y56PuJUDC12d3fomPmvwUOpsPqjA/bfMbUuUlqIn+ebQJIsMlwrmMFzGrRKWXr9XQY32ZsAlLqeKqbd5awjwWAdb4I5phcXy9XtcCXiJGfjyP7UsRI8lzn4z8g+Xv2uxndyoUYwU0LClDQeuwbdz0XVJXdw2qQ2eut X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123555025)(20161123558100)(20161123564025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BY2PR12MB0147;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BY2PR12MB0147; X-Forefront-PRVS: 0457F11EAF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(376002)(346002)(39860400002)(377454003)(5423002)(199003)(24454002)(189002)(23676002)(6666003)(66066001)(65956001)(54906003)(16526018)(33646002)(58126008)(65826007)(189998001)(68736007)(316002)(16576012)(5660300001)(4326008)(478600001)(65806001)(6246003)(6486002)(90366009)(36756003)(77096006)(53546010)(230700001)(47776003)(50466002)(8936002)(305945005)(101416001)(105586002)(8676002)(50986999)(81156014)(106356001)(64126003)(31686004)(2906002)(93886005)(97736004)(31696002)(81166006)(25786009)(3846002)(7736002)(83506001)(76176999)(54356999)(6916009)(6116002)(229853002)(53936002)(2950100002)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR12MB0147;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjEyTUIwMTQ3OzIzOml1ckIveHhUVVI4SStCbVEyK1ZQdGhQLzEv?= =?utf-8?B?emw5bGlSVGR1ZkJ3MDlrQ3ROQWJ4SHdhUCtZaHl3QnpDTTZqS1RqVDBqdUJ3?= =?utf-8?B?WStESGEyTnAzeDh0cXZ2RXhIRmJXcTNjN0VoQ3V3SFVtNFJSamthaEJDejZ1?= =?utf-8?B?L3hiTEd2M0NuckFYNXBtTkFxQS9DUk5meXlBVUJ6cDB5MmdsMXQrWURMTUxJ?= =?utf-8?B?aG5kb1BVU24yRXU5dG1vSmFhR01oSkI3SHcxbDJCb24rTXUrOHY0Z05pc3lv?= =?utf-8?B?QnhDU1dyREJHTnc0ZGZvYlA2WWNWcnhXTGZTUHdxL0hFMzc4bWJOejlyTkNR?= =?utf-8?B?UmI3QTJFUEtUMVVUaTF4NlgvZHpha3VkUTNnWlU4T2k0K3FYdlEyL3N4NDd1?= =?utf-8?B?OEt6dUZFOUQ2NTdBWnRkWG1rM3NpdHNMaDJqc204aHRZWUtTZFY4cFZ5eWsz?= =?utf-8?B?U1NHRVF3R3BNRi85SUtPYkk0ckZOenp4emZsbFFOMWxEYUFONWZsekRCUDl2?= =?utf-8?B?b2dQNUd2ZHF3TWU2ekxJekVNRWJkKzJSbytaUEJxaFZpWjRpMGtxUjJqMS9X?= =?utf-8?B?VVVEL0haMlZxaDI2OElHOHBzOVpUSWRtZUY1WFNiTURvZkhsUXgwMVhRU0ZG?= =?utf-8?B?YWRKbTZBSlFYRTFjSmlTU0FmL0twRCt4Wk5RSlhoenZ0WitacFE1ZGpUM1Vu?= =?utf-8?B?OWFuRTJ0SjM5czFsNE1FL0ZaeVF2YVhENXg1S0tiM2dGSWFIRThpQUxoY2JH?= =?utf-8?B?MWY1M0l5VDRYUDdVMm14Ui9MakxVRE9uZEVoaVZoVk83OEZsdWpRTVkrN1Zj?= =?utf-8?B?OEV5K2JHbjRtQzJydG81NlZKY0VGQTlGWW5RenMyQzgremUwclRjamZqZ1VT?= =?utf-8?B?bmphODI2ZTBCOExLOWR3ZDdmWjg0VEhQVCt0RWlDTXlwV3kzaHJHZVZLWG5i?= =?utf-8?B?SVRYN3Q5YXBZc2FzMWVGN0s0Tm83Q2FQWEYrYzU1bGdSM09LdXpKaWlNM0Np?= =?utf-8?B?STFlMk5wR2FqWTY4c1BZZWFWemFFV29MLzVRYU9yZE84VlFNSyt1WVJ6QjNp?= =?utf-8?B?VnViZGdncjZnZ3k2ZVQ5czJhRG5rU1FDZ3ZxZFpYYy9HYmllRnIwbERZQTEr?= =?utf-8?B?MFBXcmhzaVN5Z291d1dDTjd1NkdIWXliQk5QV3o3SlpLMTZsdW5yeUxEWGg1?= =?utf-8?B?bitXMEZPbk44MWVOcFVjd1ZlV056bHAvaitDSWZ6bWZVbmFzS2pLeEIxWUU5?= =?utf-8?B?MGRLQkdLQ0UwOEdGVU1PaG5HRlNhSE55ZHZYZXlLK3kzYlZjbnhvd3A2RWFC?= =?utf-8?B?cmJyT0xXQngzdFhoSjVNbGgrS2pZbEJiczk2OENmL09tcUNLMFN6MnIvdDdW?= =?utf-8?B?Syt6dHUzNDFIN0VIbXNsQTVtbzU4dmNmajRVR3JiOGhKODZ3ek9CYlR5QnUr?= =?utf-8?B?UmxSZGhYRnRUZkdlVlIxTzBhR2FUUCtBWUtzTlNsajA0UVlJRlQ3NEpMd2d0?= =?utf-8?B?dGcxUHJ6V1ZobEhPUVpMWDBDa0U3L0ppdWNqTTJLdWMzMjVlMXcyZG5pbVpl?= =?utf-8?B?b2JYbTRiaEw4K3NVZ3NOWWhHMVZESUlzWllrREg3eEtnUlltVHpsbmdrb2NJ?= =?utf-8?B?ckVqeFNyY3lrZHUyeThTSDkvVTVnUDhIQzVrK2NuSzJCaVFBeURMVEJkclMx?= =?utf-8?B?M0h3bEtNd2x3TElxOUg0SE8zeXZVVTRMVndqN2grbm1RMlJRcjQzQk0zMCto?= =?utf-8?B?T1B4YzdEelcvL3gzKzVTcXlreVB2WVNDTkdFemVLNUNQNlNKN2sxV29lMi8y?= =?utf-8?B?bHU3dE05VUJkaHpzRzhHSisxVHpicUJHMW5uallrZ0dndCtXQklvME92T1pq?= =?utf-8?B?YnRGQVV0VC9XaHRCUVB4dUdhMyszQlhsb1BWemhIQ2NFc1VYY0xzREZyN2xm?= =?utf-8?Q?RX+cyEf5a/DJknogjlUBEkob3ZyfSg=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0147;6:XC1HoUisjTy2hgS+lk3TgOho0u3h2jzgcei2lfSTt3Dx8UB/rQrjHmuMretTperuKNuzNuE7dOhyzCpQxAOlFkFYLWKND4zI+X89sOI44PnocfFHFtGFCPKGJVU6MO6cerYOkH8ucviChx9mVQtBucL6wVz1IIb5WIDow6Ax5T12xGgIlrhhmrkXae/lZfAp4vKJvYJjbU72aNEh/VZjSbGtEgCJ1qKWRaftm+Oaryl24EkPndAU8M5AWSwgyrUPhakQgtWO8kmBtry/jrICA38Ro66HmCcaHCHxhNSt5Fl4BPwWVlAPsQf7Fc0K76z5VEVQHwbcjO+7S409Svr5CQ==;5:eJ7PgnbAUvAbX0XDVVmxlBvKq17dvIWUTn7gxF/2JHsXBT3JeiA8MhRWValelA2/GjJnS0y/pX+zUpp50CK5GuZliqfgG1o4ZmuZ0TJcRxowjouo3WevpZ+Efzw+mX57vepyG9f4Pl2Tr1Vo5dJEiQ==;24:p9ETBn31EksGtqFFo5KUYViug9Lm+DnaYaSkQ2V2PmIE3TPJTKVfxsKGlm65Ho3bmLJjKVkpWYAvOFFpzBSHzZTteVQp5pRE8xUnVUMhaOc=;7:CZjaA3haaNFpm+4Cu9B2TK9A8GLNA4opXb5IpDq+N9DF4byx0z1zDddD1ddkp7Mpku2FlIpE097EmTbTLL1f3/Mn+/WQyNh9uRr7Js29HgcgP7lPmbh8oaNRQXNv35wnp8ngt5t50ZIuznm9Idlx+K4yz+jaf9h2832Kp+lTJ5DKdpiD7+ENiuHj74AX66TS8gdO5ao8a9vOAU0tRLZXRlavGSpaAvEXKa1M+bC1RL8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0147;20:Fhec2uDfluDerYTZ6tAuhrNZS4aRyHzLz34IdFJh6l3VvEQ4yE7Ql8p6/4MbsFkX39OWIX6WNh5IOyyH3nD/Nfm+uAwmxHOq53H7SsDpeg5fRqFASjc5fgCk2jnjSilbjPDs6W6eb9ZjZOdeBg0TjLXyOcNdpRoD9tVhyuqBhABRFCUECfN9VBhT8rHKyPUmtjY+WkNLjGbHSG3bRbgGPOR1PZuoLWHESirfLohsFlRqZJVndpIaDKfscW54Fra5 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2017 20:45:05.2241 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0147 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/11/2017 03:28 PM, Borislav Petkov wrote: > On Wed, Oct 11, 2017 at 03:10:49PM -0500, Brijesh Singh wrote: >> The current 'struct sev_data_status' matches with the firmware names and the >> bit fields. Only thing I did was the fields with no name is called as >> "reservedX" > > Ok, I see it. So what you actually wanna do is: > > struct sev_data_status { > u8 api_major; /* Out */ > u8 api_minor; /* Out */ > u8 state; /* Out */ > u8 flags; /* Out */ > u32 config; /* Out */ > u32 guest_count; /* Out */ > } __packed; > OK, if userspace is going to pick bits apart then how about this: struct sev_data_status { u8 api_major; /* Out */ u8 api_minor; /* Out */ u8 state; /* Out */ u32 flags; /* Out */ u8 build; /* Out */ u32 guest_count; /* Out */ } __packed; > > Makes sense? > Please let me know if you are okay with my above structure. -Brijesh