From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32D43C433E2 for ; Sat, 29 Aug 2020 18:21:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19CE220757 for ; Sat, 29 Aug 2020 18:21:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="MxZoREBs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728416AbgH2SVO (ORCPT ); Sat, 29 Aug 2020 14:21:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728265AbgH2SVI (ORCPT ); Sat, 29 Aug 2020 14:21:08 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BD04C061236; Sat, 29 Aug 2020 11:21:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=wM+3aUTCfqWWlQ1tJHVnOtNIBFAHIEvD/50Kk8jfavo=; b=MxZoREBsaBXG6+jt9ukV047v5Q XxKgvNn4fbCZZ14UAO7X0JIWw4Rkdqw87w7xo91fqNDwEae81IntJ9bQmzZH5vLAeaABDngfPIIWO Z4gI+dq8a8qu/Ezvmcs52pX52VRnNp/aTGZyZzCBNIR6y85WRcW09ga12FU4InFdcA5x+7UgsevZn qnXPfXWsrOT7j7Ilkd+TlmXqakOeskDPfMUlFeT1AwvjmpIjkqHcJEvmS3mLcAMLyPxoVY2LigNvn kga8QessGsBG3qdRJz6WkJhNno2tu1+yDN/R6y3NZGtaP2EohcVR+XbvWJn1MtJmMCw6BQEU77B96 RO2HVuBQ==; Received: from [2601:1c0:6280:3f0::19c2] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kC5TL-0007at-2k; Sat, 29 Aug 2020 18:21:03 +0000 Subject: Re: [PATCH 2/3] ia64: remove unneeded header includes from To: Masahiro Yamada , Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org Cc: linux-kbuild@vger.kernel.org, Andrew Morton , Ard Biesheuvel , Dmitry Safonov <0x7f454c46@gmail.com>, afzal mohammed , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200829051524.706585-1-masahiroy@kernel.org> <20200829051524.706585-3-masahiroy@kernel.org> From: Randy Dunlap Message-ID: Date: Sat, 29 Aug 2020 11:20:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200829051524.706585-3-masahiroy@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/28/20 10:15 PM, Masahiro Yamada wrote: > includes too many unneeded headers. > > This commit cuts off a lot of header includes. > > What we need to include are: > > - for DECLARE_PER_CPU(u64, ia64_mca_pal_base) > - for NR_CPUS > - for u8, u64, size_t, etc. > - for KERNEL_STACK_SIZE > > The other header includes are actually unneeded. > > previously included 436 headers, and now it includes > only 138. I confirmed is still self-contained. Nice! > Signed-off-by: Masahiro Yamada Reviewed-by: Randy Dunlap > --- > > arch/ia64/include/asm/mca.h | 9 +++------ > arch/ia64/kernel/efi.c | 1 + > arch/ia64/kernel/mca.c | 1 + > 3 files changed, 5 insertions(+), 6 deletions(-) > thanks. -- ~Randy