From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S936513AbdJRJzy (ORCPT <rfc822;w@1wt.eu>);
        Wed, 18 Oct 2017 05:55:54 -0400
Received: from mout.web.de ([212.227.17.11]:53890 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S933038AbdJRJzw (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 18 Oct 2017 05:55:52 -0400
Subject: Re: char-TPM: Adjustments for ten function implementations
To: Joe Perches <joe@perches.com>, linux-integrity@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Corentin Labbe <clabbe.montjoie@gmail.com>,
        Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
        Jerry Snitselaar <jsnitsel@redhat.com>,
        Kenneth Goldman <kgold@linux.vnet.ibm.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Nayna Jain <nayna@linux.vnet.ibm.com>,
        Paul Mackerras <paulus@samba.org>,
        =?UTF-8?Q?Peter_H=c3=bcwe?= <PeterHuewe@gmx.de>,
        Stefan Berger <stefanb@linux.vnet.ibm.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net>
 <20171016183139.otyh3m5c5yurtmow@linux.intel.com>
 <20171016183512.3bz6x4b6lbhpbkje@linux.intel.com>
 <20171017085124.pkrjzghcf5wmcydc@mwanda>
 <f9b35a67-bd7f-b140-bdc1-cb4886a6b1ea@users.sourceforge.net>
 <1508255833.3129.33.camel@HansenPartnership.com>
 <1508280210.6530.32.camel@perches.com>
 <bf7fc26c-bdc9-c752-72c7-f44c22f4a328@users.sourceforge.net>
 <1508318326.6806.1.camel@perches.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <e3dc2cac-105b-e1b4-be86-c1f1391c526a@users.sourceforge.net>
Date: Wed, 18 Oct 2017 11:55:12 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1508318326.6806.1.camel@perches.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:9FQ3Wh5wilMVkyFbLHBu37it7Su9NFsM1xwHXHxwXgLwo+boURx
 mgGm+mSgSmvD7yYBCHCGSV3Y6mtE3vNAHUlzryOTcEIV3yPGAn/fwRpv4zu7duNIzs4Rg00
 6lRe/pbc2rEeT6Zl2rIvMS+Q7Yzz/zBAaqTE5km62r3isnPUkQc2fHG0xtR5/7Zma3F56Te
 3BAVLJ4Nf1elN3xySLArw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:R8eYBGSAAPI=:DAuuwFpZIXzHVF+dK3jp9c
 CollGz8T5f0YWMeienBbT6XLGuDvI3+NzU07FuVnCI7rTUAllKMFR80bTsZBL3meNqaiww5UE
 oaUiX5417c7uCU8vYh/iUNRrT6OgnuHWsDwPvcYs8CdcG2QxQisQ3vfF0ctqj1MNnSInQxMe2
 1eYEV72ShvHRQ/FBTXWgYoeGnEt80ClodN6pTF4bBHGdNZMjVwxqtTjkUZDGxbL7msvurxSQ6
 EbCCgOHNusCFND/AY6S7eZNXb6h0hNNoS230JqTVQGSo6t5bawkOeCxOhjdyS/QKwabpgIQ4D
 Ps4e62olReBVEJj227xYEg8JcmDSBbEtey1QtwtLDuBBX6Qhzk5Iukspk7+Ganp571nVoGSGi
 qMDd9DINLXYzLAxQJQmux6+dGI3XcVwoMqa6N+H2KyBLvIkvC5YcRZqeLOp0Fp8C8BkyOMC3o
 pZA7OIbChupgEP53K6XzKOBzpZizNjljLaYEYRE5CMU0HrZjv1NnGT2aSkfaJJLcEE2SHV2R+
 O33+TZag5jpkx+p1NFKOeW4+D/3UZpbEze+C9RYdISNhZzA5pilywajPGHWeD0xZ1IrBvaInD
 x+S3AXj2CGKA+YCjz2FrHdFAwJhclelYCTSEKv1OthhtAPBm6OEKGCLSi4UA5dagGCXWMKjB1
 IPm2oTfhCxufWh7oXekJi8BKjzsxVsjX6YuouJVkF89h7/LILkV4vIuFekAOiikePacf5RGrj
 ru+MEHw5168MqIGL7/XCRexoLGremAtsSyrMXIOUJStujNcHC3/sNo679yIs06XQK6nLJkAvk
 BN3k9W1UoqpfF9ZGO/UApKINDdGz7jf58tl7WEP0KqqmiW5bEY=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> I imagine that such small code adjustments are also useful for other systems.
> 
> Your imagination and mine differ.

This can generally be.


> Where do you _think_ it matters?

It seems that this discussion branch referred still to my cover letter
for possible changes in the TPM software area.

The four update steps (in this patch series) demonstrate different
change possibilities which could be desired.
Would you like to distinguish them a bit more?


> For instance, nothing about
> 
> 	sizeof(type)
> vs
> 	sizeof(*ptr)
> 
> makes it easier for a human to read the code.

I could agree to this view (in the general short form).
But nine statements became shorter in the concrete update suggestion
so that such a reduction could help the trained eyes
of some software developers and code reviewers.


> This class of change now require a syntactic parser
> to find instances of the use of type where previously
> a grep or equivalent tool worked well.

Does the Linux coding style convention prefer safety over this
data processing concern?


>>> Markus' changelogs leave much to be desired.
>>
>> Would you like to help more to improve the provided information
>> for the shown change patterns?
> 
> I've done that for you far too many times already.

I got an other impression.
You gave constructive feedback (also for me) occasionally.

There were a few cases where a desired agreement was not achieved so far.


> Your changelogs need to detail _why_ something is being done,

I could improve descriptions if involved information sources
could also become clearer and really safe.


> not describe any tool used to perform or find a
> particular instance of any change.

This part refers to a bit of attribution.

Regards,
Markus