mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Avri Altman <avri.altman@wdc.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] scsi: ufs: core: Introduce a new clock_scaling lock
Date: Mon, 28 Oct 2024 13:06:51 -0700	[thread overview]
Message-ID: <e3defca3-dd73-4260-b18b-522b8ca38201@acm.org> (raw)
In-Reply-To: <20241027082519.576869-3-avri.altman@wdc.com>

On 10/27/24 1:25 AM, Avri Altman wrote:
> Introduce a new clock gating lock to seriliaze access to the clock
> scaling members instead of the host_lock.

Same feedback as for the previous patch: please fix the spelling of 
"seriliaze", please use guard() and scoped_guard() where appropriate and
please reorder the members of struct ufs_clk_scaling.

Thanks,

Bart.

  reply	other threads:[~2024-10-28 20:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-27  8:25 [PATCH 0/2] Untie the host lock entanglement - part 2 Avri Altman
2024-10-27  8:25 ` [PATCH 1/2] scsi: ufs: core: Introduce a new clock_gating lock Avri Altman
2024-10-28 20:04   ` Bart Van Assche
2024-10-29  5:39     ` Avri Altman
2024-10-27  8:25 ` [PATCH 2/2] scsi: ufs: core: Introduce a new clock_scaling lock Avri Altman
2024-10-28 20:06   ` Bart Van Assche [this message]
2024-10-29  5:40     ` Avri Altman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3defca3-dd73-4260-b18b-522b8ca38201@acm.org \
    --to=bvanassche@acm.org \
    --cc=avri.altman@wdc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®