mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christian Loehle <christian.loehle@arm.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"axboe@kernel.dk" <axboe@kernel.dk>,
	"bvanassche@acm.org" <bvanassche@acm.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"corbet@lwn.net" <corbet@lwn.net>
Subject: Re: [PATCH] Documentation: block: ioprio: Update schedulers
Date: Wed, 17 Jan 2024 15:11:52 +0000	[thread overview]
Message-ID: <e3e0147a-4fdb-4422-807d-24760c4ac30e@arm.com> (raw)
In-Reply-To: <8085ea13-29d2-46bd-8ca9-407d22266d0c@wdc.com>

On 17/01/2024 12:49, Johannes Thumshirn wrote:
> On 17.01.24 13:20, Christian Loehle wrote:
>> This doc hasn't been touched in a while, in the meantime some
>> new io schedulers were added (e.g. all of mq), some with ioprio
>> support.
>>
>> Signed-off-by: Christian Loehle <christian.loehle@arm.com>
>> ---
>>   Documentation/block/ioprio.rst | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/block/ioprio.rst b/Documentation/block/ioprio.rst
>> index a25c6d5df87b..5410308888d2 100644
>> --- a/Documentation/block/ioprio.rst
>> +++ b/Documentation/block/ioprio.rst
>> @@ -9,14 +9,14 @@ Intro
>>   With the introduction of cfq v3 (aka cfq-ts or time sliced cfq), basic io
>>   priorities are supported for reads on files.  This enables users to io nice
>>   processes or process groups, similar to what has been possible with cpu
>> -scheduling for ages.  This document mainly details the current possibilities
>> -with cfq; other io schedulers do not support io priorities thus far.
>> +scheduling for ages. Support for io priorities is io scheduler dependent and
>> +currently supported by bfq, mq-deadline and cfq.
> 
> CFQ went away with blk-mq and got replaced by BFQ IIRC.

Right, I'll remove the mentioning of CFQ here and in the introductory sentence.
The introductory sentence also mentions "basic io priorities are supported for
reads on files", a limitation which hasn't been there in a long time.
Thanks, will send out v2 tomorrow.

> 
> 
>>   
>>   Scheduling classes
>>   ------------------
>>   
>> -CFQ implements three generic scheduling classes that determine how io is
>> -served for a process.
>> +Three generic scheduling classes are implemented for io priorities that
>> +determine how io is served for a process.
>>   
>>   IOPRIO_CLASS_RT: This is the realtime io class. This scheduling class is given
>>   higher priority than any other in the system, processes from this class are
> 


      reply	other threads:[~2024-01-17 15:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-17 12:20 Christian Loehle
2024-01-17 12:49 ` Johannes Thumshirn
2024-01-17 15:11   ` Christian Loehle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3e0147a-4fdb-4422-807d-24760c4ac30e@arm.com \
    --to=christian.loehle@arm.com \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=corbet@lwn.net \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®