From: Giulio Benetti <giulio.benetti@micronovasrl.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>,
Paul Kocialkowski <contact@paulk.fr>
Cc: Thierry Reding <thierry.reding@gmail.com>,
devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/7] ARM: dts: sun7i: Add pinmux settings for LCD0 RGB888 output.
Date: Mon, 26 Mar 2018 13:27:05 +0200 [thread overview]
Message-ID: <e3e51afb-bb32-7f2f-877e-b6c74d71ab06@micronovasrl.com> (raw)
In-Reply-To: <20180326100114.fa7vjw342ad6vrb6@flea>
Hi,
Il 26/03/2018 12:01, Maxime Ripard ha scritto:
> Hi,
>
> On Sun, Mar 25, 2018 at 04:09:13PM +0200, Paul Kocialkowski wrote:
>> Le mercredi 21 mars 2018 à 21:03 +0100, Giulio Benetti a écrit :
>>> The A20 supports RGB888 with H/V sync from LCD0. Add a pinmux setting
>>> for the needed pins.
>>>
>>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
>>> ---
>>> arch/arm/boot/dts/sun7i-a20.dtsi | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi
>>> b/arch/arm/boot/dts/sun7i-a20.dtsi
>>> index efb5607..bfe6728 100644
>>> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
>>> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
>>> @@ -922,6 +922,14 @@
>>> pins = "PI20", "PI21";
>>> function = "uart7";
>>> };
>>> +
>>> + lcd0_rgb888_pins: lcd0-rgb888-pins {
>>
>> It would be more consistent with other pins definitions to have
>> underscores in both names and to indicate the index, such as:
>> lcd0_rgb888_pins: lcd0_rgb888_pins@0 {
>
> Both your suggestions will generate DTC warnings, and we'd like to get
> rid of them eventually :)
>
>> This way, other set of pins for LCD (PH0-PH27) can be declared as @1
>> when they are needed in the future.
>
> A better idea would be to call it lcd0-rgb888-pd-pins, and introduce
> the ph variant when it's done.
As I know, only PD is muxed with LCD0.
And PH is for LCD1 only.
And LCD0 seems to come out only from PD port according to datasheet,
this is why I didn't put @0 after lcd0-rgb888-pins.
So I don't think it makes sense to handle pins in the way Paul suggests.
What do you all think?
Giulio
>
> Maxime
>
>
>
--
Giulio Benetti
CTO
MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
next prev parent reply other threads:[~2018-03-26 11:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 20:03 [PATCH 1/7] dt-bindings: add cdtech vendor prefix Giulio Benetti
2018-03-21 20:03 ` [PATCH 2/7] drm/panel: add panel CDTech S070_WV95_CT16 to panel-simple Giulio Benetti
2018-03-26 22:24 ` Rob Herring
2018-03-21 20:03 ` [PATCH 3/7] drm/panel: add panel CDTech S043WQ26H-CT7 " Giulio Benetti
2018-03-26 22:24 ` Rob Herring
2018-03-21 20:03 ` [PATCH 4/7] ARM: dts: sun7i: Add pinmux settings for LCD0 RGB888 output Giulio Benetti
2018-03-25 14:09 ` Paul Kocialkowski
2018-03-26 10:01 ` Maxime Ripard
2018-03-26 11:27 ` Giulio Benetti [this message]
2018-03-26 11:46 ` Maxime Ripard
2018-03-21 20:03 ` [PATCH 5/7] dt-bindings: add micronova vendor prefix Giulio Benetti
2018-03-26 22:24 ` Rob Herring
2018-03-21 20:03 ` [PATCH 6/7] ARM: dts: sun7i: Add dts file for the A20-linova1-4_3 HMI Giulio Benetti
2018-03-26 22:24 ` Rob Herring
2018-03-21 20:03 ` [PATCH 7/7] ARM: dts: sun7i: Add dts file for the A20-linova1-7 HMI Giulio Benetti
2018-03-22 18:05 ` Maxime Ripard
2018-04-23 14:37 ` Giulio Benetti
2018-04-24 8:41 ` Maxime Ripard
2018-04-24 18:31 ` Giulio Benetti
2018-04-25 18:40 ` Maxime Ripard
2018-04-25 20:08 ` Giulio Benetti
2018-05-02 16:41 ` Giulio Benetti
2018-05-04 8:06 ` Maxime Ripard
2018-05-04 21:52 ` Giulio Benetti
2018-05-04 21:59 ` Sergey Suloev
2018-05-04 22:05 ` Giulio Benetti
2018-05-07 7:30 ` Maxime Ripard
2018-05-09 12:28 ` Giulio Benetti
2018-03-26 22:24 ` [PATCH 1/7] dt-bindings: add cdtech vendor prefix Rob Herring
2018-03-26 22:49 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3e51afb-bb32-7f2f-877e-b6c74d71ab06@micronovasrl.com \
--to=giulio.benetti@micronovasrl.com \
--cc=airlied@linux.ie \
--cc=contact@paulk.fr \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®