From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACB4E37F8D0 for ; Wed, 1 Apr 2026 17:28:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=192.198.163.16 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775064486; cv=fail; b=BXmCYK47axbPTwIR5G/at3z1DK68fq+q9MH4h8cKVpzZ2xws6MwHWZVFpS+fDHWFsvsOu2SoXxHIM3psit3dJvOJf7Ewj5md0wfgHJt8eQy7BBClr2+WNz9T+cx9eJenrN3h8hTpgj3wdfdfiJkQ26DyvDF+fypFyCKC1wSdp9Y= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775064486; c=relaxed/simple; bh=tK7gtONKXUZIdiWe0iLsXatK45mM2AZ82+uDaUbFzyo=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=V1hMDQhmvfFWm87xDDKP/pZsoL6TXhg1VGeta7t4opCUMinxMG99VSkxDaGGbzxEWjncnxKVa2DTh1YbXrZ0j9qxDY7Kgmm3YPlJiipCw+OulQikY6KIvkYOPdi/eqWj0Vi6NFGQbkFeDQnSTEWwnAAYnYRPahFNQIIUPkHYxaw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HcV627uR; arc=fail smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HcV627uR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775064485; x=1806600485; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=tK7gtONKXUZIdiWe0iLsXatK45mM2AZ82+uDaUbFzyo=; b=HcV627uRVphA/lBU8eHzDBHEabOKM6qvyicLJzpnO2MLnaVFjBv0ccLJ u0yhcCchqCF0SGJxcqRLeP7OLdGbdu013cQUTKtFVJACn05YydnOUQTaU ZBMrYSbuKfuPqktbCuW67z9la8D3DoreufkitKO4w5ZlaIHiBYkjz29j3 eIpdftVppq4yZ9pEVUCOkuIqBbOC4Pkw5IJ1QD4Bcq+SdO1s4zPNal1Ez jEn8XTvgdXBIZuQB943j/Nz5Os2IKA8AnsZOC5P2cLjRArRZaXDQngPZ7 iCOnjCJtLW0GrRIhc2pIKFKDeQQSFpEX8MmwiSUNhFF/XaL99L+4pGAxW A==; X-CSE-ConnectionGUID: Uf4kiVZ8RMy5p1SIDhXWIA== X-CSE-MsgGUID: 5m4Z1ZdJTmmX2rcLK6tInw== X-IronPort-AV: E=McAfee;i="6800,10657,11745"; a="63662491" X-IronPort-AV: E=Sophos;i="6.23,153,1770624000"; d="scan'208";a="63662491" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2026 10:28:03 -0700 X-CSE-ConnectionGUID: J9pmCkKNSGeoroRMPb00eg== X-CSE-MsgGUID: ho5coHx9SE25qUlW+ZBoPw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,153,1770624000"; d="scan'208";a="257209676" Received: from fmsmsx903.amr.corp.intel.com ([10.18.126.92]) by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2026 10:28:03 -0700 Received: from FMSMSX902.amr.corp.intel.com (10.18.126.91) by fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Wed, 1 Apr 2026 10:28:01 -0700 Received: from fmsedg902.ED.cps.intel.com (10.1.192.144) by FMSMSX902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Wed, 1 Apr 2026 10:28:01 -0700 Received: from SJ2PR03CU001.outbound.protection.outlook.com (52.101.43.23) by edgegateway.intel.com (192.55.55.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Wed, 1 Apr 2026 10:28:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QYChEznRLWOmEcLhEYgxLejyC/kzkemRPackBWWhyOeHR6r+9tYhi4BrS5PLx3Kr1GOyeQdZakmDOQgq4frrgq+mHBDgaYD1f7HO3ag1svNnvbWZSlp7y7tXkLThC/SHDw87MynHur1d/CokPtFzRPEnS0CNzQPpXUx2Tu7jt9y0oyXNKcq3Gh5BkcBmSoTB1E/5999T9HiyN0cWIB5Wt1n6Dv6J++KbDRxCJ7naGKC+t5ApeKW7Eg+K5D+4dBOjLJpn8Foes9NJkUh5lC4kb2jg9eYlzUtKQmlMYYJ91LUHRILTY5pUJJL2N5npLYKEvSufVjCoO29Rdi6+axY+PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p0epMzXK3JI5Tf8Rb2z8MOFpoUwBymlQ5sRrqSfwpnY=; b=F2ZQEz9IrFkkg+NNm6rz0acBLRnv3yzoQqaxAgdU66BKuD4wy9DiJjd106SOXdvXveYMh6j2e4GepK+hATf7kJ/GJWMJfPDsHAvAiaW9Z6QYU+JNTkIaHPgOwxAeQ0NvIkuY6tR8HhH2Immb7oZd7DYVdY9mAWLUGQTPntTwodBYNG4NLh1YDkCpGPpHHcUGncnTsrKcCTu+LG1vdru/lhrK8hIsbO3uC2zU/fn5GmZ6YoQCuAi9K5COjWBQm1PHcTI8JQzAAwDvUxDeRXIZC7HE/HbjdujYPSQw8GV1A/z55qTnrgA+N70/+4gOJQa2FXyIQIyqXNSpyhDclXucAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ2PR11MB7573.namprd11.prod.outlook.com (2603:10b6:a03:4d2::10) by PH7PR11MB5766.namprd11.prod.outlook.com (2603:10b6:510:130::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.16; Wed, 1 Apr 2026 17:27:57 +0000 Received: from SJ2PR11MB7573.namprd11.prod.outlook.com ([fe80::bfe:4ce1:556:4a9d]) by SJ2PR11MB7573.namprd11.prod.outlook.com ([fe80::bfe:4ce1:556:4a9d%5]) with mapi id 15.20.9769.017; Wed, 1 Apr 2026 17:27:53 +0000 Message-ID: Date: Wed, 1 Apr 2026 10:27:51 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/2] fs/resctrl: Report invalid domain ID when parsing io_alloc_cbm To: Aaron Tomlin , , , , , , , , CC: , , , , References: <20260325001159.447075-1-atomlin@atomlin.com> <20260325001159.447075-2-atomlin@atomlin.com> From: Reinette Chatre Content-Language: en-US In-Reply-To: <20260325001159.447075-2-atomlin@atomlin.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4P220CA0020.NAMP220.PROD.OUTLOOK.COM (2603:10b6:303:115::25) To SJ2PR11MB7573.namprd11.prod.outlook.com (2603:10b6:a03:4d2::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR11MB7573:EE_|PH7PR11MB5766:EE_ X-MS-Office365-Filtering-Correlation-Id: 741ce3e1-5b3d-4fbf-c4ee-08de9014016c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: sJgK15sR9QKaezbP/ops4cnIvRaF2od9JrHjoPvcPKyXztZn1QwPIQ/l6l9GdyzIymm4Wo0K/6eKhDdQ2cCG0TABm9D17dNhJSO+HkFFa7oMFlyvY/NQNTHVXuoUVGOKZ9CHJa4DtYAsPOE9FyjgRiB6D1SAwBxHnt3mnltb+RGNMuyIUycKKn8BHq4RQknR8b586a8kSufG1fu/ktF6eM9nzYzZRaWi36ktuNVuuTf1JDkKY2wBh0i1CGZH/gY7588dxehANdbrvVdO9efttXy575HB+Vd+ghK3fgo3oBwBxclv9chUUBqzzGAj7FX7uEViUEhjYeePNe/yJBZzS2c3iL9zvQxaAjypsjBB/dCiEm94dzCkGeIGVtkfy5GANT4YJf4AdeOKxRfpSWZjR6K+eEOESE5W9QFH9eyZO0c9q9MAlN/bwgK3DtMSnyZXi+tatcGbLun5HbZGibB7wD0bcP5Es4at+Gk4nzxmIFjKOEHq+Ku5JQDBtB84lxseWiufjSkbPLBJw9ZfIv40myr+WwX97fITBeuhTCDpp5ipegKqf8TZPIAeDXbJAPP1enmEUJph7OjT0yDEmdErzDJoZSNipIDPTISCQLevxp+8eRIQ85xPd36iNC4a8fBxAv9ZrGDebkThDGZ0BhhHMhgrz3PoVWU+9LGqV17vlCTdhZ2di7A9hhPgCVArR2rnZOZ3O9yFqTzlPIQwsYyKNUdX4BctbcrQVNMYdrZsWUE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ2PR11MB7573.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGYzNTBzRWE0ZXRYSnpUcVdXUWZhUmtwVkhJbm45RnBod2tUbkIyWXRKRmpm?= =?utf-8?B?ZE55NXZ5OVBmdW01SjEycVZ6M2JqQk9KQUovbVhjWFhkY044WmNKZit2Y0JY?= =?utf-8?B?QWJ2UzRMbUxUMy9BSFdJb0xWQTl6VWs3VFpTWVZtZjJmcjJWVFNmL3JzZS90?= =?utf-8?B?ekZkMTZHYnJ3MGlvejQycHh0anQzMzl4bm9tZ3Q3eXY5ZkhKdlVqR1JMUUV2?= =?utf-8?B?aVBsaUZCM0hLODNYTXBWVmdPU05KSWQ5YjI5MGk0WjhiMmhDNTJqYTNTeGNy?= =?utf-8?B?dGU2d2t6MklzdG00dFNCc2tLQWZUQnRrSUlmZWhlblVtM1pFWVFnejhidVFE?= =?utf-8?B?ODczbmdUUUNpdUV2WHFWK3I5UmM0N1ZiM0E1TGcvRy9OYUtHSHZKNWJTamUy?= =?utf-8?B?aXNqYktoaVVRaWxYWVhLR3J4Titab3BSUVBwNFQ4K2ZGT1VJZFh2ZVFlTk0v?= =?utf-8?B?SFl3R3IrUVlnYjZGaXhoRkZJcVZNMjFOTWtYTzBJYlhNeFZ2WHBxOXBlK0tW?= =?utf-8?B?aCt6THhrRnkxTEtibVpNUXhPa0FadTNqMUlRR29zY3VUWndXeFpCRE5lZVhH?= =?utf-8?B?REg5TmJmSUNqcjIyazhHTU1SdWtiZkpkcW5hWXg5M1g1WkMzK2xtVHlCNDMy?= =?utf-8?B?NFVZN0doUzU3d2JNTDJHL09pVGdsdlloVlhHWjBwSnpxdkpBaEx5alRFV3B4?= =?utf-8?B?SER4c253Y0ZJSzJmcXRJYkhnbzhwRGljUElNdkoyYkdTYXpKRW05NUlhNURZ?= =?utf-8?B?TW5DR3RnV0x2RGpBWlMzMzVmd1JHVTRuYThFeHVLL29vSFIzTWsyWmF5bU9K?= =?utf-8?B?NVNtc2JVR091ek1LQmp5cEg0ZmJqNXVuSHJpejh1MGwrdS9BOUdWSW52K3NF?= =?utf-8?B?dnl2L0l3OVdwWWtRWW5UQmpKaXcrdmFUVThqMkhENnZqT0J4V2xLb3JLUnhj?= =?utf-8?B?RW5BejhuaUFhWEwyTXN6amgxMzY1VFB6NkNZbS9IZzRXTlFvSTh5NmJtcGlL?= =?utf-8?B?UWgvay9nTnNMZVhtOC9VSUw5UnduUU5aUHNDWGlacVNOTUEySUg2V1ZuZCtG?= =?utf-8?B?enMzTlNvMU05WFNVN0VlWG0zUWdtTzBDK1NiYjU1N1ZpRjkyZHVyRmdSdjlu?= =?utf-8?B?MTEyN21xUE5JNVQ5SVlJRmtyYlBMTngzTFNFcXFwU1NIaEtzdUhRMUZQTDd4?= =?utf-8?B?NXhlTml6cU11SVRWU3g1MXNDT0NiQTAxRGRPNDNMamttblpVZmlhbTFyV0ov?= =?utf-8?B?QWVSeFlEb2k1ak12cVhTbE1QZHJkOXJRYnM0eUxXREFyZElaenNRL09XZHls?= =?utf-8?B?UlBtU2JnMXU5Mm1CTUpUd0VSaHNqN0dhblZKajkwb3cranIxU2V6TmlCVWNP?= =?utf-8?B?VnNtNG5YK044MTVLTjlCMXlNb1krWkFOZWZkdXdpRkFFS2l5dEdzSTFaUzFS?= =?utf-8?B?WUNBczN2Qm1ydTZHU2FyK1BaODNBd0d0aTRqUitLUk5KdzJKUnBWWGFTKzRi?= =?utf-8?B?VEFSNlMvbmV1S1NuQk5TemVQTEpJNXgyTnJRM0I0MGc0a2V4dlNPcEpoTnJ6?= =?utf-8?B?TFNXaHJWSlhXdDRQUmtodDlRR1IwSDZROFI5b3Q0ZDRnS0FCQTM2bE9yc1li?= =?utf-8?B?M1NoZTY2a3FEY0Frdmd1T0JvQm4ySWpIc0E1c0x0T3NrWTVJMysvZzdja0xM?= =?utf-8?B?eStTTE16V2RKaFplMjZyL3dlZ0szQXowWUVXd25haktweGNLRUE4c29TQ0dI?= =?utf-8?B?ZGdINnRzc1Z2Z2VoemUxaUE1Vk1XUWo4bkdUZ0xIQUU0M2RJckVsMWk4Q24r?= =?utf-8?B?amVaa3h5LzZjNWxKbVg5d1lSOVRQcTgwOEx3SkEwbHoya1JWSlRPVEU1cEpK?= =?utf-8?B?ZTNyS2ZNelU0eEtxWVI1b1JGWW9QQjdVdVM4QWgweUhDNzlka0JNTmthRkdR?= =?utf-8?B?YUNuTWtoSW5yMjlFQ1pJbHFnSnpsYSt3MXBlWGJ0ZzZrVzBlSlFWcFp5eTI3?= =?utf-8?B?eFBLWHowOUQvdlVENm55cEdZQlRxQ1AzNExBZnJ4OTk4Qlo0elZQUkJRQk9S?= =?utf-8?B?SklZVklueGQ3RVBhVW5mQUsrQXVLN2g3MHhuN2ZRMDN6VjVNYnpxZ3JuZFNj?= =?utf-8?B?VTRoM0FwOVcwSGo3UEhqZVlYZWg4WkFrZDNPK2NENzFmTlJDYXdqMTVkU0pi?= =?utf-8?B?NU1HbU1KLytmTHVlaWl4MGwwZEpwZkJxaWxLcjQ1MXVnQVZMWFowY25vdzJI?= =?utf-8?B?NU4zWjB3YS9Iei9wd1VPWWR2WEN0M3JWL2RianRiUmFhLyttMUVZcCtMaFVH?= =?utf-8?B?eTZRYmtpR0Eva01NQmRWSElpa3NndGRjQmNzRnhTN1M2czdZbHl3czN1QUs3?= =?utf-8?Q?haOOn1NE4S+M9+4U=3D?= X-Exchange-RoutingPolicyChecked: JKlWTig2fH0YVuUsLQm6HbUWpV4W0DL5xLI/iRJSj5Rnb7iwdsXXhu3ul7qVDuJUjqdRfGv+TzGhMLs0vcmZDbVxOS7YQbyZRRct+pqx1SzmvEa92aQ7hoYPUHWymBP9siDIt2ypkSLS9dxyIK949RiMVFCIdwYN6tdy2WfX2rkeqYAQ+i/frgWp0YhgywHABRYbm3fw/Jcl2cibccK4zfsID2J8QSSNScJi9jLUVP3Ktt8ynm0iU+D5Btp9iSraeOZjbqM50gLukMC354d/czN3ItbEdoggJ6bN6own8I8bsNpDU1ITJSDXwJFS0O8D6Dv7IgVd9lKJEpizQGjCow== X-MS-Exchange-CrossTenant-Network-Message-Id: 741ce3e1-5b3d-4fbf-c4ee-08de9014016c X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2026 17:27:53.2348 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DJcaphqc0jQy6Kt8VuNQt2Ry+HsTNwVaFNxONd0hzeWwbRg+9rPnZ5xIeOfow+4GU49ZQRUAVn3KRFqsxvSAWxW71A1+qOS5ZoR37OaJAw4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5766 X-OriginatorOrg: intel.com Hi Aaron, On 3/24/26 5:11 PM, Aaron Tomlin wrote: > The last_cmd_status file is intended to report details about the most > recent resctrl filesystem operation, specifically to aid in diagnosing > failures. > > However, when parsing io_alloc_cbm, if a user provides a domain ID that > does not exist in the resource, the operation fails with -EINVAL without > updating last_cmd_status. This results in inconsistent behaviour where > the system call returns an error, but last_cmd_status misleadingly reports > "ok", leaving the user unaware that the failure was caused by an invalid > domain ID. > > Write an error message to last_cmd_status when the target domain ID cannot > be found. > > Fixes: 28fa2cce7a83 ("fs/resctrl: Introduce interface to modify io_alloc capacity bitmasks") > Suggested-by: Reinette Chatre > Signed-off-by: Aaron Tomlin > --- Thank you. Reviewed-by: Reinette Chatre Reinette