From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752063AbdFPFzo (ORCPT ); Fri, 16 Jun 2017 01:55:44 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:46155 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751098AbdFPFzm (ORCPT ); Fri, 16 Jun 2017 01:55:42 -0400 Subject: Re: [PATCH] phy: cpcap-usb: Fix missing return statement To: Tony Lindgren References: <20170612081223.20743-1-tony@atomide.com> CC: , , From: Kishon Vijay Abraham I Message-ID: Date: Fri, 16 Jun 2017 11:25:37 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170612081223.20743-1-tony@atomide.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 12 June 2017 01:42 PM, Tony Lindgren wrote: > Commit 8ae904e3c236 ("phy: cpcap-usb: Add CPCAP PMIC USB support") > is missing return statement as noted by Colin Ian King > . If the optional pins are not configured, > we just want to return early and not attempt to configure the pins. > > Fixes: 8ae904e3c236 ("phy: cpcap-usb: Add CPCAP PMIC USB support") > Reported-by: Colin Ian King > Signed-off-by: Tony Lindgren merged, thanks! -Kishon > --- > drivers/phy/motorola/phy-cpcap-usb.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/phy/motorola/phy-cpcap-usb.c b/drivers/phy/motorola/phy-cpcap-usb.c > --- a/drivers/phy/motorola/phy-cpcap-usb.c > +++ b/drivers/phy/motorola/phy-cpcap-usb.c > @@ -468,6 +468,8 @@ static int cpcap_usb_init_optional_pins(struct cpcap_phy_ddata *ddata) > dev_info(ddata->dev, "default pins not configured: %ld\n", > PTR_ERR(ddata->pins)); > ddata->pins = NULL; > + > + return 0; > } > > ddata->pins_ulpi = pinctrl_lookup_state(ddata->pins, "ulpi"); >