From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E69AF32AAB2 for ; Tue, 25 Nov 2025 17:38:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764092298; cv=none; b=jUNcTEyogZGy0WcipGKcxO3ukZMyGquZELXXT9oq3A0tLHy5IP6/eoVscCPrY7Z2xKKje3qszUaE68oGvESuxr5h0YvpE8Z8w7mUqsW4T+3v4szn3ACnYpZf9i6LnfGfEQ3gjdB1SfczFV8MUAwykPSXfPwXhHcjt9Lq0NMxxdQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764092298; c=relaxed/simple; bh=iPGMl91c7t5RGa6luUsGuLLK2Y4Uq1XKEbahe9phnZw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PjXmBwE2/wHTj9Vi9Jz0Q7o7ufPxyYpvZBmTfwLjkPa//L6FZh61Zl8PgX0iuvk+x7ppNpgCvklnbAWtcnuY1xNqGODCW+niljpt1w2ZDnCnta+fPFYl0FYsbwHGD6UhTuU3T7OhunlUz6VRs1LBhqPrOdixgGBov6894aB8YPQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=MP3eRqnj; arc=none smtp.client-ip=209.85.166.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="MP3eRqnj" Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-94880a46f3fso205117639f.2 for ; Tue, 25 Nov 2025 09:38:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1764092296; x=1764697096; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y/RYkXbjr0Zws5PkDP81koxcOw7wQafJJolXOcPbtL0=; b=MP3eRqnjDMu+VfgIgoXsIjZip2LrEx1us53r4meudiB9JGUbZ72aOCwHVqeWpcZFMf brjS7X4GVj403fOyNyRKQvVZgImprMv3zy3CchjzM+GyfO9KuAvEZRo5BLVq7yb1JW5q SDs7kehGdkBeTBcTdxTsopwd7wvwVVqvy408yKdzW0gEqgdkhuketmjwGMzY7tz/Z1Oo RAYaSxGergG2kfyxRGyXiE5ezp35bLfalGIF4hzgKt+PdBqUIvuhfIChYxFmyuaIhCVf CD81Odhm44Ln9mP2TZF0/SRi6UX6k8xoOAJQc44N7ZQHA+ovauUoXEg2ucKX0zVJe694 35EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764092296; x=1764697096; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y/RYkXbjr0Zws5PkDP81koxcOw7wQafJJolXOcPbtL0=; b=TRH/n7I62QNzvGwIGy0hMxej0+K/rRTuaE7tKlCJ51hHoy4lAvP10EE1uKw6QrRbzP 34QAtM2xnxFBiEkk/TcvAl7BPJzgCyJofc7o2UbDEMpa7UQExM/HLHgTfLg6UjueS14q gIE4nM+26jQ4XvmcyhH7qkURi4z46R/HMCSMugTJ8KOSaii9qdA1pbl/ElB9cuPrEPLu ULrAzj/3CQyvrs8+qyjSEFRiyrFXUCmpTBXJiTEyXVyDYVdqPx9kVCOkLN8KqeQ5i1AM /AGWa5JdBg6Qk5xohbvKSsQ0JzdKd0izqDnjwNsi12L30RjXCcBzqq7XNsARFqVf33Rn +PIQ== X-Forwarded-Encrypted: i=1; AJvYcCWc+XStfgzbJZmE569oF2z39w6T3xACW62Jf7ZjRhyY0ybSR0CGag71kJIkMeaA5sNWpeIwQ7n2MWCWkNI=@vger.kernel.org X-Gm-Message-State: AOJu0YzLHX7gocP1Fll6F+fvUiwKJldWs6FiGwPQscPKX4oSgf1nFpkG txjeOx2/Oqr06Lt2qfZq+CCtFyIr2MAcA3fRQhHnAKceMtoM8RKqIwd9URYcSasdw8Y= X-Gm-Gg: ASbGnctV508s0YvUdtjR4P1hUMov43S2VL5SSYM/Nm3HtlQ3Rcj+FCLv7c2fqyQ+OOX 9gVgImBUaQSSCVUJ+JWKNYvKleg3vP8Lq1eIIdlsDLu9h4jTiXRjJ5Rl+HijBTrXQcQW3gxLx29 HBDpf2woO/LO1D3I2epJBIyOzpjL85uqDPNZaSIcdamzpjRYZJXFxpvZKh/tSEVg0x/M1ioLzYZ 0SGvRLLQTnAaOIBlROTI5S+zdqMuYCf6N3LjHt6fLTCykLIhxSYo2jp4VxfuDLC9YEBQMrL6vGG NliDFUPUwsZ+MoqxDwHqns6H2T5tFTKpYPGUETvey/A0Xk7x7BD3eC40oOWSYKuD2RBKepvQwew hnpbcT/SFIDs5JdWdrj7W/dtQctBdhOjkyUj7mpAarBhOKGOCUyrydzCNlnUyhNG0K5Q= X-Google-Smtp-Source: AGHT+IEIHRk7SwMmVS4xtcTCAS6Qp+OrN5pgC4aYwqKQ9jNrDNwsm/zNssFdQ4CwiXZVR7EmZb+prg== X-Received: by 2002:a05:6638:c0fb:b0:5ac:cd9a:4c4c with SMTP id 8926c6da1cb9f-5b999555c41mr3179432173.2.1764092295677; Tue, 25 Nov 2025 09:38:15 -0800 (PST) Received: from [192.168.1.99] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-5b954b48bdcsm6970840173.45.2025.11.25.09.38.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Nov 2025 09:38:15 -0800 (PST) Message-ID: Date: Tue, 25 Nov 2025 10:38:13 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 1/6] block: ignore discard return value To: Chaitanya Kulkarni , agk@redhat.com, snitzer@kernel.org, mpatocka@redhat.com, song@kernel.org, yukuai@fnnas.com, hch@lst.de, sagi@grimberg.me, kch@nvidia.com, jaegeuk@kernel.org, chao@kernel.org, cem@kernel.org Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, Johannes Thumshirn , "Martin K . Petersen" References: <20251124234806.75216-1-ckulkarnilinux@gmail.com> <20251124234806.75216-2-ckulkarnilinux@gmail.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <20251124234806.75216-2-ckulkarnilinux@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/24/25 4:48 PM, Chaitanya Kulkarni wrote: > __blkdev_issue_discard() always returns 0, making the error check > in blkdev_issue_discard() dead code. Shouldn't it be a void instead then? -- Jens Axboe