From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF731C17441 for ; Mon, 11 Nov 2019 22:29:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C402D20659 for ; Mon, 11 Nov 2019 22:29:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="nWiO84Sa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726960AbfKKW35 (ORCPT ); Mon, 11 Nov 2019 17:29:57 -0500 Received: from linux.microsoft.com ([13.77.154.182]:50332 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726877AbfKKW35 (ORCPT ); Mon, 11 Nov 2019 17:29:57 -0500 Received: from [10.137.112.108] (unknown [131.107.174.108]) by linux.microsoft.com (Postfix) with ESMTPSA id 903CE20B7192; Mon, 11 Nov 2019 14:29:56 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 903CE20B7192 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1573511396; bh=Lx7iits91CkNuBqZLd20zMr4uyVVjAzL/Xch/h41f5Y=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=nWiO84SaocrRuLAxT31uph/FEZblHnCD1LrQAYf0Tp8VnZJqcP2IoqCFkHPAdKThU PcbK2c9WbUxPfU+KRBQvDod7ake+pF2Aa43G0HOMQX7FhJgWfjNmiq+IymA9/gj+Rz bn+ePz+A16Hl+1yd1mENR6WKby+RQmdceiaZ6DnM= Subject: Re: [PATCH] ima: avoid appraise error for hash calc interrupt To: Patrick Callaghan , linux-integrity@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Sascha Hauer , Mimi Zohar References: <20191111192348.30535-1-patrickc@linux.ibm.com> From: Lakshmi Ramasubramanian Message-ID: Date: Mon, 11 Nov 2019 14:29:52 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191111192348.30535-1-patrickc@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/11/19 11:23 AM, Patrick Callaghan wrote: > - if (rbuf_len == 0) > + if (rbuf_len == 0) { /* unexpected EOF */ > + rc = -EINVAL; > break; > + } > offset += rbuf_len; Should there be an additional check to validate that (offset + rbuf_len) is less than i_size before calling cypto_shash_update (since rbuf_len is one of the parameters for this call)? if ((rbuf_len == 0) || (offset + rbuf_len >= i_size)) { rc = -EINVAL; break; } offset += rbuf_len; > rc = crypto_shash_update(shash, rbuf, rbuf_len); -lakshmi