From: Guenter Roeck <linux@roeck-us.net>
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 7/8] hwmon: (scmi) Register explicitly with Thermal Framework
Date: Fri, 28 Oct 2022 08:58:58 -0700 [thread overview]
Message-ID: <e4040686-851c-d8b0-b274-ac71d38685e1@roeck-us.net> (raw)
In-Reply-To: <Y1v2ozURFdIk1PfU@e120937-lin>
On 10/28/22 08:35, Cristian Marussi wrote:
[ ... ]
>>> + /*
>>> + * Try to register a temperature sensor with the Thermal Framework:
>>> + * skip sensors not defined as part of any thermal zone (-ENODEV) but
>>> + * report any other errors related to misconfigured zones/sensors.
>>> + */
>>> + tzd = devm_thermal_of_zone_register(dev, th_sensor->info->id, th_sensor,
>>> + &scmi_hwmon_thermal_ops);
>>> + if (IS_ERR(tzd)) {
>>> + devm_kfree(dev, th_sensor);
>>> +
>>> + if (PTR_ERR(tzd) != -ENODEV)
>>> + return PTR_ERR(tzd);
>>> +
>>> + dev_info(dev, "Sensor '%s' not attached to any thermal zone.\n",
>>> + sensor->name);
>>
>> There were complaints about this message as it is noisy. If you send
>> another version, please drop it unless attaching each sensor to a thermal
>> zone is strongly expected. If you don't send another version, I'll drop it
>> while applying.
>>
>
> Ok fine for me. I am waiting to have some feedback from Sudeep too, but
> I do not have plan for another version as of now.
>
> As a side note, though, I understand the 'noisiness' argument, but,
> sincerely this same message in the original HWMON code was the only
> reason why I spotted that something was wrong with the SCMI/HWMON
> interactions and discovered the indexes/ids mismatch...if not for
> that it would have gone un-noticed that a perfectly configured
> ThermalZone/Sensor was not working properly...
> (un-noticed at least until something would have been burnt to fire
> in my house .. joking :P)
>
Good point.
Did you ever check the returned error code ? Maybe we could use it to
distinguish "it is not attached to a thermal zone because it is not
associated with one" from "attaching to a thermal zone failed because
its configuration is bad/incomplete".
Thanks,
Guenter
next prev parent reply other threads:[~2022-10-28 16:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 14:08 [PATCH 1/8] firmware: arm_scmi: Cleanup core driver removal callback Cristian Marussi
2022-10-28 14:08 ` [PATCH 2/8] firmware: arm_scmi: Suppress bind attributes Cristian Marussi
2022-10-28 14:08 ` [PATCH 3/8] firmware: arm_scmi: Make tx_prepare time out eventually Cristian Marussi
2022-10-28 14:08 ` [PATCH 4/8] firmware: arm_scmi: Make RX chan_setup fail on memory errors Cristian Marussi
2022-10-28 14:08 ` [PATCH 5/8] firmware: arm_scmi: Fix devres allocation device in virtio Cristian Marussi
2022-10-28 14:08 ` [PATCH 6/8] firmware: arm_scmi: Fix deferred_tx_wq release on error paths Cristian Marussi
2022-10-28 14:08 ` [PATCH 7/8] hwmon: (scmi) Register explicitly with Thermal Framework Cristian Marussi
2022-10-28 15:11 ` Guenter Roeck
2022-10-28 15:35 ` Cristian Marussi
2022-10-28 15:58 ` Guenter Roeck [this message]
2022-10-28 16:15 ` Cristian Marussi
2022-10-28 16:34 ` Guenter Roeck
2022-10-28 17:12 ` Cristian Marussi
2022-10-31 11:40 ` [PATCH v2 " Cristian Marussi
2022-10-31 13:25 ` Sudeep Holla
2022-10-31 14:00 ` Guenter Roeck
2022-10-31 14:04 ` Sudeep Holla
2022-10-28 14:08 ` [PATCH 8/8] arm64: dts: juno: Add Thermal critical trip points Cristian Marussi
2022-11-03 7:14 ` Sudeep Holla
2022-11-03 7:09 ` [PATCH 1/8] firmware: arm_scmi: Cleanup core driver removal callback Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4040686-851c-d8b0-b274-ac71d38685e1@roeck-us.net \
--to=linux@roeck-us.net \
--cc=cristian.marussi@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®