From: Neil Armstrong <neil.armstrong@linaro.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
linux-kernel@vger.kernel.org
Cc: linux-amarula@amarulasolutions.com,
David Airlie <airlied@gmail.com>,
Jessica Zhang <jesszhan0024@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Michael Walle <mwalle@kernel.org>,
Simona Vetter <simona@ffwll.ch>,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/4] drm/panel: ilitek-ili9806e: rename to specific DSI driver
Date: Tue, 10 Mar 2026 14:10:10 +0100 [thread overview]
Message-ID: <e40d9b8d-7376-4651-bae4-e4f76c559b96@linaro.org> (raw)
In-Reply-To: <20260114161636.1076706-2-dario.binacchi@amarulasolutions.com>
On 1/14/26 17:16, Dario Binacchi wrote:
> The Ilitek ILI9806E controller can support different transport buses,
> such as MIPI-DSI and SPI. The current implementation is specific to
> the MIPI-DSI interface.
>
> In preparation for adding SPI support, rename the current Kconfig
> symbol and files to be DSI-specific, clarifying the current scope
> of the code.
>
> Since DRM_PANEL_ILITEK_ILI9806E is not used in any in-tree defconfig,
> the symbol is renamed directly to DRM_PANEL_ILITEK_ILI9806E_DSI without
> providing a legacy compatibility alias.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
>
> (no changes since v1)
>
> MAINTAINERS | 2 +-
> drivers/gpu/drm/panel/Kconfig | 6 +++---
> drivers/gpu/drm/panel/Makefile | 2 +-
> ...{panel-ilitek-ili9806e.c => panel-ilitek-ili9806e-dsi.c} | 2 +-
> 4 files changed, 6 insertions(+), 6 deletions(-)
> rename drivers/gpu/drm/panel/{panel-ilitek-ili9806e.c => panel-ilitek-ili9806e-dsi.c} (99%)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0d044a58cbfe..317e76cc99e5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7913,7 +7913,7 @@ F: drivers/gpu/drm/panel/panel-ilitek-ili9805.c
> DRM DRIVER FOR ILITEK ILI9806E PANELS
> M: Michael Walle <mwalle@kernel.org>
> S: Maintained
> -F: drivers/gpu/drm/panel/panel-ilitek-ili9806e.c
> +F: drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c
>
> DRM DRIVER FOR JADARD JD9365DA-H3 MIPI-DSI LCD PANELS
> M: Jagan Teki <jagan@edgeble.ai>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 7a83804fedca..692cd474910d 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -257,14 +257,14 @@ config DRM_PANEL_ILITEK_ILI9805
> Say Y if you want to enable support for panels based on the
> Ilitek ILI9805 controller.
>
> -config DRM_PANEL_ILITEK_ILI9806E
> - tristate "Ilitek ILI9806E-based panels"
> +config DRM_PANEL_ILITEK_ILI9806E_DSI
> + tristate "Ilitek ILI9806E-based DSI panels"
> depends on OF
> depends on DRM_MIPI_DSI
> depends on BACKLIGHT_CLASS_DEVICE
> help
> Say Y if you want to enable support for panels based on the
> - Ilitek ILI9806E controller.
> + Ilitek ILI9806E controller using DSI.
>
> config DRM_PANEL_ILITEK_ILI9881C
> tristate "Ilitek ILI9881C-based panels"
> diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
> index b9562a6fdcb3..00071a983242 100644
> --- a/drivers/gpu/drm/panel/Makefile
> +++ b/drivers/gpu/drm/panel/Makefile
> @@ -26,7 +26,7 @@ obj-$(CONFIG_DRM_PANEL_HYDIS_HV101HD1) += panel-hydis-hv101hd1.o
> obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o
> obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9341) += panel-ilitek-ili9341.o
> obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9805) += panel-ilitek-ili9805.o
> -obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9806E) += panel-ilitek-ili9806e.o
> +obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9806E_DSI) += panel-ilitek-ili9806e-dsi.o
> obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9881C) += panel-ilitek-ili9881c.o
> obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9882T) += panel-ilitek-ili9882t.o
> obj-$(CONFIG_DRM_PANEL_INNOLUX_EJ030NA) += panel-innolux-ej030na.o
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9806e.c b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c
> similarity index 99%
> rename from drivers/gpu/drm/panel/panel-ilitek-ili9806e.c
> rename to drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c
> index 18aa6222b0c5..c337c4f1a1c7 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9806e.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9806e-dsi.c
> @@ -561,5 +561,5 @@ module_mipi_dsi_driver(ili9806e_dsi_driver);
>
> MODULE_AUTHOR("Gunnar Dibbern <gunnar.dibbern@lht.dlh.de>");
> MODULE_AUTHOR("Michael Walle <mwalle@kernel.org>");
> -MODULE_DESCRIPTION("Ilitek ILI9806E Controller Driver");
> +MODULE_DESCRIPTION("Ilitek ILI9806E Controller DSI Driver");
> MODULE_LICENSE("GPL");
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil
next prev parent reply other threads:[~2026-03-10 13:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 16:16 [PATCH v2 0/4] drm/panel: ilitek-ili9806e: add Rocktech RK050HR345-CT106A support Dario Binacchi
2026-01-14 16:16 ` [PATCH v2 1/4] drm/panel: ilitek-ili9806e: rename to specific DSI driver Dario Binacchi
2026-03-10 13:10 ` Neil Armstrong [this message]
2026-01-14 16:16 ` [PATCH v2 2/4] drm/panel: ilitek-ili9806e: split core and DSI logic Dario Binacchi
2026-03-10 13:10 ` Neil Armstrong
2026-01-14 16:16 ` [PATCH v2 3/4] dt-bindings: ili9806e: add Rocktech RK050HR345-CT106A display Dario Binacchi
2026-01-15 19:55 ` Rob Herring (Arm)
2026-01-14 16:16 ` [PATCH v2 4/4] drm/panel: ilitek-ili9806e: add Rocktech RK050HR345-CT106A SPI panel Dario Binacchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e40d9b8d-7376-4651-bae4-e4f76c559b96@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=mwalle@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®