From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B67D1339B1 for ; Sat, 7 Feb 2026 16:04:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770480262; cv=none; b=P96zrCF0UzmKHM2ASdKjLZXnlnaK4KE6IAOB00PhhEdG8ftbcczxufXbLTmaol34mTAdiO3+qQM5LBsr8iFAIKVmy0tF5Zg8Prsnr79esjVINSbqafrB8+2RYZuwgX4P+ka7fswwfashX7Tjln1SzrH6v0bXjtNgd99kNks0now= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770480262; c=relaxed/simple; bh=NiF+hSze+uFtx4K1pSH97Qk0CJDDROC+3zDtnvHgYqs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JNwMa4V4QHgiV37wq6gHsF+QgzPA04N6HziLbjdttNHqipTTn4MStohGc67n9A6/n6BGJnvfRyP1rn7yvpo0w0la6aP17fz/YKYwH0fsX9TV5FHtlLLzxZfZH9QHTCdpRDPBe4jxpCyTPp7+drraUQA1zk3UKA9HxuE/xNWl1yg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UDxGxanI; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UDxGxanI" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-354a2a7d90fso1775002a91.2 for ; Sat, 07 Feb 2026 08:04:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1770480261; x=1771085061; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=07AdAbiuuOL/VfNiqay8fs2J/Ey0wXoFVbLJZzRR6n0=; b=UDxGxanInQvZUaruIHvHjol/dAqvKcGxOIPAlLAR6q+igeEoUhgYkJVTnUlDgIQFiA ZqvEmk7VwEDjVUM2ijKDQpqO4PXw7LLq1cCOf8PiHzEWbQVvNCiXFMuu71f5FA76ycyw qe+LMBBoDsxmXT5bTlWFuSYCfn/EOS+K/dqzE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770480261; x=1771085061; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=07AdAbiuuOL/VfNiqay8fs2J/Ey0wXoFVbLJZzRR6n0=; b=PQs2k9E4Dv4TuMFrzXM6Xj8XdtRYhtn6zeESU0sYQKa7GPLsbAux2W2zB/7aD6nb/6 B3EaJAhS2VJeJobD2Bxf/S2J5fmROEHr0WQNEeaIMOGQUqzIsjmr6sTcYlFU3qOJnAB9 7qXJD54XiK8robvXpHnqdFik0fe8qjWzDa2++cOYd244499lP3HGeOfpVJz8ZwOE0jEy tjw3OcZerOrJQbPECBNkCn9tNTx8WAzzwciPw1JV53yEZmAERjXOS1mTHcySsUdLcNTj TGg3T2RObvbwoFX663dkfY2CQbuUg5u0itFZqOYX+MlB9dc5FxP4YbWcEoE3wJunUVBa 6ZHw== X-Gm-Message-State: AOJu0Ywhb0BupNkYql78X7no9iXAy8348eAoLGYk7V2RbP0MWvdQjd0u SOU1NliimHCn0YIVIi3v6xPCwbJeQls3Cig5aFw8NXukXKR0fa4FEEXEgNlTbJS9FB8= X-Gm-Gg: AZuq6aI+YjJV/JwnfEabATnSJrqQvUIzSmSF0zwIiut9URktD6IhxeR2wzkWswvQMjI N0mKn9LEYw2sym/UYKMU0vMKcgIbHbxAfZyT4J1shhvy1kXF3dv+lMZ9/UOoNHQ33vyIFGFt+v+ PzBj6vP3cIQLoqFaE9b2I0BiLRphEAYYrI1H3lxbmkTMqYp5VxyJwV33qoTdyCW4TsE5cvU6nUf zcx272EbDh1qbhzc0Pg3TXUfZeEDfdxUPKbr64e1ODr5RDqH+enm9g5uryQ+CJ37WWXLUwTPRgh cgTu3iKEw43Si45dIyKy8u/G7+3RMFPnkQ5rWJP8TT4GU7ppdw/2qjjhj1qpnjkYCVMFghjda85 /fU0Hf9kv/+QpMIzIT7F7E/uFQJufVxN7sPFmT0ofcv7X9yIT+ACJzTfpTuxXTkVvXc5OPmlYj+ OKnQJx4tCq+gX9bLtvJwynLoHGpcyFVeNvNRA= X-Received: by 2002:a17:90b:3a0c:b0:354:c600:1a1 with SMTP id 98e67ed59e1d1-354c60003bbmr2416485a91.19.1770480261380; Sat, 07 Feb 2026 08:04:21 -0800 (PST) Received: from [192.168.96.30] ([49.207.181.115]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-354b2253c70sm5866108a91.17.2026.02.07.08.04.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Feb 2026 08:04:20 -0800 (PST) Message-ID: Date: Sat, 7 Feb 2026 09:04:15 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tools/power/cpupower: Replace strcpy/strcat with snprintf in powercap.c To: Sumeet Pawnikar , trenn@suse.com, shuah@kernel.org, jwyatt@redhat.com, jkacur@redhat.com, linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Shuah Khan References: <20260131164233.7924-1-sumeet4linux@gmail.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20260131164233.7924-1-sumeet4linux@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/31/26 09:42, Sumeet Pawnikar wrote: > Replace all unsafe strcpy() and strcat() calls with snprintf() in > powercap.c to prevent potential buffer overflow vulnerabilities. > The snprintf() function performs automatic bounds checking to ensure > the destination buffer is not overflowed. Why snprintf() - why not use strncpy() and strncat() > > No functional change. Why isn't this a functional change? You are changing the code to use a different system call? How did you test this patch? thanks, -- Shuah