From: David Vrabel <david.vrabel@citrix.com>
To: Juergen Gross <jgross@suse.com>,
Paul Durrant <paul.durrant@citrix.com>,
<xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v3] xenbus: advertize control feature flags
Date: Tue, 11 Oct 2016 12:25:57 +0100 [thread overview]
Message-ID: <e41659c8-2718-823f-3159-1a2396138010@citrix.com> (raw)
In-Reply-To: <e1ce7a6e-29d5-ce49-a786-58d33d38cba2@suse.com>
On 11/10/16 11:53, Juergen Gross wrote:
> On 10/10/16 12:13, Paul Durrant wrote:
>> The Xen docs specify several flags which a guest can set to advertize
>> which values of the xenstore control/shutdown key it will recognize.
>> This patch adds code to write all the relevant feature-flag keys.
>>
>> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
>> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>> Cc: David Vrabel <david.vrabel@citrix.com>
>> Cc: Juergen Gross <jgross@suse.com>
>
> Hmm, I'd prefer node[] allocated on the stack over dynamic allocation.
>
> What about something like the following? It will at least issue build
> warnings in case the size is too small, will use less memory and less
> coding.
You still want snprintf() just to be sure. You can add a Reviewed-by
David Vrabel <david.vrabel@citrix.com> if you make this change.
David
prev parent reply other threads:[~2016-10-11 11:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 10:13 Paul Durrant
2016-10-11 10:53 ` Juergen Gross
2016-10-11 11:25 ` David Vrabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e41659c8-2718-823f-3159-1a2396138010@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®