From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92721C433E2 for ; Mon, 31 Aug 2020 08:14:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A082206F0 for ; Mon, 31 Aug 2020 08:14:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728134AbgHaIOB (ORCPT ); Mon, 31 Aug 2020 04:14:01 -0400 Received: from foss.arm.com ([217.140.110.172]:54892 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725978AbgHaIOB (ORCPT ); Mon, 31 Aug 2020 04:14:01 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 814D531B; Mon, 31 Aug 2020 01:14:00 -0700 (PDT) Received: from [10.57.6.112] (unknown [10.57.6.112]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E224F3F68F; Mon, 31 Aug 2020 01:13:57 -0700 (PDT) Subject: Re: [PATCH 3/4] kselftests/arm64: add PAuth test for whether exec() changes keys To: Boyan Karatotev , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Cc: vincenzo.frascino@arm.com, boian4o1@gmail.com, Shuah Khan , Catalin Marinas , Will Deacon References: <20200828131606.7946-1-boyan.karatotev@arm.com> <20200828131606.7946-4-boyan.karatotev@arm.com> From: Amit Kachhap Message-ID: Date: Mon, 31 Aug 2020 13:43:55 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200828131606.7946-4-boyan.karatotev@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/28/20 6:46 PM, Boyan Karatotev wrote: > Kernel documentation states that it will change PAuth keys on exec() calls. > > Verify that all keys are correctly switched to new ones. > > Cc: Shuah Khan > Cc: Catalin Marinas > Cc: Will Deacon > Signed-off-by: Boyan Karatotev The changes look fine so, Reviewed-by: Amit Daniel Kachhap > --- > tools/testing/selftests/arm64/pauth/Makefile | 4 + > .../selftests/arm64/pauth/exec_target.c | 35 +++++ > tools/testing/selftests/arm64/pauth/helper.h | 10 ++ > tools/testing/selftests/arm64/pauth/pac.c | 148 ++++++++++++++++++ > 4 files changed, 197 insertions(+) > create mode 100644 tools/testing/selftests/arm64/pauth/exec_target.c > > diff --git a/tools/testing/selftests/arm64/pauth/Makefile b/tools/testing/selftests/arm64/pauth/Makefile > index a017d1c8dd58..2e237b21ccf6 100644 > --- a/tools/testing/selftests/arm64/pauth/Makefile > +++ b/tools/testing/selftests/arm64/pauth/Makefile > @@ -5,6 +5,7 @@ CFLAGS += -mbranch-protection=pac-ret >