From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751619AbeAAQlU (ORCPT + 1 other); Mon, 1 Jan 2018 11:41:20 -0500 Received: from mout.web.de ([212.227.15.14]:50904 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819AbeAAQlS (ORCPT ); Mon, 1 Jan 2018 11:41:18 -0500 To: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allen Pais , Arnd Bergmann , "David S. Miller" , Florian Fainelli , Himanshu Jha , Johannes Berg , Jonas Gorski , Kees Cook , Sergei Shtylyov , Yuval Shaia From: SF Markus Elfring Subject: [PATCH] bcm63xx_enet: Delete two error messages for a failed memory allocation in bcm_enetsw_open() Cc: LKML , kernel-janitors@vger.kernel.org Message-ID: Date: Mon, 1 Jan 2018 17:40:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:AzObis6Qd/uXGsVoG6lKe09tXffhIxzlPQIaVBnTjAfgKDieRWm ytajHI/LY/z+bKqrR969zrsdAPvtAai8aYso3fOji31+Bf2iN+/7xRG/42kxHCWl9IujbwS 8hMzgMC4GEy2gOdBps1Zycu5ZlgCajBRleWDQRdSZ5wtGF8ceR/Z+iR1cukRyRb6Bcew+rU SKJnQdrvNddz9doebodsQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:FFl6VhtDHM0=:jqQ5/vQoMwl+OEkm0Ww0SS 3zDRsu3Oeer/OhCdSh1wef06KelnatmTN02XcK4Qj/s22+MfaOBn/1k6FgtNw/xbmUSXvG6qM V2KNKVWalUEsLsHa8p7ZTHzT6KMcgeDcRbv6wcJt84lAAW2B+oKAPhCZ8kkE7DAHXP/y/xVhH GzWr4w3pBw2ylXNuroXyGlvjJxzk7XIvIdXIFbd/S/5i9vEth1I2ZashJ1SOzgx71DjFCZZjH mTAT3NfsELZK1dUlc/0V3/kOCMV8CCh62JVt4+bZxRqO/s08PY3qpC8t2MEFmLqb+rOx1Va/0 XvuFKtd1ebabN1YIPqGsg0Uo3kVJ9AnnlcwkUlkjqZeIKjV09DCyRJQQ1dSRFDvLpFPhN1b0P x2CDtNKzkOmA4p6bpt9wQWhBBHe3gKq9l4ReCo8GHtrOv4hRde3SHzYP6V59AxlGw8IXhQyzz LiwKyeVUzBnReKJvJnenRKSrtdpsgN2pRsQRI7H0HITmsIiyCFBxcueoARluq2KNYDGO1xN6o nZzTP42rsTJXbRdmE7JNrWNEVZODMT85+H5o8ea1j5hMIjjepx6Ej01ToP0gx9lIX4f/l5Rje AxJ7AyTAXDkYBjmN+7FeygndC0jmK8GecSq7cuVtMEsJvjHKC4yX4qhzDRMZCLLMPLj7IFhB7 SnCxv+n7JP76wwh6P9af9+KvF5oc27knzMJg4FcjjkGr19hup/u2bUj/1nfX+a8GNq2Ukfi/6 dNUHLvodjbMszpQ+WIAeSZCbW4Wzb17B9wVW4XDVZtESzOAlgnGAe9gRHrX5Fv/Zvo8nfyFvf TsHngjVdwJxxTLLDWZ4ec2ozBS0ig6L0EPfzsekE3BRWLrZmwE= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: From: Markus Elfring Date: Mon, 1 Jan 2018 17:30:04 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c index d9346e2ac720..52a42e3058cf 100644 --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c @@ -2166,7 +2166,6 @@ static int bcm_enetsw_open(struct net_device *dev) priv->tx_skb = kzalloc(sizeof(struct sk_buff *) * priv->tx_ring_size, GFP_KERNEL); if (!priv->tx_skb) { - dev_err(kdev, "cannot allocate rx skb queue\n"); ret = -ENOMEM; goto out_free_tx_ring; } @@ -2180,7 +2179,6 @@ static int bcm_enetsw_open(struct net_device *dev) priv->rx_skb = kzalloc(sizeof(struct sk_buff *) * priv->rx_ring_size, GFP_KERNEL); if (!priv->rx_skb) { - dev_err(kdev, "cannot allocate rx skb queue\n"); ret = -ENOMEM; goto out_free_tx_skb; } -- 2.15.1