From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0D36C433DF for ; Sun, 18 Oct 2020 07:22:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A75F2223F for ; Sun, 18 Oct 2020 07:22:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726228AbgJRHLZ (ORCPT ); Sun, 18 Oct 2020 03:11:25 -0400 Received: from smtprelay0183.hostedemail.com ([216.40.44.183]:50734 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725275AbgJRHLX (ORCPT ); Sun, 18 Oct 2020 03:11:23 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id 7FDA4181D341E; Sun, 18 Oct 2020 07:11:22 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: sand51_3b152dd2722c X-Filterd-Recvd-Size: 1625 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA; Sun, 18 Oct 2020 07:11:21 +0000 (UTC) Message-ID: Subject: Re: [PATCH v5] checkpatch: add new exception to repeated word check From: Joe Perches To: Dwaipayan Ray Cc: linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel , Lukas Bulwahn Date: Sun, 18 Oct 2020 00:11:20 -0700 In-Reply-To: References: <20201017162732.152351-1-dwaipayanray1@gmail.com> <1ad9c5f49e10a192f0c6efb1116f3f0d31adce74.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-10-18 at 12:10 +0530, Dwaipayan Ray wrote: > print index(" \t.,;?!", ''); > > It output 0 in my case. So last words on a line seems to work. > I don't know if this changes with the perl version though. > > So given this, will it be necessary to change end_char to ' ' ? > or perhaps change both start_char and end_char to a ' ' to maintain > uniformity? It seems it's fine even back to perl 5.6, so it's fine as is. cheers, Joe