From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C48C4C433FE for ; Fri, 21 Jan 2022 02:08:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378452AbiAUCIy (ORCPT ); Thu, 20 Jan 2022 21:08:54 -0500 Received: from mailgw01.mediatek.com ([60.244.123.138]:48942 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S244982AbiAUCIx (ORCPT ); Thu, 20 Jan 2022 21:08:53 -0500 X-UUID: d89c17bc827a4c38b6c8ef0c5ffc0d83-20220121 X-UUID: d89c17bc827a4c38b6c8ef0c5ffc0d83-20220121 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1408320461; Fri, 21 Jan 2022 10:08:49 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Fri, 21 Jan 2022 10:08:47 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Fri, 21 Jan 2022 10:08:47 +0800 Message-ID: Subject: Re: [PATCH v1, 1/1] soc: mediatek: cmdq: add cmdq_pkt_poll_addr function From: CK Hu To: Yongqiang Niu , Chun-Kuang Hu CC: , , David Airlie , Jassi Brar , , , "Dennis YC Hsieh" , Fabien Parent , Rob Herring , , Hsin-Yi Wang , Matthias Brugger , mtk18742 , Date: Fri, 21 Jan 2022 10:08:47 +0800 In-Reply-To: <20220120074311.2243-2-yongqiang.niu@mediatek.com> References: <20220120074311.2243-1-yongqiang.niu@mediatek.com> <20220120074311.2243-2-yongqiang.niu@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Yongqiang: On Thu, 2022-01-20 at 15:43 +0800, Yongqiang Niu wrote: > From: mtk18742 > > add cmdq_pkt_poll_addr function in cmdq helper functions > > Signed-off-by: Yongqiang Niu > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 39 > ++++++++++++++++++++++++ > include/linux/mailbox/mtk-cmdq-mailbox.h | 1 + > include/linux/soc/mediatek/mtk-cmdq.h | 2 ++ > 3 files changed, 42 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c > b/drivers/soc/mediatek/mtk-cmdq-helper.c > index 3c8e4212d941..6c5cfb284140 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -344,6 +344,45 @@ int cmdq_pkt_set_event(struct cmdq_pkt *pkt, u16 > event) > } > EXPORT_SYMBOL(cmdq_pkt_set_event); > > +s32 cmdq_pkt_poll_addr(struct cmdq_pkt *pkt, u32 value, u32 addr, > u32 mask, u8 reg_gpr) > +{ > + struct cmdq_instruction inst = { {0} }; > + > + s32 err; > + > + if (mask != 0xffffffff) { > + inst.op = CMDQ_CODE_MASK; > + inst.mask = ~mask; > + err = cmdq_pkt_append_command(pkt, inst); > + if (err != 0) > + return err; > + > + addr = addr | 0x1; > + } > + > + /* Move extra handle APB address to GPR */ > + inst.op = CMDQ_CODE_MOVE; > + inst.value = addr; > + inst.sop = reg_gpr; > + inst.dst_t = 1; > + err = cmdq_pkt_append_command(pkt, inst); > + if (err != 0) > + pr_err("%s fail append command move addr to reg > err:%d", > + __func__, err); cmdq_pkt_assign() could assign a value to GPR, so remove this part. > + > + inst.op = CMDQ_CODE_POLL; > + inst.value = value; > + inst.sop = reg_gpr; > + inst.dst_t = 1; > + err = cmdq_pkt_append_command(pkt, inst); > + if (err != 0) > + pr_err("%s fail append command poll err:%d", > + __func__, err); > + > + return err; > +} > +EXPORT_SYMBOL(cmdq_pkt_poll_addr); > + > int cmdq_pkt_poll(struct cmdq_pkt *pkt, u8 subsys, > u16 offset, u32 value) > { > diff --git a/include/linux/mailbox/mtk-cmdq-mailbox.h > b/include/linux/mailbox/mtk-cmdq-mailbox.h > index 44365aab043c..a27329fd7c7f 100644 > --- a/include/linux/mailbox/mtk-cmdq-mailbox.h > +++ b/include/linux/mailbox/mtk-cmdq-mailbox.h > @@ -54,6 +54,7 @@ > */ > enum cmdq_code { > CMDQ_CODE_MASK = 0x02, > + CMDQ_CODE_MOVE = 0x02, > CMDQ_CODE_WRITE = 0x04, > CMDQ_CODE_POLL = 0x08, > CMDQ_CODE_JUMP = 0x10, > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h > b/include/linux/soc/mediatek/mtk-cmdq.h > index ac6b5f3cba95..28dc5ce0ff03 100644 > --- a/include/linux/soc/mediatek/mtk-cmdq.h > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > @@ -280,4 +280,6 @@ int cmdq_pkt_finalize(struct cmdq_pkt *pkt); > int cmdq_pkt_flush_async(struct cmdq_pkt *pkt, cmdq_async_flush_cb > cb, > void *data); > Add comment for this function, parameters, and return value like other interface. Regards, CK > +s32 cmdq_pkt_poll_addr(struct cmdq_pkt *pkt, u32 value, u32 addr, > u32 mask, u8 reg_gpr); > + > #endif /* __MTK_CMDQ_H__ */