From: Paolo Bonzini <pbonzini@redhat.com>
To: Suleiman Souhlal <suleiman@google.com>,
rkrcmar@redhat.com, tglx@linutronix.de
Cc: john.stultz@linaro.org, sboyd@kernel.org,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
ssouhlal@freebsd.org, tfiga@chromium.org, vkuznets@redhat.com
Subject: Re: [RFC v2 1/2] kvm: Mechanism to copy host timekeeping parameters into guest.
Date: Thu, 10 Oct 2019 12:50:43 +0200 [thread overview]
Message-ID: <e436f19b-8ff9-9442-897d-07fed3b424a4@redhat.com> (raw)
In-Reply-To: <20191010073055.183635-2-suleiman@google.com>
On 10/10/19 09:30, Suleiman Souhlal wrote:
> kvmclock_reset(vcpu);
>
> + if (vcpu->arch.pv_timekeeper_enabled)
> + atomic_dec(&pv_timekeepers_nr);
> +
Please make the new MSR systemwide, there's no need to have one copy per
vCPU. Also, it has to be cleared on reset. I have just sent a patch
"[PATCH] kvm: clear kvmclock MSR on reset" and CCed you, you can add the
clearing to kvmclock_reset with that patch applied.
Paolo
next prev parent reply other threads:[~2019-10-10 10:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 7:30 [RFC v2 0/2] kvm: Use host timekeeping in guest Suleiman Souhlal
2019-10-10 7:30 ` [RFC v2 1/2] kvm: Mechanism to copy host timekeeping parameters into guest Suleiman Souhlal
2019-10-10 8:31 ` Vitaly Kuznetsov
2019-10-10 10:50 ` Paolo Bonzini [this message]
2019-10-10 7:30 ` [RFC v2 2/2] x86/kvmclock: Introduce kvm-hostclock clocksource Suleiman Souhlal
2019-10-10 8:37 ` Vitaly Kuznetsov
2019-10-10 10:55 ` Paolo Bonzini
2019-10-15 8:39 ` Suleiman Souhlal
2019-10-15 8:59 ` Paolo Bonzini
2019-10-10 10:39 ` [RFC v2 0/2] kvm: Use host timekeeping in guest Roman Kagan
2019-10-11 18:50 ` Konrad Rzeszutek Wilk
2019-10-15 5:08 ` Suleiman Souhlal
2019-10-10 10:43 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e436f19b-8ff9-9442-897d-07fed3b424a4@redhat.com \
--to=pbonzini@redhat.com \
--cc=john.stultz@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=sboyd@kernel.org \
--cc=ssouhlal@freebsd.org \
--cc=suleiman@google.com \
--cc=tfiga@chromium.org \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®