From: Krish Sadhukhan <krish.sadhukhan@oracle.com>
To: lihaiwei.kernel@gmail.com, x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: pbonzini@redhat.com, sean.j.christopherson@intel.com,
vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com,
joro@8bytes.org, tglx@linutronix.de, hpa@zytor.com,
Haiwei Li <lihaiwei@tencent.com>
Subject: Re: [PATCH] KVM: SVM: Get rid of the variable 'exit_fastpath'
Date: Tue, 15 Sep 2020 10:58:39 -0700 [thread overview]
Message-ID: <e43717a4-cf87-4704-27d5-3d8acce75685@oracle.com> (raw)
In-Reply-To: <20200915113033.61817-1-lihaiwei.kernel@gmail.com>
On 9/15/20 4:30 AM, lihaiwei.kernel@gmail.com wrote:
> From: Haiwei Li <lihaiwei@tencent.com>
>
> 'exit_fastpath' isn't used anywhere else, so remove it.
>
> Suggested-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
> Signed-off-by: Haiwei Li <lihaiwei@tencent.com>
> ---
> arch/x86/kvm/svm/svm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> index c44f3e9..6e88658 100644
> --- a/arch/x86/kvm/svm/svm.c
> +++ b/arch/x86/kvm/svm/svm.c
> @@ -3413,7 +3413,6 @@ static noinstr void svm_vcpu_enter_exit(struct kvm_vcpu *vcpu,
>
> static __no_kcsan fastpath_t svm_vcpu_run(struct kvm_vcpu *vcpu)
> {
> - fastpath_t exit_fastpath;
> struct vcpu_svm *svm = to_svm(vcpu);
>
> svm->vmcb->save.rax = vcpu->arch.regs[VCPU_REGS_RAX];
> @@ -3536,8 +3535,7 @@ static __no_kcsan fastpath_t svm_vcpu_run(struct kvm_vcpu *vcpu)
> svm_handle_mce(svm);
>
> svm_complete_interrupts(svm);
> - exit_fastpath = svm_exit_handlers_fastpath(vcpu);
> - return exit_fastpath;
> + return svm_exit_handlers_fastpath(vcpu);
> }
>
> static void svm_load_mmu_pgd(struct kvm_vcpu *vcpu, unsigned long root,
Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
prev parent reply other threads:[~2020-09-15 18:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 11:30 lihaiwei.kernel
2020-09-15 17:58 ` Krish Sadhukhan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e43717a4-cf87-4704-27d5-3d8acce75685@oracle.com \
--to=krish.sadhukhan@oracle.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=lihaiwei.kernel@gmail.com \
--cc=lihaiwei@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®