From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BC6C3CD8AC for ; Tue, 26 May 2026 09:39:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779788347; cv=none; b=i4RbQxUU087I6lfSsdc8X586zV69VtiA8DL1caeM2NfraxCgt5sphboONCtgVYv9fyfbHgcSxoxO2Y53v4o98UiWfajkPCjeVOaAIm45K7+XeDxwMyKA7jsMymJxKRMZPcXKeRgE964D2M3odxyElu99aNiT6V7YujNuL7qT73w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779788347; c=relaxed/simple; bh=xGbbke4qs67cQaM7X06MHN9UsL3fDt1K8ypn24U7MH8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nzIIlnJOSgSz04oqIA9ndsTX1mV+8weXtV6wCaP21mfi9w4ANJQn4hzybuhKniVaSUek7hN1TzHxR/AqzT/UsTBH4oNPFHo/e7x7WCw3g38oafUBlG/uQISVhmbE0cVNgTaxczyCh/Yo2ClaqFTw1Sxvq5YbkhCVaU245CzCY+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lLVqS289; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kMZbC6Ey; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lLVqS289"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kMZbC6Ey" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64Q71ZAS1580322 for ; Tue, 26 May 2026 09:39:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xUEHZrut4x8hOGmiwUwt+Zp4CsxN2AZtJNhdB6w6WY0=; b=lLVqS289yE9mP6Cq 27Xl0rqQcHh8cOK01DCylyNL5RzIzjEqcPYKfbgngji/85uQLpq0zgpdiqIjBP/8 wXElgFfXa1D5wevf7Flg394sypcE0UtT+ABY9g7Bqg9d2ppOaK05B/msiY4NzZQt vgfVu2PjtLtP847KckxY/F0hkMskf0pJrvclB/NCN/dQBaBT0xYSY90dQlIcDpNj 1huCbK7rnmPUk/jGDaTivvcAKGVpOGl++L68H+ygeQZbs8iTAPh3MzS0fP5zCaGD 293QORNFphaz1CfCzAzaFHTlEltL4mwiwbOhVUFSJzOYlDhowVLGUFdwj65V2TUy byXJfQ== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eckmac25t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 26 May 2026 09:39:05 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-367cb6de61aso3573515a91.1 for ; Tue, 26 May 2026 02:39:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779788345; x=1780393145; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xUEHZrut4x8hOGmiwUwt+Zp4CsxN2AZtJNhdB6w6WY0=; b=kMZbC6Ey7+cv3jzwqy3LWFkCvVGuxbTO+YaAWeobUqw6zDy15Sfx48FmZRwClee3sJ NTUIXWKsKhlG5VA52pLVGOxdR34ex18Dsq9zZcDWJ/J+O/a809kKMlINtbyEflv8SFZ5 Pi9dYnO4OIvXBQUirp25uUntga1vJFvO3XjafXjZxWJ8m4ZyzLYaCduiG94GpQdc36Ju HIC5Un8ci5wLQyjvVLfFllNycD5OAark3JGfyX1Vd/98WNj+3aT0WNSRTh7sReF0NLwl pWEk4YD2zV1Ub6jHvQj+8syWA3suEAEknf7FZxXvNJG20UMnE940cuM44K/WaZYb5CR0 csQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779788345; x=1780393145; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xUEHZrut4x8hOGmiwUwt+Zp4CsxN2AZtJNhdB6w6WY0=; b=hoM6wVVOPhlpJjiVEHpkNZYpOy2poIM3/8Pf7CI3Mzs5iY4RLxmhIAFuWOhgNhU+DD NYhHxfLPA+/gcmKPHjcyoY2L87EDVxTWagtH+Zz42L7bR2fpUCxf+xoHTSOqQ3EuAhys qykSxXIx+W/rYCtKPV63l0yt0cygIAFda7O3hdFHNkbA0G5HJtQeKXnLOn5KXdRH2NMu XVdpKSNj1k+rNCCPIcntzIfL1s5bROAum/Q1MIViIRYURQFKaJs7kCjket3VVgJdL3h6 6kk/I1AgPEFTNnUSOXRdxzYlRoRmMojIMjOotIIGWUlvrptfkPaO5SfT+QvUw14if+0h ovqg== X-Forwarded-Encrypted: i=1; AFNElJ9elQwtN0r2RXgL7L/Caeq8ORs4shrG4VJYKxstbemFH9U7rjt/8e2nEB6A/gmHZsOGrfN9+FURHK226p0=@vger.kernel.org X-Gm-Message-State: AOJu0YzF4/MvVvYj6K2q7UGCVKSM+Q+d+etj4WKcoNX5yMrA5SqaySJF SCOGplE/0DUo6sk6kJmqcKhO2foxsH0YLz0wZf6JN750JEduKxkeKsoA+40LS4qBjDnJ1TfORcF W8uYiAfP+naOIWstJwViM8OUz/42jXc+RaoIM+enJPYwDm16rUeghbmXFUJCKr3Lx6ao= X-Gm-Gg: Acq92OEvwTjOueEvdL43C9WrUEx+CtiY6M8AoP4hLLjxodM0Ihotjp1VctOWs0J1J2x Y4A+IAyz+jh0V64MIz2qdlBXkK6GWkW5UZAsCmsBIOdTzVLxz/gsDSSAp2j/yoQoCXv0PODfm/l 1Sttn/jJypm1lQclo3449C5tNj08vVeJXdg59UD+MeJfPVORw3+4dhDwJZXUts9Kh9cIjZBmtD2 LfpOsyQkY3GJuMfMR2eP2pJWDMLOAexrrEgQwBGjSGyLILZqskNesxiwpM4xN5eeLLn8fz7qTsO 8RqbQCO/R8QUYyj4AE7GPs4Io2IkoKPQ7B2mBNU7NT1s8ZmTVRXqgHFZRRkmJfnW7n4orF7ZyYT PCmbKKWNwJFz2YfJAhH4hIX2VZGbiEeyUYtjbfbubLQJxDUO9uct64Jvk2RE= X-Received: by 2002:a17:90b:2b88:b0:367:db13:aca6 with SMTP id 98e67ed59e1d1-36a6785aedcmr18232579a91.26.1779788344999; Tue, 26 May 2026 02:39:04 -0700 (PDT) X-Received: by 2002:a17:90b:2b88:b0:367:db13:aca6 with SMTP id 98e67ed59e1d1-36a6785aedcmr18232491a91.26.1779788343870; Tue, 26 May 2026 02:39:03 -0700 (PDT) Received: from [10.151.36.45] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36af07555edsm1381606a91.5.2026.05.26.02.39.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2026 02:39:03 -0700 (PDT) Message-ID: Date: Tue, 26 May 2026 15:08:58 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] regulator: mp8899: Add MPS MP8899 PMIC regulator driver To: Krzysztof Kozlowski Cc: Saravanan Sekar , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Manikanta Mylavarapu References: <20260519-mp8899-regulator-driver-v1-0-30d14421b7f1@oss.qualcomm.com> <20260519-mp8899-regulator-driver-v1-2-30d14421b7f1@oss.qualcomm.com> <20260520-luminous-tacky-swallow-a455d3@quoll> <0993456c-40ed-4fc2-b9a8-036cca928709@oss.qualcomm.com> Content-Language: en-US From: Vignesh Viswanathan In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=cL3QdFeN c=1 sm=1 tr=0 ts=6a156a39 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=UBsTDkLht3fk7gMvnXgA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: MKNh4xyzeGfmEKc9jHNSu0EOb071pOUT X-Proofpoint-GUID: MKNh4xyzeGfmEKc9jHNSu0EOb071pOUT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI2MDA4NCBTYWx0ZWRfXwfEkKdd6atNs waciCGTjSnyc4h/8HUxYpLBoFuMlGEq4Q4JbdOsFgTiTcNihbWpA8/5PJQiQjoAnG4qroAChDNn yexqoRd5RANWnZGzJ5/OjujsVsZQ8rRupu5ex0Ewyye249aWMu9+KSlV3V7c8+Vi5ZBC/KDeeao hvgvDA5GX/CS8aeVXumQSzDTFFUzBnsVvdnBzsf53Z+KvQpdjaDeUNMqwwNjE9bSzMin/Ei43SX Tn5CD9KI8qWBMukG0cfsSsDXNxHpGLGWN19b197tqJCcduB8it9Lq0YoPgPARYuS/DCs4HmvUF8 AZT64hoVo7tnVfBi0chG9IhME8Di+TuaRTQkqVJW1PWfpirhHggkmfM5Ecdk/BsjSpxzieWNJFj sby1hZvUhH3zbLqo1jU31Cu5MjNobDkHP17PJxtjo2Gnz/V+j7u82/2Mr8i1J3+E61dELapViQ4 q3bGM+34jPGQPAr00XQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-26_02,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 priorityscore=1501 phishscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605260084 On 5/26/2026 2:58 PM, Krzysztof Kozlowski wrote: > On 26/05/2026 09:39, Vignesh Viswanathan wrote: >>>> + */ >>>> +static int mp8899_i2c_probe(struct i2c_client *client) >>>> +{ >>>> + struct mp8899_regulator_info *info; >>>> + struct regulator_config config = {}; >>>> + struct device *dev = &client->dev; >>>> + struct regulator_dev *rdev; >>>> + struct regmap *regmap; >>>> + unsigned int vout_select; >>>> + int i, ret; >>>> + >>>> + info = devm_kzalloc(dev, sizeof(struct mp8899_regulator_info), GFP_KERNEL); >>> >>> This is some very old code. If you were working on upstream, you would >>> notice that syntax is sizeof(*). But NOW the syntax is even simpler: kzalloc_obj(). >> >> Ack, will fix this. > > I might be wrong about second part - it seems there is no > devm_kzalloc_obj, so devm_kzalloc is correct. But anyway please use > sizeof(*) style. Sure Krzysztof, Will do. Thanks, Vignesh > > Best regards, > Krzysztof