From: Paul Moore <paul@paul-moore.com>
To: Babanpreet Singh <bbnpreetsingh@gmail.com>,
Eric Paris <eparis@redhat.com>
Cc: audit@vger.kernel.org, linux-kernel@vger.kernel.org,
Babanpreet Singh <bbnpreetsingh@gmail.com>,
syzbot+39b8fea0641107a1ccee@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] audit: annotate the lockless read of the audit control lock owner
Date: Tue, 03 Nov 2026 18:59:07 -0500 [thread overview]
Message-ID: <e43dbe68bfabfbaa2984ea5d923c6149@paul-moore.com> (raw)
In-Reply-To: <20261008034403.7-1-bbnpreetsingh@gmail.com>
On Oct 7, 2026 Babanpreet Singh <bbnpreetsingh@gmail.com> wrote:
>
> audit_ctl_owner_current() reads the lock owner without taking the lock
> and KCSAN complains about it. Only the current task can store itself as
> owner, so the check can't give a wrong answer. Mark the accesses with
> READ_ONCE() and WRITE_ONCE().
>
> Reported-by: syzbot+39b8fea0641107a1ccee@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=39b8fea0641107a1ccee
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Babanpreet Singh <bbnpreetsingh@gmail.com>
> Reviewed-by: Bradley Morgan <brads@mainlining.org>
> Tested-by: Bradley Morgan <brads@mainlining.org> # Power10
> ---
> v2: drop the comment in audit_ctl_owner_current(). The KCSAN build of
> audit.o disassembles the same as v1.
> v1: https://lore.kernel.org/all/20261002011712.7-1-bbnpreetsingh@gmail.com/
> Compile tested only (gcc W=1 and the KCSAN instrumentation diff); I
> could not reproduce the race in QEMU.
>
> kernel/audit.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Merged into audit/dev, thanks!
--
paul-moore.com
prev parent reply other threads:[~2026-11-03 23:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 1:17 [PATCH] " Babanpreet Singh
2026-10-02 14:44 ` Paul Moore
2026-10-08 3:44 ` [PATCH v2] " Babanpreet Singh
2026-10-08 15:03 ` Bradley Morgan
2026-10-30 3:33 ` Babanpreet Singh
2026-11-03 23:59 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e43dbe68bfabfbaa2984ea5d923c6149@paul-moore.com \
--to=paul@paul-moore.com \
--cc=audit@vger.kernel.org \
--cc=bbnpreetsingh@gmail.com \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+39b8fea0641107a1ccee@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®