From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: "H. Nikolaus Schaller" <hns@goldelico.com>,
PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
letux-kernel@openphoenux.org, kbuild test robot <lkp@intel.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
malat@debian.org, paul@crapouillou.net
Subject: Re: [PATCH] nvmem: jz4780-efuse: fix build warnings on ARCH=x86_64 or riscv
Date: Mon, 9 Mar 2020 13:52:49 +0000 [thread overview]
Message-ID: <e444754a-3bd3-d46f-d2f9-188fb2cc6f0e@linaro.org> (raw)
In-Reply-To: <79e1dec195d287001515600b1dae0bcaa33fbf65.1583522277.git.hns@goldelico.com>
On 06/03/2020 19:17, H. Nikolaus Schaller wrote:
> kbuild-robot did find a type error in the min(a, b)
> function used by this driver if built for x86_64 or riscv.
>
> Althought it is very unlikely that this driver is built
> for those platforms it could be used as a template
> for something else and therefore should be correct.
>
> The problem is that we implicitly cast a size_t to
> unsigned int inside the implementation of the min() function.
>
> Since size_t may differ on different compilers and
> plaforms there may be warnings or not.
>
> So let's use only size_t variables on all platforms.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Cc: srinivas.kandagatla@linaro.org
> Cc: prasannatsmkumar@gmail.com
> Cc: malat@debian.org
> Cc: paul@crapouillou.net
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
> drivers/nvmem/jz4780-efuse.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Applied thanks,
srini
prev parent reply other threads:[~2020-03-09 13:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 19:17 H. Nikolaus Schaller
2020-03-09 13:52 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e444754a-3bd3-d46f-d2f9-188fb2cc6f0e@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=aou@eecs.berkeley.edu \
--cc=hns@goldelico.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=malat@debian.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paul@crapouillou.net \
--cc=prasannatsmkumar@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®