From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f180.google.com (mail-il1-f180.google.com [209.85.166.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91C0E1CB338 for ; Thu, 10 Oct 2024 15:08:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728572940; cv=none; b=ra6mmXK/6wBKHimuBwMksTXg53UKxEWqu/VzoC/vIX3V2dCli2/Tc46g7DnuojgTkKXyiaPG98E/QdC4LXWse4cpSAb0PBeIP9uiGKXoVmd6s49MBlDcDIw2juoY96/7TJ+OFiJ2pRCmajjX3pyQKb68Q28HQvx+L+VWqdRNZlo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728572940; c=relaxed/simple; bh=re8B3h/H8vFcHw1pRsstqY/4kJcouThAZOKm6C5wvDY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O1fyzvwohBXQaiOPTMxYvHoiTROqyHAVZLcG+2NaXQyDzRRjlG2NZewJDeQQRfZyHBRhEG3K1Q1nEBd3ObDFk+Y+JtneHuQCKkcjCSsCfDIj6T39nLwEEgcUKFOoniVGTgMx3eddYJt2W9ZBweuL93mnh2tUwhC66MqAAjWwFds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Ux03A54M; arc=none smtp.client-ip=209.85.166.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Ux03A54M" Received: by mail-il1-f180.google.com with SMTP id e9e14a558f8ab-3a3b450320aso1050905ab.3 for ; Thu, 10 Oct 2024 08:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1728572937; x=1729177737; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1OeAK/S0DDD0sB2cslV1aKUTfEhLWliOpkHnue8Kakw=; b=Ux03A54MufDQlntI2F9Rdo9s/4tWYJATjI6Tw9wNtxzwy4BALWMusSNp59FvUpnBLQ 2X0kHv6ZWVCFxEfioDg55gbA1+WA/+6F9l0PjY252HLB5eTeMRBwZFtqeHFqmji/O9Mg PCg0QmFRZ5VAoXXm9vnSWzxBkbzzKsKwHurTs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728572937; x=1729177737; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1OeAK/S0DDD0sB2cslV1aKUTfEhLWliOpkHnue8Kakw=; b=mY60kbWpCfdZSHMZMB31ZAMPrmY3ZtdUQdjfaBy6YNTceVyptSxees53tHByOtMVo0 ZvsOCk+aXWmzyTbPcKlRFpD+qt5fdw5SwcHWygU2AAh5jbuRJXfBahr2jd5+aoPsC/lk /HWf/4rvewwML2Ua59qSRDTxQ+w3/hUAjsuO4mxyWCQmYKz3gFm2KuekrRpiYIWuYoFN Hmo7RT+RwXVlEXvs5MN6RYR1pmy8/iM7I3oIfFOeh+YFYoV7G3NfgFNCr4QP+j3viQ+t d6oioUqiXBSyGGEx1gN5+koigff073zumj/hujn+zL60hte8MXAeivzcWmxYwyszIU1Z 3RGg== X-Forwarded-Encrypted: i=1; AJvYcCUyDwTJMRfWIJ2IOSCfnpJVr+orCP2HchY/q1FB/0zDwxGcHzOKNduxf+GpX58HdIUUTWqM8jf5NyXkajw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6jWcuar4ACc1YyyY4n0tRAzZPQ5oHh5NO10RQ7vWc5mTihQeS qoTAalEKx2JXXCKA5rOEX4ougIOLAf9d9vSvnJhlbpXyCVEttFGLV0EgDZDDO9A= X-Google-Smtp-Source: AGHT+IF/YFch+FuI6hF1QYufR1Nw3E8maa4x6ZomIfSTsL5GK4U6VyY878xnwVPnu1VbxY9IMgvlNQ== X-Received: by 2002:a05:6e02:1445:b0:3a0:985b:ddb4 with SMTP id e9e14a558f8ab-3a397cd8b87mr55731195ab.2.1728572936492; Thu, 10 Oct 2024 08:08:56 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3a3afdb3444sm3040575ab.34.2024.10.10.08.08.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Oct 2024 08:08:55 -0700 (PDT) Message-ID: Date: Thu, 10 Oct 2024 09:08:54 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH-next V2] ASoC: rt721-sdca: Clean logically deadcode in rt721-sdca.c To: "Everest K.C." , oder_chiou@realtek.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Shuah Khan References: <20241008234422.5274-1-everestkc@everestkc.com.np> Content-Language: en-US From: Shuah Khan In-Reply-To: <20241008234422.5274-1-everestkc@everestkc.com.np> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/8/24 17:44, Everest K.C. wrote: > As the same condition was checked in inner and outer if > statements. The code never reaches the inner else statement. > > This issue was reported by Coverity Scan with CID = 1600271. > > Signed-off-by: Everest K.C. > --- > V1 -> V2: - Updated the patch prefix to PATCH-next > - Added how the issue was discovered > > sound/soc/codecs/rt721-sdca.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/sound/soc/codecs/rt721-sdca.c b/sound/soc/codecs/rt721-sdca.c > index 36056cb7a3ca..4fd26e490610 100644 > --- a/sound/soc/codecs/rt721-sdca.c > +++ b/sound/soc/codecs/rt721-sdca.c > @@ -611,13 +611,9 @@ static int rt721_sdca_dmic_set_gain_get(struct snd_kcontrol *kcontrol, > > if (!adc_vol_flag) /* boost gain */ > ctl = regvalue / boost_step; > - else { /* ADC gain */ > - if (adc_vol_flag) > - ctl = p->max - (((vol_max - regvalue) & 0xffff) / interval_offset); > - else > - ctl = p->max - (((0 - regvalue) & 0xffff) / interval_offset); > - } > - > + else /* ADC gain */ > + ctl = p->max - (((vol_max - regvalue) & 0xffff) / interval_offset); > + > ucontrol->value.integer.value[i] = ctl; > } > Reviewed-by: Shuah Khan As mentioned in my review for v1 of this patch, the exact same problem exists in sound/soc/codecs/rt722-sdca.c as well, in case you want to send patch to fix that one. thanks, -- Shuah