From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7955D1E260C for ; Mon, 29 Jun 2026 03:48:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782704935; cv=none; b=TkMo81envk7aVWaeFBshx6NuxJEjC+EUcVmAN4x0r3IygEYHbZ7kCRdPBSD8mv/liVwEarHwPd3Dwb0fmpUUU4fbZlWZWGEcowrolZi/OAGVusROYmj3XLdc7I7y+GvXesqDWUlFR8wa9inphVt0ur21kveNgf2UP7tJtrLpQxo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782704935; c=relaxed/simple; bh=zPspuBjg3KJXURc+0x1BbdbhRTQR036NZIrYAprXl3g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZQ5cuVH9AWPYWiEjXkOJH45FANrv7b22rJCvQVnXlsh1d9kmpA/+Rvp2llui6lhL/mhgR3sBS0hjDkCO9U+m/1DuUnVXNRs4M339O11vCNGYouXL57e8nWH7i0vocRqsa9XKf+rXY09apEZ5YASfjxmhNqiNOqszT3Vcj8767K0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YuhIyoFN; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YuhIyoFN" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-8478fe07f65so53356b3a.0 for ; Sun, 28 Jun 2026 20:48:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782704934; x=1783309734; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zYaJLO7rVJIlOh5//OZ2QMbg6ndszMv9dZxRzh/XAcg=; b=YuhIyoFNHXSK9nN/FAh86XmrvqULqAlvOBIGY8KJFSQ7mkw0gHiMJnFLoho8/CJ6RF 9whKkv2SJbMCQOxEVCrvNrGqgUDFj4foE62tZl/6SR8hhLE/z0Z1tOzNqF1yXXJlDdHR dJc5LaD5kLYJS5TWpmXGNzD15sJ7QU0AdI0m2JTXHYcJfRMrFlQDGtu9jT4syLH6WP0A Wmvn81U0NVffseBHzwx7o/oQyo9YaG4wgieD6Ww2EB0oyaIqWi9I+UJk3CqC9l9p1c5S 5BZT3TrDVvOZwDT3IH09TJEfxuZWjfinZk0nXMHbkR8r7ANJhmoQWzbdnEfxBjitMAhW Xdwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782704934; x=1783309734; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zYaJLO7rVJIlOh5//OZ2QMbg6ndszMv9dZxRzh/XAcg=; b=W209msWHf7lwcS2DX9BBylG02E0BLCPGoN6wuzq6BVL5h6N43HWH0WctlgdmCAm2D2 hhK7rfYf0+Yshx01fGT0+QASkQopFW9bgq5u2lualn/+/lf0kEEkUM5e6I8IFKGHqk6b /L7vIEzYBlODCSuaYkkZL/vPnnNhcheYm+EXTQGIPk7quW3OxF/MhnuS26wlQzw1hvyb gv6EzsC2NZ1RtKxKxdKdn70QXKdQWNUl+wvBmZVUQmkGPzsfcloHgGmDXjV8KEW5wyro 8kCxvHGBVGzTe6VX74wQWUzkbFmUwoKW7/FmR94fJHFATbs0eoMoUHgaljn9vdwgFBnP 677g== X-Forwarded-Encrypted: i=1; AHgh+RpoRBaseBHWkzGox8b5KQ+M7k2B9ken2WSyCWctBQsg5YdOrhhkKD7JmhkfVTFsK11RE34nuktEcXnn2m8=@vger.kernel.org X-Gm-Message-State: AOJu0YywbBf8rtotUR57DeqjSNT6TmXnAnBuJHMj81vBrq3Xa6aN00SP IkLydfy8r1UgS55kf9Wr7VfCYoGlrfCp1JvCnljwbTFkZDWuaL4goNiF X-Gm-Gg: AfdE7cl6KHoqY8WFl3CYVm7EY4q6jMnQqyCZqrs20TxEZqUh9tDCmH3xaId7fPcQ2G0 6UF+Ru03BeQNof6LpKxMz2R0LnLkChpK4znld7qSmf8MT0UDg8Cbcs5fvRDo2+pKt984SdJdy2t aDqPeVnaNRfN5jbL/l6gfJkZwTmH4GESvfSd2heKUIInmWFcTVhZnmZV+VweFdE/SCnKtyd4VLF R+3p0CnKMwwcoSyVpeof+9ruPfSLxzNPqAOUyzZBLiDlyg+Lf8P5XWkKTpefsdam2nYlZC1XEZ1 htEkop8lsBoQjX/UyVtGE150sj2jiUk1waqHGT0bz2kAA0nkOYYApp+N1O35SFh4GqDHN4pwDpU BwQZXOOusO5Rkgz8AuTOSJkXoDui/PosTi2sJKR4My8LSntjeuRLtCdYYe2N7IDkutnkHHCjhMU pL18oP2a1VkBMvHTIIHkqvNd7wpfQuxO9hFakUIQMJ8zJUFzcNXiEQn6vslFrVN+bO/KMzu6mz8 eX3 X-Received: by 2002:a05:6a00:238b:b0:845:e19a:1188 with SMTP id d2e1a72fcca58-845e19a1487mr4616768b3a.52.1782704933611; Sun, 28 Jun 2026 20:48:53 -0700 (PDT) Received: from [192.168.0.100] (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-845a3fedaefsm11603061b3a.23.2026.06.28.20.48.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Jun 2026 20:48:53 -0700 (PDT) Message-ID: Date: Mon, 29 Jun 2026 11:48:49 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 4/7] drm/verisilicon: make axi and ahb clocks optional To: Icenowy Zheng , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260625094449.708386-1-a0987203069@gmail.com> <20260625094449.708386-5-a0987203069@gmail.com> Content-Language: en-US From: Joey Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6/26/2026 4:03 PM, Icenowy Zheng wrote: > 在 2026-06-25四的 17:44 +0800，Joey Lu写道： >> The Nuvoton MA35D1 SoC integrates a DCUltraLite display controller >> whose >> AXI and AHB bus clocks share a single gate enable bit with the >> display >> core clock, so the clock driver does not expose them separately. This >> patch makes the axi and ahb clocks optional in the probe. >> >> Signed-off-by: Joey Lu > ``` > Reviewed-by: Icenowy Zheng > ``` > > Thanks, > Icenowy Thank you for the review. I will revert this patch entirely. As discussed in the binding review, axi and ahb clocks will now always be supplied in the devicetree using the same phandle as the core clock gate, so making them optional in the driver is no longer needed. >> --- >>  drivers/gpu/drm/verisilicon/vs_dc.c | 4 ++-- >>  1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/verisilicon/vs_dc.c >> b/drivers/gpu/drm/verisilicon/vs_dc.c >> index 9729b693d360..fd1f5fe67a68 100644 >> --- a/drivers/gpu/drm/verisilicon/vs_dc.c >> +++ b/drivers/gpu/drm/verisilicon/vs_dc.c >> @@ -90,13 +90,13 @@ static int vs_dc_probe(struct platform_device >> *pdev) >>   return PTR_ERR(dc->core_clk); >>   } >> >> - dc->axi_clk = devm_clk_get_enabled(dev, "axi"); >> + dc->axi_clk = devm_clk_get_optional_enabled(dev, "axi"); >>   if (IS_ERR(dc->axi_clk)) { >>   dev_err(dev, "can't get axi clock\n"); >>   return PTR_ERR(dc->axi_clk); >>   } >> >> - dc->ahb_clk = devm_clk_get_enabled(dev, "ahb"); >> + dc->ahb_clk = devm_clk_get_optional_enabled(dev, "ahb"); >>   if (IS_ERR(dc->ahb_clk)) { >>   dev_err(dev, "can't get ahb clock\n"); >>   return PTR_ERR(dc->ahb_clk);