From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65068C4167D for ; Sat, 28 Oct 2023 19:13:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229736AbjJ1TNd (ORCPT ); Sat, 28 Oct 2023 15:13:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjJ1TNb (ORCPT ); Sat, 28 Oct 2023 15:13:31 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4879DED for ; Sat, 28 Oct 2023 12:13:29 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-32db188e254so2134292f8f.0 for ; Sat, 28 Oct 2023 12:13:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698520407; x=1699125207; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0d8Wu7cwT3csb9Kn7sSs3Xz1T1ix90/Cucuh7IBJjS8=; b=XUAfPKNMJO4kaCk7yN7E91Nv0gDzuv/1FX7xrCLDyIXKR4Wk+8Lb6ExF5v0hed27ZG +QROg/KjZH5QNwQxoaey0+vAspF+ukvGNxdYogoiNIrj4bNWJZ1b7UbunTh7hwYg9izY VZ5ByEXgUXrwWdymz8KBl/k3VbKsX4lddF9GVWKJyajA80loHkZ0SqA70IwyMJJSmJLh qT7QPeHS+zu+XLqUHE2nGBPOXHjOf3SEPfBn5heJKm7z5VlGNaYHcQtux35pz2qV4KgH jeeLyOinlDRTq8/j8Xwo2HH2/wd+GPsymqBI7RspKyqqr6sqlYGw0hql3D3KbqlraPD3 F2fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698520408; x=1699125208; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0d8Wu7cwT3csb9Kn7sSs3Xz1T1ix90/Cucuh7IBJjS8=; b=u7dJJxE9wdNPw9GlxCwQ5K33dQrGOSiOoH4h2CHxjRs1uhUWFuM/PGWrjlTiIpntLW KfYj4a71p/99xcg0eLq03Eli4E/vCQcUchhU6pKtq6GMyMY/j+hALcRjsRPtJLqZM3fP XaNqWCwESxwck2JhyqemFwsdgzS3HHrMqUWruIRM078ayt6GiQ1BRDpbE/V64QVSkNiU hZ+WeChA9ez5JK+UUkfN+vwi9PAAyX1/OWIQTbS7/52ZE8sIYUSqwxV2yyD9k/oqo4TM Szx15kSFmNJNmez5oV7f1O8yUJtfx5wVDzZbzgHxlRux8a9V1Xs8vFpYP6sst2I9WhRT kDvg== X-Gm-Message-State: AOJu0Yy6hIRWCoOS6k34x55xYN2zX6T4kpyQ0ssy8M60FWTosO507jPx 6mjkgukPCowLcDjiF5jPRshhyA== X-Google-Smtp-Source: AGHT+IHpCIG80QzJxe1Tt5Wenaj1oQLZAgeTsD8fzieQTtvn5G7qbl/80H8fku9uQwSuYidVr2RmFA== X-Received: by 2002:adf:d1e4:0:b0:32f:7c6c:aa14 with SMTP id g4-20020adfd1e4000000b0032f7c6caa14mr2016640wrd.37.1698520407675; Sat, 28 Oct 2023 12:13:27 -0700 (PDT) Received: from [192.168.100.102] ([37.228.218.3]) by smtp.gmail.com with ESMTPSA id bq22-20020a5d5a16000000b0032f7865a4c7sm2428358wrb.21.2023.10.28.12.13.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Oct 2023 12:13:27 -0700 (PDT) Message-ID: Date: Sat, 28 Oct 2023 20:13:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: qcom: gcc-msm8939: Add missing CSI2 related clocks Content-Language: en-US To: Vincent Knecht , Andy Gross , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephan Gerhold , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20231028121047.317550-1-vincent.knecht@mailoo.org> From: Bryan O'Donoghue In-Reply-To: <20231028121047.317550-1-vincent.knecht@mailoo.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/10/2023 13:10, Vincent Knecht wrote: > When adding in the indexes for this clock-controller we missed > GCC_CAMSS_CSI2_AHB_CLK, GCC_CAMSS_CSI2_CLK, GCC_CAMSS_CSI2PHY_CLK, > GCC_CAMSS_CSI2PIX_CLK and GCC_CAMSS_CSI2RDI_CLK. > > Add them in now. > > Signed-off-by: Vincent Knecht > --- > No fixes tag because camss is a not-yet-enabled feature for msm8939. > > Also didn't rename ftbl_gcc_camss_csi0_1_clk now that csi2 uses it > to avoid not-required-churn... should it be done anyway ? An aesthetic choice with no right answer but, downstream calls it ftbl_gcc_camss_csi0_1_2_clk, maybe that's reasonable. Assuming Krz's comments acted upon. Reviewed-by: Bryan O'Donoghue