From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, kan.liang@intel.com,
yao.jin@intel.com
Subject: Re: [PATCH v2 3/3] perf report: Display average IPC and IPC coverage per symbol
Date: Wed, 28 Nov 2018 09:45:59 +0800 [thread overview]
Message-ID: <e44fd7a5-07f0-5760-d1cc-a689d8d06cfa@linux.intel.com> (raw)
In-Reply-To: <20181127183302.GW13936@tassilo.jf.intel.com>
On 11/28/2018 2:33 AM, Andi Kleen wrote:
> On Tue, Nov 27, 2018 at 08:09:48PM +0800, Jin Yao wrote:
>> Support displaying the average IPC and IPC coverage for symbol
>> in perf report TUI browser. We create a new sort-key 'ipc' for
>> that.
>
> Another thing that would be nice would be to automatically enable
> these columns perf report when -b was enabled in the perf.data.
> We can't check for timed LBR being supported without
> looking into samples, but at least can check for -b.
>
> Otherwise a lot of people won't realize it's supported.
>
> It would show always 0.0 when timed LBR is not supported,
> but that might be ok. Perhaps make both columns empty
> in this case instead of 0.0.
>
>
> -Andi
>
Hi Andi,
Yes, I agree, people will not realize a new option 'ipc' is created.
So I will enable 2 columns ("IPC" and "IPC columns") even when timed LBR
is not supported. Just show empty or '-' in these columns.
Thanks
Jin Yao
prev parent reply other threads:[~2018-11-28 1:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 12:09 [PATCH v2 0/3] perf report/annotate: Support average IPC and IPC coverage for function Jin Yao
2018-11-27 12:09 ` [PATCH v2 1/3] perf annotate: Compute average IPC and IPC coverage per symbol Jin Yao
2018-11-27 12:09 ` [PATCH v2 2/3] perf annotate: Create a annotate2 flag in struct symbol Jin Yao
2018-11-27 12:09 ` [PATCH v2 3/3] perf report: Display average IPC and IPC coverage per symbol Jin Yao
2018-11-27 18:33 ` Andi Kleen
2018-11-28 1:45 ` Jin, Yao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e44fd7a5-07f0-5760-d1cc-a689d8d06cfa@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®