From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B1DE2EBB8C for ; Tue, 3 Feb 2026 11:15:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770117360; cv=none; b=sCjSjXzzNTpO8HmlyzSgJ/JOUGyUk/n0QqnsNO4VoDSVU71GhkUomgvqJW+w4uruk3BDeEn1n3/toWbZbczXuKZuvx+7p3F/QV7kv88zh2HRiRWkUo/ef/TrHOls5JfITU1nL+lroy6jJT3zGl8l7OtGEsgG3Bem61CQaL+hzWU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770117360; c=relaxed/simple; bh=0ZR2oU8IP2eDsC+s+TYPfsq/S81Cxv5wEpDIhQB7pZU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sbdf3i9UfhcnBmEnWxnLx0CMGv0SENMoOIKuo4r/mjIPnnWEBbveXE8Q02Eo/SqP6UPUWqe842PB/LTI3a0f3lz0PHTetdJfTKq1M1gIqbu/i9Q+oikARnoqvTBzh9g07qV5nXA3RryFu6OUHVtPkDO05phcSsu4hic9j3TjeJM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=n6N/6NKM; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n6N/6NKM" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4806ce0f97bso46696785e9.0 for ; Tue, 03 Feb 2026 03:15:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770117357; x=1770722157; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VrhNkAcR4O9t+aOkubVrk5pFhzyBj02L09FZbkYaGZk=; b=n6N/6NKMwtqjwVM3Gq2lGIAFGjIiriYd/RWZN5/eIzeDQuyTwmJ3wAJjUEqn7PEaq3 BGFawoc8RSQQpwzkCX7HEBFqDq8AwjrTAi3JLTQLEkRtzBqRAvb3UxkgOfMe2mh4hoOL ZsHz9P0HR3rfVmRMhqj3o0yFtXyxSBToLfW3B5tAYcBEYt8Nfss/Q6sW3oc6YpSsvo4t Y0L1ZImxikF52SwrFrpJII8+20GgGnMdyACU2MOAu19WEiL+2q40a35v/IIYfY3oc/aa 3xS6iVXrSQfD6m6G4gwtlHjLhZVLW85NF2eAOk2wJQJKRhi7vxTT8lH3W04uUvMblYxv /byg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770117357; x=1770722157; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VrhNkAcR4O9t+aOkubVrk5pFhzyBj02L09FZbkYaGZk=; b=kYmCl2u7jqvLrRlUTXCjA/Rfmgn2GTWx5jeMDQKgl15KptfF0yQCZeVQvIhSNk12d8 dThElVO9U1fxgLFy/sKBR3Bw/nkWH3jE5GlH71BfO6FIlPfh+QmRE/z9ZyUqfsjIrTsS YW0ZLzRL1YYlNqDZ7m0kzVnZbgZ/6RMC+tRViZjdo71LRfnv2utMXTWY3Kaq4L8lEnht eMYigtxnoMOvGfK3Y7uiKNA7hzefj4+fIlraCUXOflk42mM+cXs70zhcyto0aDgL0s+P QD/u70wewu+BLER0hGyim/XK1liA1YttOnMw7cVW0cQ5x3oOps/D3TqZ1/YBnZtHAyu9 E7hA== X-Forwarded-Encrypted: i=1; AJvYcCUlmtFtJMUG3drmwj1QzBosbixsfPxsvoVrbGj1EGlJ1swU6EdkDSHNfDgKAW0zoFhXBA3K3cEG/xtF/8Q=@vger.kernel.org X-Gm-Message-State: AOJu0YyAnYhO8xnUAftgwvmZP13E7MOeOVFA6AAjOqtidcI+ZMUtNxSF LOLl3jSI+cIw9VknEez8GuKM6KT4DNHjP3MgdL4D8DC3JOpXsYDdEack+lkBrHtwtHANW2C7zQS d0PUg X-Gm-Gg: AZuq6aI2QXKF6aMoG/SPtA3QNm2pERBUhDolC4Y/DskQ0Oshn11+MSvdBVTjon2Hpon xxqqiB/6Kf/cOGS/UY/LmSkCWGFcGn+zfhTZxV0LITElisV16ySFU8vXQix5EYHoQ5IqKGc8gaD 6+kKTbG4hY2sO6SP6BrOaOeU69bAav5eR/mueWpmSWcM7FlB+hkbXJxnv3h0UjstSWFqiIjJBO5 ukDd2t/F5lGGilWUMfEIIr0pLYCzciM07VhTS7VDT9qiJoMvm0iGbl4mRGXnlNsBaoDQnusg+te SnzSneLC9vWArirejKHy1ppUCmAsWtC2qJG9490FzS8ILub+Z8SKx8hldMTumm8uHoKgJcNjZyj wvVcncOmcSbBAHh8bDwRt7T+exMi8KvWQnwHW+8w3r9R7jdIJwG4WRzMDykuptHq5Vwx1WwKEmY 6aicx1zoFKYOtshx0b X-Received: by 2002:a05:600c:1d8c:b0:47b:deb9:15fb with SMTP id 5b1f17b1804b1-482db4970e2mr191238095e9.33.1770117356881; Tue, 03 Feb 2026 03:15:56 -0800 (PST) Received: from [192.168.1.3] ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482e2e3bf18sm121781685e9.19.2026.02.03.03.15.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Feb 2026 03:15:56 -0800 (PST) Message-ID: Date: Tue, 3 Feb 2026 11:15:55 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 8/8] coresight: Unify error handling in coresight_register() To: Leo Yan Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Suzuki K Poulose , Mike Leach , Alexander Shishkin , Greg Kroah-Hartman , Mathieu Poirier , Mao Jinlong References: <20260202-arm_coresight_refactor_dev_register-v3-0-03292470c48c@arm.com> <20260202-arm_coresight_refactor_dev_register-v3-8-03292470c48c@arm.com> Content-Language: en-US From: James Clark In-Reply-To: <20260202-arm_coresight_refactor_dev_register-v3-8-03292470c48c@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02/02/2026 9:34 am, Leo Yan wrote: > Unify error handling during registration: > > 1) Failures before device registration are handled by err_out, which > releases platform data. > > 2) Jump to the out_unlock label on failures after device registration > to unwind the flow via coresight_unregister(). > > The "registered" variable is no longer used, remove it. > > Signed-off-by: Leo Yan > --- > drivers/hwtracing/coresight/coresight-core.c | 17 +++++------------ > 1 file changed, 5 insertions(+), 12 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c > index 955af43010446803030973c72f07315492b2fcf3..65cf975493c86de42515845147d90497aa20c595 100644 > --- a/drivers/hwtracing/coresight/coresight-core.c > +++ b/drivers/hwtracing/coresight/coresight-core.c > @@ -1326,7 +1326,6 @@ struct coresight_device *coresight_register(struct coresight_desc *desc) > { > int ret; > struct coresight_device *csdev; > - bool registered = false; > > csdev = kzalloc(sizeof(*csdev), GFP_KERNEL); > if (!csdev) { > @@ -1380,7 +1379,8 @@ struct coresight_device *coresight_register(struct coresight_desc *desc) > * All resources are free'd explicitly via > * coresight_device_release(), triggered from put_device(). > */ > - goto out_unlock; > + mutex_unlock(&coresight_mutex); > + goto err_out; I'm not sure if replacing the "registered" system with extra calls to unlock is necessarily better. I think the whole point of out_unlock was to have a single call to unlock so it couldn't be forgotten or didn't need to be duplicated. Probably a better way to clean this up would be to pull out a function for all the stuff that needs to be locked and use guard(). Then do the stuff that doesn't need to be locked after that function. Either way it doesn't look wrong. > } > > ret = etm_perf_add_symlink_sink(csdev); > @@ -1390,12 +1390,8 @@ struct coresight_device *coresight_register(struct coresight_desc *desc) > * coresight_device_release() triggered from put_device(), which is in > * turn called from function device_unregister(). > */ > - if (ret && ret != -EOPNOTSUPP) { > - device_unregister(&csdev->dev); > + if (ret && ret != -EOPNOTSUPP) > goto out_unlock; > - } > - /* Device is now registered */ > - registered = true; > > ret = coresight_create_conns_sysfs_group(csdev); > if (ret) > @@ -1415,11 +1411,8 @@ struct coresight_device *coresight_register(struct coresight_desc *desc) > out_unlock: > mutex_unlock(&coresight_mutex); > > - /* Unregister the device if needed */ > - if (registered) { > - coresight_unregister(csdev); > - return ERR_PTR(ret); > - } > + coresight_unregister(csdev); > + return ERR_PTR(ret); > > err_out: > coresight_release_platform_data(desc->dev, desc->pdata); >