From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54AD7C432C3 for ; Thu, 14 Nov 2019 08:08:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3411520724 for ; Thu, 14 Nov 2019 08:08:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="jz3+gAJ3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726190AbfKNII5 (ORCPT ); Thu, 14 Nov 2019 03:08:57 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:59376 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725838AbfKNII5 (ORCPT ); Thu, 14 Nov 2019 03:08:57 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id xAE88TAI087495; Thu, 14 Nov 2019 02:08:29 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1573718909; bh=39b7nZ1qRF2Y+FLYhjNIYsRZV7qmctGWElYWFg7WX+c=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=jz3+gAJ3tZEIyJcZzYoDt3ibitF3wiUAMwOW2S5lRPPY58xnjxyQg4oFQkUEHkTUk 3TUmRmXZAr4W+u8/Rwj3JafK+izUYxskI6nlAaLVuwLwSdjSJQZdhhMgEEaqdda8nJ iO4BKurruUwtjfW9CuZlD+vuGD4UGU9pZ6l3e74k= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id xAE88SDs112761; Thu, 14 Nov 2019 02:08:28 -0600 Received: from DFLE101.ent.ti.com (10.64.6.22) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Thu, 14 Nov 2019 02:08:22 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Thu, 14 Nov 2019 02:08:22 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id xAE88H8G125696; Thu, 14 Nov 2019 02:08:17 -0600 Subject: Re: [PATCH 7/9] spi: s3c64xx: Use dma_request_chan() directly for channel request To: Andi Shyti CC: , , , , , , , , , , , , , , , , , , References: <20191113094256.1108-1-peter.ujfalusi@ti.com> <20191113094256.1108-8-peter.ujfalusi@ti.com> <20191113234049.GA1249@jack.zhora.eu> From: Peter Ujfalusi Message-ID: Date: Thu, 14 Nov 2019 10:09:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191113234049.GA1249@jack.zhora.eu> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/11/2019 1.40, Andi Shyti wrote: > Hi Peter, > >> if (!is_polling(sdd)) { >> /* Acquire DMA channels */ >> - sdd->rx_dma.ch = dma_request_slave_channel_reason(&pdev->dev, >> - "rx"); >> + sdd->rx_dma.ch = dma_request_chan(&pdev->dev, "rx"); > > I have a little concern here. We have two funcions > 'dma_request_chan' and 'dma_request_channel' don't we end up > making some confusion here? > > Wouldn't it make more sense renaming 'dma_request_chan' to > 'dma_request_slave_channel_reason'? The dma_request_channel() should go away. It was the old API before we got the dma_slave_map for non DT (and non ACPI) platforms so we can get rid of the filter function exports from DMA drivers to clients all over the place. I know there are users where they provide dummy filter function. At the end the main API to request slave DMA channel should be dma_request_chan() For non slave channels (not HW triggered) we have dma_request_chan_by_mask() Imoh the dma_request_slave_channel_compat() should also go away with time. > > Thanks, > Andi > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki