From: Markus Elfring <Markus.Elfring@web.de>
To: "Heiko Stübner" <heiko@sntech.de>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Aditya Pakki <pakki001@umn.edu>,
Kangjie Lu <kjlu@umn.edu>, Navid Emamdoost <emamd001@umn.edu>,
Stephen McCamant <smccaman@umn.edu>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: clk: rockchip: Checking a kmemdup() call in rockchip_clk_register_pll()
Date: Wed, 16 Oct 2019 08:24:10 +0200 [thread overview]
Message-ID: <e4540cb0-7fcc-ce1e-f687-c725f5e8b209@web.de> (raw)
In-Reply-To: <5173392.uhhkXBHGmO@phil>
>> Would you like to adjust such exception handling another bit?
>
> Nope.
>
> The big difference is that clocks rely heavily on their names to establish
> the clock tree parentship. So the PLL cannot work without the name
This error situation got a specific reaction.
> but can provide some means of functionality without the rate-table
> especially as bootloaders do generally initialize a PLL to some form of
> sane frequency.
I imagine that a choice is available here for the error handling strategy.
* Return “ERR_PTR(-ENOMEM)” as a strict response like in the other error case.
* Fix the setting “pll->rate_count” at least (to be a bit more tolerant).
Would any system users wonder then about the availability of only
a single frequency (instead of possibly expected alternatives)?
Regards,
Markus
prev parent reply other threads:[~2019-10-16 6:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 13:55 Markus Elfring
2019-10-12 21:32 ` Heiko Stübner
2019-10-13 8:45 ` Markus Elfring
2019-10-13 21:49 ` Heiko Stuebner
2019-10-14 7:26 ` Markus Elfring
2019-10-15 20:29 ` Heiko Stuebner
2019-10-16 6:24 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4540cb0-7fcc-ce1e-f687-c725f5e8b209@web.de \
--to=markus.elfring@web.de \
--cc=emamd001@umn.edu \
--cc=heiko@sntech.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=pakki001@umn.edu \
--cc=sboyd@kernel.org \
--cc=smccaman@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®