From: Muhammad Usama Anjum <Usama.Anjum@collabora.com>
To: liuye <liuye@kylinos.cn>, shuah@kernel.org
Cc: Usama.Anjum@collabora.com, amer.shanawany@gmail.com,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/capabilities/test_execve: Initialize the variable have_outer_privilege
Date: Mon, 20 Jan 2025 12:31:22 +0500 [thread overview]
Message-ID: <e4549965-bb0c-4b46-b796-265704290e42@collabora.com> (raw)
In-Reply-To: <20250114054129.73331-1-liuye@kylinos.cn>
On 1/14/25 10:41 AM, liuye wrote:
> Uninitialized variable: have_outer_privilege.
> Fix it.
Please improve the description. Explain how the current code
is wrong. After that add:
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>
> Signed-off-by: liuye <liuye@kylinos.cn>
> ---
> tools/testing/selftests/capabilities/test_execve.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/capabilities/test_execve.c b/tools/testing/selftests/capabilities/test_execve.c
> index 47bad7ddc5bc..c9617b38d6f7 100644
> --- a/tools/testing/selftests/capabilities/test_execve.c
> +++ b/tools/testing/selftests/capabilities/test_execve.c
> @@ -83,7 +83,7 @@ static bool create_and_enter_ns(uid_t inner_uid)
> uid_t outer_uid;
> gid_t outer_gid;
> int i, ret;
> - bool have_outer_privilege;
> + bool have_outer_privilege = false;
>
> outer_uid = getuid();
> outer_gid = getgid();
--
BR,
Muhammad Usama Anjum
prev parent reply other threads:[~2025-01-20 7:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 5:41 liuye
2025-01-20 7:31 ` Muhammad Usama Anjum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4549965-bb0c-4b46-b796-265704290e42@collabora.com \
--to=usama.anjum@collabora.com \
--cc=amer.shanawany@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuye@kylinos.cn \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®