From: Markus Elfring <Markus.Elfring@web.de>
To: sparclinux@vger.kernel.org, kernel-janitors@vger.kernel.org,
Andreas Larsson <andreas@gaisler.com>,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh@kernel.org>, Sam Ravnborg <sam@ravnborg.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] sparc: leon: grpci1: Use devm_platform_ioremap_resource() in grpci1_of_probe()
Date: Tue, 6 Feb 2024 16:40:24 +0100 [thread overview]
Message-ID: <e4585b03-3629-4bd7-a349-f5471ebd8685@web.de> (raw)
In-Reply-To: <4fc017e4-c695-40d3-aed4-cbf34d44e6fa@web.de>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 6 Feb 2024 16:30:15 +0100
A wrapper function is available since the commit 7945f929f1a77a1c8887a97ca07f87626858ff42
("drivers: provide devm_platform_ioremap_resource()").
* Thus reuse existing functionality instead of keeping duplicate source code.
* Delete a local variable which became unnecessary with this refactoring.
This issue was transformed by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
v2:
The transformation pattern was adjusted based on advices by known contributors.
Examples:
* Doug Anderson
* Geert Uytterhoeven
* Robin Murphy
arch/sparc/kernel/leon_pci_grpci1.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/sparc/kernel/leon_pci_grpci1.c b/arch/sparc/kernel/leon_pci_grpci1.c
index 8700a0e3b0df..a01ecee18e1e 100644
--- a/arch/sparc/kernel/leon_pci_grpci1.c
+++ b/arch/sparc/kernel/leon_pci_grpci1.c
@@ -516,7 +516,6 @@ static int grpci1_of_probe(struct platform_device *ofdev)
int err, len;
const int *tmp;
u32 cfg, size, err_mask;
- struct resource *res;
if (grpci1priv) {
dev_err(&ofdev->dev, "only one GRPCI1 supported\n");
@@ -537,8 +536,7 @@ static int grpci1_of_probe(struct platform_device *ofdev)
priv->dev = &ofdev->dev;
/* find device register base address */
- res = platform_get_resource(ofdev, IORESOURCE_MEM, 0);
- regs = devm_ioremap_resource(&ofdev->dev, res);
+ regs = devm_platform_ioremap_resource(ofdev, 0);
if (IS_ERR(regs))
return PTR_ERR(regs);
--
2.43.0
next prev parent reply other threads:[~2024-02-06 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 20:36 [PATCH] sparc: leon: grpci1: Use devm_platform_get_and_ioremap_resource() " Markus Elfring
2024-02-06 15:40 ` Markus Elfring [this message]
2024-02-16 16:45 ` [PATCH v2] sparc: leon: grpci1: Use devm_platform_ioremap_resource() " Andreas Larsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4585b03-3629-4bd7-a349-f5471ebd8685@web.de \
--to=markus.elfring@web.de \
--cc=andreas@gaisler.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®