From: Michael Walle <michael@walle.cc>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Peng Fan <peng.fan@nxp.com>, Anson Huang <Anson.Huang@nxp.com>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Li Yang <leoyang.li@nxp.com>,
linux-kernel@vger.kernel.org, heiko.thiery@gmail.com
Subject: Re: [PATCH] dt-bindings: arm: fsl: add IMX8MN DDR3L eval board
Date: Wed, 23 Feb 2022 13:22:37 +0100 [thread overview]
Message-ID: <e45e6fd29b5c91e1413247aa50d6d809@walle.cc> (raw)
In-Reply-To: <96f7a28b-81b9-a05f-e8f5-a4fb377476fc@canonical.com>
Am 2022-02-23 12:32, schrieb Krzysztof Kozlowski:
> On 22/02/2022 16:13, Michael Walle wrote:
>> Add a new compatible string for that eval board. It features an IMX8MN
>> UltraLite and has DDR3L RAM. The product part number is 8MNANOD3L-EVK.
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>> Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
>> b/Documentation/devicetree/bindings/arm/fsl.yaml
>> index 23e678232451..e11ffaa8721e 100644
>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>> @@ -834,6 +834,7 @@ properties:
>> - bsh,imx8mn-bsh-smm-s2 # i.MX8MN BSH SystemMaster
>> S2
>> - bsh,imx8mn-bsh-smm-s2pro # i.MX8MN BSH SystemMaster
>> S2 PRO
>> - fsl,imx8mn-ddr4-evk # i.MX8MN DDR4 EVK Board
>> + - fsl,imx8mn-ddr3l-evk # i.MX8MN DDR3L EVK Board
>
> Looks good, just please put it in alphabetical order, so before ddr4,
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
>
> Best regards,
> Krzysztof
Thanks, I actually forgot to put Anson on CC as he has added the
other entries. Doing that now, also adding Peng Fan. Maybe they
have an opinion on the choosen name.
-michael
prev parent reply other threads:[~2022-02-23 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 15:13 Michael Walle
2022-02-22 15:16 ` Heiko Thiery
2022-02-23 11:32 ` Krzysztof Kozlowski
2022-02-23 12:22 ` Michael Walle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e45e6fd29b5c91e1413247aa50d6d809@walle.cc \
--to=michael@walle.cc \
--cc=Anson.Huang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko.thiery@gmail.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®