Re: [PATCH v2] drm/imagination: Add job type info to pvr_job_submit_fw trace event

[Alexandru Dadu <Alexandru.Dadu@imgtec.com>]

On Fri, 2026-09-18 at 09:56 +0530, Brajesh Gupta wrote:
Hello Brajesh,
> *** NOTE: This is an internal email from Imagination Technologies ***
> 
> 
> 
> 
> Update trace event pvr_job_submit_fw to additionally capture and
> display
> type of the submitted job to easily map events as per type.
> 
> Signed-off-by: Brajesh Gupta <brajesh.gupta@imgtec.com>
> Reviewed-by: Alessio Belle <alessio.belle@imgtec.com>
> ---
> Changes in v2:
> - Updated to latest drm-misc-next to resolve a conflict as pointed
> out by Alessio.
> - Link to v1:
> https://lore.kernel.org/r/20260819-b4-submitjob_tracepoint-v1-1-f817b222bf6a@imgtec.com
> ---
>  drivers/gpu/drm/imagination/pvr_trace.h | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/imagination/pvr_trace.h
> b/drivers/gpu/drm/imagination/pvr_trace.h
> index 943d6b2418cb..4be7d4b8a357 100644
> --- a/drivers/gpu/drm/imagination/pvr_trace.h
> +++ b/drivers/gpu/drm/imagination/pvr_trace.h
> @@ -90,21 +90,25 @@ TRACE_EVENT(pvr_job_create,
>                       __entry->sync_op_count)
>  );
> 
> -#undef PVR_JOB_TYPE_TO_STR
>  #undef PVR_JOB_GET_HWRT_FW_ADDR
> 
>  TRACE_EVENT(pvr_job_submit_fw,
>             TP_PROTO(struct pvr_job *job),
>             TP_ARGS(job),
>             TP_STRUCT__entry(__field(struct pvr_job *, job)
> -                            __field(u32, done_seqno)),
> +                            __field(u32, done_seqno)
> +                            __field(enum drm_pvr_job_type,
> job_type)),
>             TP_fast_assign(__entry->job = job;
> -                          __entry->done_seqno = job->done_fence-
> >seqno;),
> -           TP_printk("job=%p done_seqno=%u",
> +                          __entry->done_seqno = job->done_fence-
> >seqno;
> +                          __entry->job_type = job->type;),
> +           TP_printk("job=%p done_seqno=%u job_type=%s",
>                       __entry->job,
> -                     __entry->done_seqno)
> +                     __entry->done_seqno,
> +                     PVR_JOB_TYPE_TO_STR(__entry->job_type))
>  );
> 
> +#undef PVR_JOB_TYPE_TO_STR
> +
>  TRACE_EVENT(pvr_job_done,
>             TP_PROTO(struct pvr_job *job),
>             TP_ARGS(job),
> 
> ---
> base-commit: a8fe4e162ba8212b7e51fdb024b37800f36b496c
> change-id: 20260819-b4-submitjob_tracepoint-d374f065345e
> 
> Best regards,
> --
> Brajesh Gupta <brajesh.gupta@imgtec.com>
> 

Reviewed by: Alexandru Dadu <alexandru.dadu@imgtec.com>

Thanks,
Alexandru Dadu