From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38622295DAC for ; Thu, 7 May 2026 03:28:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778124492; cv=none; b=BP4AkwXPX2Rn10ZRMMfEWeGItEDB3lg/IJpfsCUQ6eeH2aMrB84Mi/jDnxtrygMgLUBLw7J2Q8O+veth6f/rvdBf/uPzl04vHLwSQnBYSN/Zx/VFOxVgwxtD5uQ8fUJjNzbAeDgpPk2uco/yMhFUyLpjN36fcBm/UPYGFgUs++E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778124492; c=relaxed/simple; bh=Xcj3OienWhKhCQV8lmue847Tozpcy05sx3/myZShVB8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aFbOoTkcjf/BQk4T3tVqp49SHGP5LMrDvikoBDrePP89/nWOB/XeHv1teHIjyIKi6FdqTlTV7ROFy1J7PtZYNM2NpYXWBAnhs8UtALuYr51XmBkfZFjcppOyDCXYoO9kI3wHP3W0AGvV+k078wcEeuXXv5nwrLhOhbHN0lwTXHI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=itHj9n0C; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZwggcVmY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="itHj9n0C"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZwggcVmY" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 646JuJIw3924169 for ; Thu, 7 May 2026 03:28:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Z+iK/VRqnXrENHqyoaUBW011Aa4rY5QCI7A6FztKWHU=; b=itHj9n0Cx1WI3fer 0pz8ZDyx1jTqy5wiSbwB768nFhmGVjCrsJgcDcO9eelzqZ8uRrtD1vvyYBWlzmtT tcneewSnlJKk48pf2tZ0uP/dAp3IjszhqQL0Vmp7o2d3e1AJp4ItqM7DZGoDD/yk cb/bCahhLoGa3L21QkB3MdVypwH4cwTlp1p5oofB1o6FAvxBk0nI5YuJhfEKovwK qu7tO3ds64JaTGUFrJp+pzlZJKoc9y6DbiWz/Jx1zOqNIoeRV+bAJa6TRTrvPO/a rf5YOPLWGFa0Dbc858XcSRLCoHzH0+PoA5TdQ/erS4BhQunzJ/BvVs4XiK07b6LD gX95DA== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e0c88974h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 03:28:10 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-2f485961555so1932197eec.1 for ; Wed, 06 May 2026 20:28:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778124489; x=1778729289; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Z+iK/VRqnXrENHqyoaUBW011Aa4rY5QCI7A6FztKWHU=; b=ZwggcVmYDL9Gs34S014iAeDaWsbxU5rCq2WQTTsaiKuo+eHliaEslM4AyQDytDjI9A vWRGFXhAOfhZXb3IZzwLtCxMw62fpLx6UumKk+6V6C2hqVMGOMDGUFCEZH0yUhvplHMN olWPBfW6ShaRZ2uWoD6ti5wzk1v/iqIVKWY8IT/i/OYSB6c7cCOdPBELItbA8DIn0Tui WOgAaFxmW0HDUX9usrB4NtaYcqi0ZqaaHt5iQsxQDClp6jF9AFOXrdaNGPhoKV6jDR4I uS89pyf02iAr2cvbf0JetPLsgFo9ACW5qciVSlfqOsy2FVbK8gyIRiLbrbfe+LZ3erZU DmRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778124489; x=1778729289; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z+iK/VRqnXrENHqyoaUBW011Aa4rY5QCI7A6FztKWHU=; b=WFHqrhgL756ByGFlOnJxj1Vj9FAFyfQZcdBRY9FAoqQ8zZ09C8LOUD2NsNyCutp+3e pmxA5bFkuOCg2ZDKgXtfDuWL0PP5fOy4/RBYWtS+ggy7LsalOBp22YM5nBh1R5zPoX5k RplXxu4Mo/yRrYlvJtvq72NVsQPmxM5XM2/NCla6jZxLuMCOOb6ACMpmZAIu6EBgo1AL TmghKDWaT7xg4qm3CljwArEBX5nX9Z0VwXQcmUnfzAeKzeV9NdU78Ivnj8LjBxl0aaKf p8N9uaG/wHoTq4neY2PwJUUOvGUmo0aWbJC/N5Kry5OkA3M89mkHP1p4nX93u4pgZYc6 18Ww== X-Forwarded-Encrypted: i=1; AFNElJ+F75+4Ti3FDAtB6nhzzvYYmSM7/UQYrEJja9L8bKcprzmeG3n5DNDuPxQR5xFV4wPFcsNW3EnwZ5WpYoU=@vger.kernel.org X-Gm-Message-State: AOJu0YxaLhJIALi3dMkayXLG+PeJLhXfHewP2sUbRJjFLcTB/NZege3q pUy98dYizK1j0jCn6tqJ5UpmPmhjZvy+8EIYwAhDgc5MEOiVBJcl2gMpIo6JsQQVOTPBIbq2Cos tSDoQj08CJVuMYCxQHYTBy8ma4Vhnln9d3JwmYQKbqi/MMuWKTqeT38ki6VIDmWbDv4o= X-Gm-Gg: AeBDiesfE2ztRDOhWkdy2Ur0mQrpn1zMNasYJ5NCnKcb7ujnJh9QCPQEWVwb03eurF6 aPZsBuUd5mbNtqyxElkkx06v35hXm4r2BIwdMscKYB64BWw5T9b955ZYU6oMdihrvgGJuTAmskV xVwpt8nrxCMh0xDIH5LRPivJeQHHYCq0m1+kcJ+sEZrPqIQVGKhUOL/Ov7eQgwgnPV+NXsbsQWV vQrVluuFm3CkWVwtG0UNIinpz2Afef9AD17GJLdKPVRjIJ/PTQgRHRZ/jKl8OVq41S9X7MiXL8x lth13PGo2eHgus/n+mcog0SjH2eHKGBjDeSMK+oxeMaPuyHaRbTURQNMDX5t+tvSJ+irQ7tuXar IbsmJxLMljHurF2Ec0PBc/dy0OgqzCZUnBLO/F/nY1ZK9Ujaw4vueoxonX7f7tCg= X-Received: by 2002:a05:7300:7255:b0:2d4:aa5a:391c with SMTP id 5a478bee46e88-2f54869a41bmr3245336eec.12.1778124489126; Wed, 06 May 2026 20:28:09 -0700 (PDT) X-Received: by 2002:a05:7300:7255:b0:2d4:aa5a:391c with SMTP id 5a478bee46e88-2f54869a41bmr3245319eec.12.1778124488482; Wed, 06 May 2026 20:28:08 -0700 (PDT) Received: from [10.218.14.97] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f56f88f89csm6086152eec.15.2026.05.06.20.28.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 20:28:08 -0700 (PDT) Message-ID: Date: Thu, 7 May 2026 08:58:02 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] spi: qcom-geni: trace: Add trace events for Qualcomm GENI SPI To: Mark Brown Cc: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, MukeshKumarSavaliyamukesh.savaliya@oss.qualcomm.com, AniketRandiveaniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com References: <20260506-add-tracepoints-for-qcom-geni-spi-v1-0-c957cfe712d1@oss.qualcomm.com> <20260506-add-tracepoints-for-qcom-geni-spi-v1-1-c957cfe712d1@oss.qualcomm.com> Content-Language: en-US From: Praveen Talari In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: ISdzPCs8Qwb2AqNh6qSyz7Twsq6C4D_r X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDAzMCBTYWx0ZWRfX9l6tSncIJGYv 5q/ul8qVb63ocWTGLy1v4qfwtNPyoc8ROdJlEApMx2fZ7U5PRo2uk+7+FcmtezeGwLnTlURJi8x f+iO6mxx0oWYNdf+KwvubZ+KNyGGfxqR4j5/asnkLmeyzKjD6wlBWFsOrSGSf85VK+GdunXo/Wm OFT6eTSN7WpIbzvbiq23VTkGGQmjfpqTm+Xu/QS5sKdGKnPNj+W6hQIOdQvS9sG5YFXY8Gqqom3 r4JuAdNAFeUJvw9Zfe1jDcdZzDW5wfkag8wjQA898U2iDm9b/uEJyAeQhaKo2jMPpkPf6ozXWUU 5T5aRs2ssUviCIFMXiiVed1LZIjnJhlFc+c/DjXgEVuKwZjhX8GjV6qwTh7gRQkDNjrj0MN4aV2 twIBtsdc05lyR/ds1ItZroXVM7OL+DPfOgA639x0Uv2p/EORplFCtJMgKwzzsHiK8EXYldqxzLg K4vKGZakU7y62QABvYg== X-Proofpoint-GUID: ISdzPCs8Qwb2AqNh6qSyz7Twsq6C4D_r X-Authority-Analysis: v=2.4 cv=X8Zi7mTe c=1 sm=1 tr=0 ts=69fc06ca cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=RmYZSZXQ8PJLqAOd_dgA:9 a=QEXdDO2ut3YA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-06_02,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 spamscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070030 Hi Mark, On 07-05-2026 06:32, Mark Brown wrote: > On Wed, May 06, 2026 at 10:59:42PM +0530, Praveen Talari wrote: >> Add tracepoint support to the Qualcomm GENI SPI driver to provide >> runtime visibility into driver behavior without requiring invasive debug >> patches. >> +TRACE_EVENT(geni_spi_tx_data, >> +TRACE_EVENT(geni_spi_rx_data, > At least these feel like they really should be generic events, there > hopefully isn't anything driver specific about them. Initially implemented as a generic event; however, splitting into separate TX and RX events may be more appropriate. Which approach would you prefer? Thanks, Praveen Talari