From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755867AbdESRrf (ORCPT ); Fri, 19 May 2017 13:47:35 -0400 Received: from mout.web.de ([212.227.15.4]:54522 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751443AbdESRrc (ORCPT ); Fri, 19 May 2017 13:47:32 -0400 Subject: [PATCH 1/4] ueagle-atm: Delete error messages for failed memory allocations in two functions From: SF Markus Elfring To: linux-usb@vger.kernel.org, Greg Kroah-Hartman , Matthieu Castet , Stanislaw Gruszka Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang References: Message-ID: Date: Fri, 19 May 2017 19:47:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:nF+O0gouTImEfaeEe+BRJcyem4XsYO7g4H9Ee2zRTtUb2rlRHbg vHs96u84iJltaT/GWv5QSkXxpDiMVhkRSvNNHuhxLAFJIrcDxvdtwlJ3xmtgiaoVJOU/gBT yG+Kv4uUulUd0yC+BQ74098ElAeFdaTcoUdaju+R1zGPMOk18YS7kmhnLbG3/LViF44qOod j2tkF/fKML1DRGRCiQZNg== X-UI-Out-Filterresults: notjunk:1;V01:K0:7UJYEvpKXeA=:cGD9eOlwA+GD+0HFDHV+9u Hz2KtQZ9FlhmrLWZN529w6RFeOD/Z0UgrMLLz7IJ1fHGodA0j9PLFEO7vgcpeHJIi79pR+tLC Ygx4bJZeAyV8P1chSNzZVpu31+lxOCILAZrXFg97Z0BFf72q4vOdQGL0lrrvkJIB2QXg1j8Sg 2t8G7zTxUFSXwaHkEPOoGfL9zS/kkgsIwkaaU+7ApvJsZxfkfRc8aMp1YXzKGm6e27aIlo2aY 473CM/O4wuNLKBs5UHZmz2KWbJkULgtd3HyBpMR0KHL+S5JVJUyN8cBN0qYrGIXdO0zjvWR5n RgDpbFy60hpbPL9l0Yk0WUZUapN4yS0Csiw1xnMpQYvWnCUI0SZ5lOSqaCHsalnCG02h478OP rZdFS1VEoVQjlBzLWqkhpgV95mYyvXxy113MlNVHh4JvGYd4Clo084DnV7ITUkKeClKgeN8gF dTQsT0imzaS33T1/TB1kZSZ2kPzUuI1gojJKhHK+jxN37M9ibbnXmpkz0+FYUPqXUc2AFkM/+ s8EjpndlKZ29URxmV7fAY99A8IQ8NjLGsy+3T0+5ZpMST7vHCfMOhB6CPMcxmSX4xOB2mjN2z X50L62Xok+eXI2gkLOSHhAKZq+jlIS+jex5PBMqT0RjIEiX7erVrahHwySW5VbL3iLOs6Yf44 EIogTLoxm0QigIz2LODFT2MehyluBc2eFNq6ynovDL8ydAcgpX7JcIxKSoglhp4GKEF2ajG56 G1hBPUCo7pZ5kfjOJ25abo9/0MmPRao9JvaGPllXLZwtVgk95RPqn1fA8zPKfeILgRUOM/Mwy gPROb8A Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 19 May 2017 19:02:01 +0200 Omit two extra messages for memory allocation failures in these functions. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/usb/atm/ueagle-atm.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index df67815f74e6..16fd87df69e1 100644 --- a/drivers/usb/atm/ueagle-atm.c +++ b/drivers/usb/atm/ueagle-atm.c @@ -868,10 +868,8 @@ static int uea_idma_write(struct uea_softc *sc, const void *data, u32 size) int bytes_read; xfer_buff = kmemdup(data, size, GFP_KERNEL); - if (!xfer_buff) { - uea_err(INS_TO_USBDEV(sc), "can't allocate xfer_buff\n"); + if (!xfer_buff) return ret; - } ret = usb_bulk_msg(sc->usb_dev, usb_sndbulkpipe(sc->usb_dev, UEA_IDMA_PIPE), @@ -1147,10 +1145,8 @@ static int uea_request(struct uea_softc *sc, int ret = -ENOMEM; xfer_buff = kmemdup(data, size, GFP_KERNEL); - if (!xfer_buff) { - uea_err(INS_TO_USBDEV(sc), "can't allocate xfer_buff\n"); + if (!xfer_buff) return ret; - } ret = usb_control_msg(sc->usb_dev, usb_sndctrlpipe(sc->usb_dev, 0), UCDC_SEND_ENCAPSULATED_COMMAND, -- 2.13.0