From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752265AbdLJQ0Q (ORCPT ); Sun, 10 Dec 2017 11:26:16 -0500 Received: from mout.web.de ([212.227.15.3]:59647 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751988AbdLJQ0M (ORCPT ); Sun, 10 Dec 2017 11:26:12 -0500 To: kernel-janitors@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby Cc: LKML From: SF Markus Elfring Subject: [PATCH] tty: cyclades: Delete an error message for a failed memory allocation in cy_init_card() Message-ID: Date: Sun, 10 Dec 2017 17:25:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:iftHArOt8RCSs9APb2anitZzr4LmQWd3q4+OpYE+420Y0Z4lNio 3G0jWhhCopFfn3v6Bk0M6tose+7TKkexX6o0IQOK8mulkKAmDr44VyZUtG1s4sFf0a2FGoM AsjUFA/164MjTw49c9UQMOV1pPyDC25cCS8Od1u8dwGl5JINdYVzc4ZPo/2fRDlt4+5XTjm BsfjAcBpMVqcIeu+U9EcQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:UwMvUqtenzo=:etz96U+yYqF1POtmiMNRAS SB0daTbBqmyZ9M8NS3ODU+KL0xeqH1JpwhlBIuqQPswm6tPtzTOm72gqxkN4PjfGiBCMLIKls FcUnnQzSXy5sJ/gbTeVGdLLSBts5I09v8wp/f22Sb1h1bMSlS5DE0VEwXzQWC3lt/Qflqd/ZV 0+3bMcZsOVRZ4vPOEFwMG3zNGUbaODmSzO+QHBLVJXPtysh4AJiMZxzF8GeVY0qjt/sRSxAgs MYZ/lolvpMydjhRRJ1yszum44wZlahaZ1t9If1f7DzgBHSo/jksy2K2PfIys/OMSDGjIrgpGa rDpk99yawqpeUo/0Pf6OXtTuUbxPl8B5b5WLZWp5tzKAjjuZgVWPYNVsSsfWaxt8/SH3xV+Xt z9YxZIOfsIWGJpoVhIAW8JhyuwgmZTxuMskKeXbhTUocHvWxZ8zQ7x2obrThVha9VwBk2teQN 69BDfTxnFwa8CKOI06el/7VCqLEGfA3rKp3Rr5PbhtuqtO8uzyOI5idl/V8Vx0VHx6IIi3PPV bvCqreFF3aag4YjDoM25vWTx72lAHtVeOnW0qOrWKoo5K/Ng7gquk5SVqoEFfvHM4RG79iKMh Jbf+Yf2GbEbuCqES9Se6MsJsCnxIcYF0qz0yE703mczy++B9K4wpL4CQ4fMNy7V4aE7HrtJUB qqe8iccMWbtEPL7xGnCT2C7a5drQlWzZ0TH5Nl8cPUQvogdaY774F2peCLb5ga125v/IFw3vD xjeZ2sYTU0Lny3E1WwydPGlNsFVjbZzxntxk3sPXSANB5P4t7Z7IDxe5gi00ddFs9aBpkjTfz fFn1dN8MoXxfGq47pnNW6q0UFGEw58fIT5QblaDi1W1x+Ybm8E= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 10 Dec 2017 17:21:28 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/tty/cyclades.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/tty/cyclades.c b/drivers/tty/cyclades.c index 5d442469c95e..a0dbce2cf2d9 100644 --- a/drivers/tty/cyclades.c +++ b/drivers/tty/cyclades.c @@ -3061,10 +3061,8 @@ static int cy_init_card(struct cyclades_card *cinfo) cinfo->ports = kcalloc(cinfo->nports, sizeof(*cinfo->ports), GFP_KERNEL); - if (cinfo->ports == NULL) { - printk(KERN_ERR "Cyclades: cannot allocate ports\n"); + if (!cinfo->ports) return -ENOMEM; - } for (channel = 0, port = cinfo->first_line; channel < cinfo->nports; channel++, port++) { -- 2.15.1