From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B27D19755B for ; Mon, 22 Dec 2025 08:52:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766393525; cv=none; b=otXyaZdOmyRh1rJz95Udei4/Cq+x6QuAQvc5iC8UMOBorkpfGC3Gg7paNi/7bTlhdaKEofF3eBvnl1+shZgo4cgVFK+zdv2mvd0VKzNGHo76pzoy35Q18Loz+N84i+xGkonCwV851za0VE6hOWwy/8ZV7CGww61RNfEJFhFrjpo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766393525; c=relaxed/simple; bh=s+MH1Wksus25flQEOZT8H2FX5EwOBcctS2lnJti54rU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fwyLehPblOyn1O38PTafi/YRPbPrM+NAkks6UQ9/SlOCZcpm4jLzapV+qikv3FHy1kd1vyXwYQDeYnRPpsCNIDL/Np5XE7vGp0Ev83xQzRXDzLPM5BcPA+D2C9kUC/Di6QDO9pMxLAaJmiD7V2bs5LxsvrjJsoHYz3pXCEwapzc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TRpbEqJU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DXUwOiUo; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TRpbEqJU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DXUwOiUo" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BM8H1tP3697636 for ; Mon, 22 Dec 2025 08:52:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uob+hAF8OiofpUbnbjg7D+uwM1p4gb+qkC9KuaAID1o=; b=TRpbEqJUhbVzV0tu s466P7IMqRZNeJJlAodUf//R/Gfj2EMsu1JnEcp7cYOnTjsDEQ8sg8f6pVLNipim gGcptlvILCb/xmWsPGm97apHwSKGr6g/xQtWAgE9HguYftCssDO3zxh4ztjuscVR nmBxt3outQiO0qaK+ht58YwvmwYYoRz6TKVFKhD0KQSlc3uec9IaCn5kFd3qfJ6k CI6HayG7gxXsd17tqoCUC0XH7cy8ib+gsFxhzR917LqrjpZBbfnTj6MMu186QMJr 85NLRghXY6EUIJzEVXO5xznXtBl05KfUAly92bfBO52YhvQD2Daay9ViTWth87hq WWlERg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b69ahjndd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 22 Dec 2025 08:52:03 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4edaa289e0dso12215431cf.3 for ; Mon, 22 Dec 2025 00:52:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766393522; x=1766998322; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uob+hAF8OiofpUbnbjg7D+uwM1p4gb+qkC9KuaAID1o=; b=DXUwOiUo8ol5HBsGy0Tr2Ttz02hh40kSNEsUSySNTXgxwiYsJfbgi3gooNEM6ioRWj YIy09i8AKeMCPfxFo5GARBYNbAeURaZ+bX84CBsl8M8gIp+dEDO1b2kqX6rSHdMVOfqk Pu04RpAy0XTYbe/M5tP6DraPVC85LDbE9nYMWYnx3IkemC5/fOpAZQxbyWmN5/g0R/E7 tvT/oc5kYHWPu04cp5L8bNyeC/vx5gsx8mtjJxhaIgdcierJ36cEgl3uK1TeeYJrLI2J T9O4UoqgCTu04xyk7PZymInZo5OdKX2hvpLwPRi1kPENx/OxEsFSxTshLyf8a4gtRJ1J 6XmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766393522; x=1766998322; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uob+hAF8OiofpUbnbjg7D+uwM1p4gb+qkC9KuaAID1o=; b=eAGkC7VM9FEmZiH/WThn1VufCE/lM/d9Qk/goN/GVx7E9J4DVGKL/Z4su7MQ5gnazT Vm0YaXVYeGOnRPa6jfFuHmWGiR9KvpdeHygGnwpcfwyo42wC5/r+cTOVHCWTgU95k1Yp YyqVAZ9Dht+2jDMPLhFwtqNwSNlg6EWJLdxfTC68Wlw1+n7eiMSco+AvLv3MF0R+YO+X vlnSFV2Zz8XYe+KMhTGAiBegpLhuu07uL+gzt0nWyJZKja79XOaZozL6msoZSdzKgDXU gWOiIqqrf+ffCD8tmPSryPb+67hEBfDFPDRwy/RUsMf54XqG47IEvUILuC7JMwm3re20 EV8Q== X-Forwarded-Encrypted: i=1; AJvYcCWFvYtxu5ksHn3JRvXXNd8QHTOVOxpGj+C9Bm1gTQNr0xymi78UXvYaQs7ewV8jacswPEfBNuSozcStzS8=@vger.kernel.org X-Gm-Message-State: AOJu0YyhgPjZy/KzUXA0rcHVuL4ODCKbPcmoVn6XTezhfEsatzSWSh1x QRtvoOwHdZTC5+VtWtoNPlmrtG+N2+hZLMeb/++bkGqhLKCd0g0lGIgoqkKBSeA43VlHXzwEOpc g3VSecGJzEpYKoKGpLz1eIKnarjk0ojmeC1wnSouIWOLOiCTOkUOrlVQMxqswUQNvV6c= X-Gm-Gg: AY/fxX4M6vg0uogyVSZVKq/4+WrXLc2fB5sg8D/iQdNTa2WFcTSKovKq72/W8FsadEG tQiKh3GAr3GZ7mnakAyHxUtisKLcOUd1M55Zm4wWxGclEFS1Cp7IBuBNA46T97iag95eqzIPqVU hf3j2tzn7iF3plF28vj4moKMqRBlK3EX1PCU5Wfoovnq6FQd0bdYFVstjX6Y77pqzlNRppMXFXL figd7hudKd8FD1PhpyRkrg7kA3LDkgDlvmpmy+VuzKRjOcbepbqFKUyKORBg0GQqFrJgOnKhFpI r38FDMwKZX2iXiZID1pjraFF+s6nnEsrNbjKvuLQgQo58toRS9CHi/9rizycEZ0fKul/+2gBVP+ a6A1VDhjim74qePoG09ESc0c0bXAbMWY9NxarNOEM9AwGIBFki9A7YRWmtk5jo87FAw== X-Received: by 2002:ac8:7c52:0:b0:4f3:616f:150 with SMTP id d75a77b69052e-4f4abbdff03mr115520311cf.0.1766393522537; Mon, 22 Dec 2025 00:52:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IGWwe4NdFNAaev00TKW28UVBa3Fu6va8hqB4ZolVSybJM2HPRrqFtrcc6EfguXpS+jYS4uOtw== X-Received: by 2002:ac8:7c52:0:b0:4f3:616f:150 with SMTP id d75a77b69052e-4f4abbdff03mr115520251cf.0.1766393522151; Mon, 22 Dec 2025 00:52:02 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8044f4acdbsm853980266b.22.2025.12.22.00.52.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Dec 2025 00:52:01 -0800 (PST) Message-ID: Date: Mon, 22 Dec 2025 09:51:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm/a6xx: fix bogus hwcg register updates To: Johan Hovold , Rob Clark , Sean Paul Cc: Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , Bjorn Andersson , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20251221164552.19990-1-johan@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251221164552.19990-1-johan@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=JuH8bc4C c=1 sm=1 tr=0 ts=694906b3 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=dk0i7xQ4PQfej7aG6gsA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: I8Cpig-W3NzPdRSoKt3tpm7ly6wQvw3N X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjIyMDA3OSBTYWx0ZWRfX9AOBM45zZbz4 81qqat/0dAgsVVHNdKfTtHDEqGG2o+rra9uOCdHBu86zrGFT8z9qxHHut8usSKx7+g1/u3wfQPb CqCfBhUeGHbjsVIlay2ER+g+Ll6ZV9w+ZVKiHHTAiq2xOtjwYF3ub/xLW1SAqFKyAU8mc/Nhxb3 4UEM/lgo4wHxqyr5YRudDhRasi9Gbje3I/kpekM/TaXOgJcaojkGDDPQOHp5csQzCLJBZ/ADVHM uKY+5CCdjGmEXl9Rlk/v4e0N1mNzG3UutrYEGZt1nqcYQzuByyNFFGXKhKgynf3YmI8b71q5/ZN Ykt6r9mSgqepnIeAfaWF7pAifwx70vv0vLZJLLJt1Zr9WxUhqZZEeO84TPYVznC3YBLICmHHZ0C n6ADi9r+GrwVGuTRSI5vPwGqrcWwlUJtS2Vp/vWJnTZQcAe3OS50Zo14NUizS6wHfvEUI6xFQJ+ BEuzowwPJ+UOy0dDnaA== X-Proofpoint-GUID: I8Cpig-W3NzPdRSoKt3tpm7ly6wQvw3N X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-21_05,2025-12-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 adultscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 suspectscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512220079 On 12/21/25 5:45 PM, Johan Hovold wrote: > The hw clock gating register sequence consists of register value pairs > that are written to the GPU during initialisation. > > The a690 hwcg sequence has two GMU registers in it that used to amount > to random writes in the GPU mapping, but since commit 188db3d7fe66 > ("drm/msm/a6xx: Rebase GMU register offsets") they trigger a fault as > the updated offsets now lie outside the mapping. This in turn breaks > boot of machines like the Lenovo ThinkPad X13s. > > Note that the updates of these GMU registers is already taken care of > properly since commit 40c297eb245b ("drm/msm/a6xx: Set GMU CGC > properties on a6xx too"), but for some reason these two entries were > left in the table. I am squinting *very* hard and I can not recall why I only removed one of these entries. > > Fixes: 5e7665b5e484 ("drm/msm/adreno: Add Adreno A690 support") > Cc: stable@vger.kernel.org # 6.5 > Cc: Bjorn Andersson > Cc: Konrad Dybcio > Signed-off-by: Johan Hovold > --- > drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c > index 29107b362346..4c2f739ee9b7 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c > @@ -501,8 +501,6 @@ static const struct adreno_reglist a690_hwcg[] = { > {REG_A6XX_RBBM_CLOCK_CNTL_GMU_GX, 0x00000222}, > {REG_A6XX_RBBM_CLOCK_DELAY_GMU_GX, 0x00000111}, > {REG_A6XX_RBBM_CLOCK_HYST_GMU_GX, 0x00000555}, > - {REG_A6XX_GPU_GMU_AO_GMU_CGC_DELAY_CNTL, 0x10111}, > - {REG_A6XX_GPU_GMU_AO_GMU_CGC_HYST_CNTL, 0x5555}, Reviewed-by: Konrad Dybcio Konrad