From: Yasin Lee <yasin.lee.x@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: jic23@kernel.org, dan.carpenter@linaro.org, nuno.sa@analog.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: proximity: hx9023s: Use 'CLOCK_BOOTTIME' as the default clock source
Date: Wed, 4 Sep 2024 17:19:53 +0800 [thread overview]
Message-ID: <e477448a-6bf9-4ef6-bf53-25a278430f24@gmail.com> (raw)
In-Reply-To: <e2106a4f-ed3a-4b02-b1d2-d54c096fcab8@metafoo.de>
On 9/2/24 18:43, Lars-Peter Clausen wrote:
> On 9/2/24 12:32, Yasin Lee wrote:
>> Override the default (CLOCK_REALTIME) clock source to 'CLOCK_BOOTTIME'.
> Why? Won't this break existing applications that rely on the current
> default?
>
Dear Lars-Peter,
Thank you very much for your careful review. After careful
consideration, I agree that changing the clock source from
CLOCK_REALTIME to CLOCK_BOOTTIME was not the right approach.
This submission is incorrect and will be discarded.
Best regards,
Yasin Lee
>> Signed-off-by: Yasin Lee <yasin.lee.x@gmail.com>
>> ---
>> drivers/iio/proximity/hx9023s.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/iio/proximity/hx9023s.c
>> b/drivers/iio/proximity/hx9023s.c
>> index 8b9f84400e00..5363357a9a46 100644
>> --- a/drivers/iio/proximity/hx9023s.c
>> +++ b/drivers/iio/proximity/hx9023s.c
>> @@ -1074,6 +1074,10 @@ static int hx9023s_probe(struct i2c_client
>> *client)
>> "iio trigger register failed\n");
>> }
>> + ret = iio_device_set_clock(indio_dev, CLOCK_BOOTTIME);
>> + if (ret)
>> + return dev_err_probe(dev, ret, "clock boottime set failed\n");
>> +
>> ret = devm_iio_triggered_buffer_setup(dev, indio_dev,
>> iio_pollfunc_store_time,
>> hx9023s_trigger_handler,
>
>
prev parent reply other threads:[~2024-09-04 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 10:32 Yasin Lee
2024-09-02 10:43 ` Lars-Peter Clausen
2024-09-04 9:19 ` Yasin Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e477448a-6bf9-4ef6-bf53-25a278430f24@gmail.com \
--to=yasin.lee.x@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®