From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 419782236EE; Tue, 13 Jan 2026 14:12:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768313532; cv=none; b=owE2AUEZL6xqlTAImVv4VgtchUTXiRt22lDJJbXn6TvxQlwbTVTBuVuOjG0GkKZtyDIRuUYA3LsZSeb+1Chk+FvkvZqjWq/3dFz6TTdsX9UZ1hQzkWF6FVMApmkoQxTNSdgb4RiZ2Of9SnvdpfZlttY/+JaFbKlc+CNdklnE5no= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768313532; c=relaxed/simple; bh=pc/84db9ibTXoWvNpr+FrBU7auchS4A9b3XVeVy9fTc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VxZaT3JJhGnTjv+R7cwroiRaKlAPExoIox7JMFvVyEc6HbjCsendc4i06/bO5DwzQYBBwnnJM3LgPIs3GeOEfhL9DapFAY9u/yHhCUkrt8AgEu1NoMsXqFAnSWaDlZTFgzjnQAsPYrGOplFCmU3oiwTpQH6TmNMEMXlSIziLKHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=UO0IAwys; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="UO0IAwys" Received: from [192.168.0.43] (cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id EB4BE50A; Tue, 13 Jan 2026 15:11:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1768313503; bh=pc/84db9ibTXoWvNpr+FrBU7auchS4A9b3XVeVy9fTc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UO0IAwysRGhc/xC2y8jJlWhPlJkT08uBseZrDPu/RU9CK+6mmyKXFSQSKrkTQ9kfZ Iw2O/DVB/maPXgdyfyVQlaIDY5ArgRgz70FgySAwwZ8pgsu9A4KVRtcXYJqzNgqg6r 6tNP/1uj9MTr83u4F3YwogSkngX9VcVwTfac5N3c= Message-ID: Date: Tue, 13 Jan 2026 14:12:06 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: mali-c55: Fix NULL dev stream alert for tpg sub-device To: Sakari Ailus , Jacopo Mondi Cc: "jempty.liang" , Laurent Pinchart , mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260113075722.143238-1-imntjempty@163.com> Content-Language: en-US From: Dan Scally In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/01/2026 10:40, Sakari Ailus wrote: > Hi Jacopo, > > On Tue, Jan 13, 2026 at 09:55:10AM +0100, Jacopo Mondi wrote: >> I wonder if v4l2_device_register_subdev() shouldn't WARN or if return >> an error if sd->dev is not initialized. Laurent, Sakari: opinions ? > > I might even return an error but I wonder what would break. Perhaps indeed > could start with a warning? > It looks like it's only used for dev_*() printks, unless I'm missing something. Thanks Jempty for spotting the problem! Dan