From: Devi Priya <quic_devipriy@quicinc.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: <agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <linus.walleij@linaro.org>,
<catalin.marinas@arm.com>, <will@kernel.org>,
<p.zabel@pengutronix.de>, <shawnguo@kernel.org>, <arnd@arndb.de>,
<marcel.ziswiler@toradex.com>, <dmitry.baryshkov@linaro.org>,
<nfraprado@collabora.com>, <broonie@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<linux-gpio@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<quic_srichara@quicinc.com>, <quic_gokulsri@quicinc.com>,
<quic_sjaganat@quicinc.com>, <quic_kathirav@quicinc.com>,
<quic_arajkuma@quicinc.com>, <quic_anusha@quicinc.com>,
<quic_poovendh@quicinc.com>
Subject: Re: [PATCH V8 4/7] pinctrl: qcom: Add IPQ9574 pinctrl driver
Date: Wed, 15 Mar 2023 16:52:39 +0530 [thread overview]
Message-ID: <e482a189-823f-35b1-b411-4c4db22a86a6@quicinc.com> (raw)
In-Reply-To: <CAHp75VfMae9M2R0Bw6-sYuHPPberakEzKct65SXV0XEaOFtXTg@mail.gmail.com>
On 3/8/2023 6:54 PM, Andy Shevchenko wrote:
> On Wed, Mar 8, 2023 at 11:52 AM Devi Priya <quic_devipriy@quicinc.com> wrote:
>> On 3/7/2023 5:28 AM, andy.shevchenko@gmail.com wrote:
>
> ...
>
>>>> + depends on OF
>>>
>>> No compile test on non-OF configurations?
>
>> As per the generic convention followed in other
>> SoCs, we do not have compile test on non-OF configurations
>
> Why not? So, you have to explain the deliberate narrowing of the test coverageOn adding 'depends on OF || COMPILE_TEST', the driver compiles
for non-OF configuration as well.
Will update this in the next spin!
>
>>>> + depends on ARM64 || COMPILE_TEST
>
> ...
>
>>>> +#define FUNCTION(fname) \
>>>
>>> PINCTRL_PINFUNCTION() ?
>> I see that there are quite a bunch of files that has to
>> be modified for using the generic data type and
>> macro for the pin function definition
>> We shall post a separate series to accommodate the changes
>
> Sure, that's fine. Please do!
Sure, thanks
>
>>>> + [msm_mux_##fname] = { \
>>>> + .name = #fname, \
>>>> + .groups = fname##_groups, \
>>>> + .ngroups = ARRAY_SIZE(fname##_groups), \
>>>> + }
>
> ...
>
>>>> +#define PINGROUP(id, f1, f2, f3, f4, f5, f6, f7, f8, f9) \
>>>> + { \
>>>> + .name = "gpio" #id, \
>>>> + .pins = gpio##id##_pins, \
>>>> + .npins = (unsigned int)ARRAY_SIZE(gpio##id##_pins), \
>>>
>>> Can you embed struct pingroup?
>> Will take care of this in a separate series
>
> Ditto. Thanks!
Sure, thanks
>
>>>> + }
>
> ...
>
>>>> +};
>>>
>>> No MODULE_DEVICE_TABLE()?
>> The MODULE_DEVICE_TABLE(of, ipq9574_pinctrl_of_match) entry has
>> been added at the end of the file
>
> So, you know what to do then to address my comment :-)
Yep, got it!
>
Best Regards,
Devi Priya
next prev parent reply other threads:[~2023-03-15 11:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 16:31 [PATCH V8 0/7] Add minimal boot support for IPQ9574 Devi Priya
2023-02-14 16:31 ` [PATCH V8 1/7] dt-bindings: clock: Add ipq9574 clock and reset definitions Devi Priya
2023-02-28 10:01 ` Varadarajan Narayanan
2023-03-03 13:27 ` Devi Priya
2023-02-14 16:31 ` [PATCH V8 2/7] clk: qcom: Add Global Clock Controller driver for IPQ9574 Devi Priya
2023-02-14 16:31 ` [PATCH V8 3/7] dt-bindings: pinctrl: qcom: Add support " Devi Priya
2023-02-16 10:36 ` Krzysztof Kozlowski
2023-02-14 16:31 ` [PATCH V8 4/7] pinctrl: qcom: Add IPQ9574 pinctrl driver Devi Priya
2023-03-06 23:58 ` andy.shevchenko
2023-03-08 9:52 ` Devi Priya
2023-03-08 13:24 ` Andy Shevchenko
2023-03-15 11:22 ` Devi Priya [this message]
2023-02-14 16:31 ` [PATCH V8 5/7] dt-bindings: arm: qcom: Add ipq9574 compatible Devi Priya
2023-02-14 16:31 ` [PATCH V8 6/7] arm64: dts: qcom: Add ipq9574 SoC and AL02 board support Devi Priya
2023-02-14 16:31 ` [PATCH V8 7/7] arm64: defconfig: Enable IPQ9574 SoC base configs Devi Priya
2023-03-16 3:21 ` (subset) [PATCH V8 0/7] Add minimal boot support for IPQ9574 Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e482a189-823f-35b1-b411-4c4db22a86a6@quicinc.com \
--to=quic_devipriy@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=mturquette@baylibre.com \
--cc=nfraprado@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_anusha@quicinc.com \
--cc=quic_arajkuma@quicinc.com \
--cc=quic_gokulsri@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_poovendh@quicinc.com \
--cc=quic_sjaganat@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®