From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0368628852B for ; Wed, 26 Nov 2025 07:27:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764142069; cv=none; b=uZxWFMe3zzk4V4gVxqt5mgJTzN171bWz7wdaSH21lrJ8YNW1aXCUJNUwZyKdeHca3bRa3YuTyAP+vaNaxbHPqloJyM8Nd6/3qwqU7QxNWVGs95A5QOXtNY7vAEKWzZH/YyLqR5YPnVeQ/tPuRrfRw1PEThNMoBKGTVg/vRzHm/8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764142069; c=relaxed/simple; bh=X7ZPu9Uyw4eRnCEGCXnnjhorcjxx4NtX8mrOQJpQP70=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=FTNwlbwDQmNiGDZJypjRp+oHgnq4DIXgMSfrZJcnGT/F/uARrkFEsuLZ1EDjOg1Snfef1XblyupFmROA+C82fkJcq1b0X6Q9VWXc6w4r2QqvHtUmQW/8/tpZd1vY2dHItmjXJTywczVGSo5FODs/hL4BCf0+zJE5IBpV/+azshc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YOx69gPU; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=O+NDAMbS; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YOx69gPU"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="O+NDAMbS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764142067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Nco9kMQ0naw+QFTHGhGkEUiJ6x4Fn+gAQnbkM+gldhA=; b=YOx69gPUSRSnZ7uMyAoEXgcBFhwbLKoEDpCSqFOt5A/kiSXjT9qCHks5bjqXJ1AGnt+auZ 4ADlqsQOGv+QudbuLO7oMgcW5NiDmePtpkAJQqiukEcZoMgKPn8kKButZtrjyZKVwF5w/n Hx1cBygVR+016MaxuzXc5mJ5KLynMKs= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-UJshfQirOV2MzfLbIjipTQ-1; Wed, 26 Nov 2025 02:27:45 -0500 X-MC-Unique: UJshfQirOV2MzfLbIjipTQ-1 X-Mimecast-MFC-AGG-ID: UJshfQirOV2MzfLbIjipTQ_1764142064 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-429cbd8299cso3193244f8f.1 for ; Tue, 25 Nov 2025 23:27:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764142064; x=1764746864; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=Nco9kMQ0naw+QFTHGhGkEUiJ6x4Fn+gAQnbkM+gldhA=; b=O+NDAMbSQz9GM9eIhZFgmLgJsuqnBT5jspS5w/37LHuGZDbkrEupACHVqFIER0LpL0 5Zbm6EY1C6zFSabtyQUilYR+NwhT6XPw4OYCiBGVgLQnhVlPH9rMr/G06mqBLEKBPDXy DJiDtGAXD3o2eJEQI2ryYIKknoypZNYbFodbcdzCdXr5wMvezgLQhkyfBys/UozLpeBF c3pZRa8183t7lLxbE55rDnC2B2Zzz876zxFI8N5Pi94GRRyudI/4sq8Jk9SVnpEikIRD OADXVI8JERYKOPXfgbURQBlJam/W6i6oZ8uhh4VLop340Lb9php+Ao6LzzZgX4XeRh6N 4Yrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764142064; x=1764746864; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Nco9kMQ0naw+QFTHGhGkEUiJ6x4Fn+gAQnbkM+gldhA=; b=rq11MtShg9qrcJGJk0+xtfM/IsC/xrrrhgUpbftYODDmxB+EsLNCutS9dIwzTtMWtH C/O9KkTwNelONdMY6S+4N/Wjx2Xsrk9UdeC33u9hFTvn9R5/Wio80j539Ryee1bfbvje 5n6hELvt4ZduU+PiPcQiUh0izOfjJyO3//i8ppyBEeM8cvVUAcuTfaSQ4YAoKcRiddiO ldqY9hDjApEOL6xE1Zsawb4cG2TdsJSJ71mEcPpKsitYD610IGMRYarh6Z6+2mANQtKG B5HXk1kAF7Zbx6aiSH7mK0a75XDJ2mYL9/AH5NX4qdF90KZ+bU1XvljRETwDJ55qCp25 QN/Q== X-Forwarded-Encrypted: i=1; AJvYcCUiBz9iiaHbUYH9+D6bxo0YqsVO8CXvu7/qPmS+6RzXwiWEJC0sS6m6P15B/cBjn7P0Mq9sCnXRA5gEwwg=@vger.kernel.org X-Gm-Message-State: AOJu0Yydfcv6tbYnUd1dqhCaQi8O+WwRawYSKDnSHKOD+ItkFLd6I8fB TgMfVdvtA96XjxhC7+ymwHcLjSYxzRZ5jNVUrlvMe0SU7clTGBRj7P8I2/emIVspzMNK6gkxVaF 4dw+4w5RFBViw2jFd30EErGZ5qmETSthl4YWj0TaII9FsC8tqDeq8/LvtpZd+zhzQ1jv1WHTQvp 5Re1s= X-Gm-Gg: ASbGncshC2DZmzhH+XwnsS4F+qot2zOmCs9yWH189p+cdzf09vadEz5cAgicXNvg8uZ x4NYzTVG/nn1x91RTHiBc104FHvhOjEbwVwyBa7V1ou8s/yASwdEHgUJt+zihsqnDw9W5qi10xD CZNKfoQ4SdQJM7CqzHnGqoN7LguQI4onvFZVhrfSbx5b7GS8lhRRVcupwioztb2WQ8V6bI6BBK0 +WvArr2xNgtHfGvZzdT4+1ns1vwKrRszK3p3Hoqkm91UGZPE2RyHypXjS8glmLiLA/89xwW0cBE /EtkJOzkhkynInOYB6UVos9N3FiKz0Aa0fcHQjIwEjs/vWaVU7vsZM1O/LBAtTZBml2rGvPJo/p 3hRQJpprb4eOJI0I3CqOlnztj5d9xDD9EkB0= X-Received: by 2002:a05:6000:2003:b0:427:6a3:e72f with SMTP id ffacd0b85a97d-42cc1d0cfadmr18247878f8f.34.1764142064257; Tue, 25 Nov 2025 23:27:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IEOqX3PELwvIZ+Vb1AbVC110j9OqoH953u64KiUDbJZ8vWSBYF7n3Xf4475WzmzUwsPtoAG5A== X-Received: by 2002:a05:6000:2003:b0:427:6a3:e72f with SMTP id ffacd0b85a97d-42cc1d0cfadmr18247854f8f.34.1764142063906; Tue, 25 Nov 2025 23:27:43 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb ([185.107.56.35]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7fd8d97sm38236674f8f.42.2025.11.25.23.27.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Nov 2025 23:27:43 -0800 (PST) Message-ID: Subject: Re: [PATCH v2 1/2] rv: Convert to use lock guard From: Gabriele Monaco To: Steven Rostedt , Nam Cao Cc: Masami Hiramatsu , Mathieu Desnoyers , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 26 Nov 2025 08:27:42 +0100 In-Reply-To: <20251125145736.48c3ed9d@gandalf.local.home> References: <20251125145736.48c3ed9d@gandalf.local.home> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.1 (3.58.1-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2025-11-25 at 14:57 -0500, Steven Rostedt wrote: > On Mon, 17 Nov 2025 09:06:02 +0000 > Nam Cao wrote: >=20 > > @@ -644,13 +640,11 @@ static ssize_t enabled_monitors_write(struct file > > *filp, const char __user *user > > =C2=A0 else > > =C2=A0 retval =3D rv_disable_monitor(mon); > > =C2=A0 > > - if (!retval) > > - retval =3D count; > > - > > - break; > > + if (retval) > > + return retval; > > + return count; >=20 > No biggy, but I wonder if this would look better as: >=20 > return retval ? : count; >=20 Tried both patches and they look fine to me. Reviewed-by: Gabriele Monaco Nam, feel free to send an updated version if you want to apply Steve's suggestion or keep the patch like this. Steve, this is the only remaining change before the merge window, unless yo= u prefer to keep it for the next round, I'm going to send a small pull reques= ts with those two patches alone. Thanks, Gabriele > -- Steve >=20 > > =C2=A0 } > > =C2=A0 > > - mutex_unlock(&rv_interface_lock); > > =C2=A0 return retval; > > =C2=A0} > > =C2=A0