mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Arvind Prasanna <arvindprasanna@gmail.com>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation: Update ncurses package names for menuconfig
Date: Wed, 28 Feb 2018 10:59:58 -0800	[thread overview]
Message-ID: <e484c42f-4fe6-10f5-dab8-cfd749911486@infradead.org> (raw)
In-Reply-To: <CAK-=9LoNfYP_-tm+W2GvUWjWgs=BZ-VRFmVNzTCadzQWaee9yg@mail.gmail.com>

On 02/28/2018 09:39 AM, Arvind Prasanna wrote:
> Hi Randy:
> 
> On 02/27/2018 10:59 PM, Arvind Prasanna wrote:
>> The package name is ncurses-devel for Redhat based distros
>> and libncurses-devel for Debian based distros.
> 
> The above lines are part of the commit message and the patch says to install either ncurses-devel or libncurses-dev based on the user's Linux distribution. Would you prefer I add my commit message lines to the patch as well?
> 
> Thanks,
> 
> Arvind.
> 
> 
> On Wed, Feb 28, 2018 at 12:31 PM, Randy Dunlap <rdunlap@infradead.org <mailto:rdunlap@infradead.org>> wrote:
> 
>     On 02/27/2018 10:59 PM, Arvind Prasanna wrote:
>     > The package name is ncurses-devel for Redhat based distros
>     > and libncurses-devel for Debian based distros.
> 
>           ^^^^^^^^^^^^^^^^ That's not what the patch says. Please clarify.

For Debian-based distros, is it libncurses-devel (above) or is it
libncurses-dev (as below)?  [latter is without the ending "el"]


And what about the other few hundred distros?  (rhetorical)


>     >
>     > Signed-off-by: Arvind Prasanna <arvindprasanna@gmail.com <mailto:arvindprasanna@gmail.com>>
>     > ---
>     >  scripts/kconfig/lxdialog/check-lxdialog.sh | 3 ++-
>     >  1 file changed, 2 insertions(+), 1 deletion(-)
>     >
>     > diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh
>     > index a10bd9d..4353e40 100755
>     > --- a/scripts/kconfig/lxdialog/check-lxdialog.sh
>     > +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh
>     > @@ -55,7 +55,8 @@ EOF
>     >           echo " *** required header files."                            1>&2
>     >           echo " *** 'make menuconfig' requires the ncurses libraries." 1>&2
>     >           echo " *** "                                                  1>&2
>     > -         echo " *** Install ncurses (ncurses-devel) and try again."    1>&2
>     > +         echo " *** Install ncurses (ncurses-devel or libncurses-dev   1>&2
>     > +                *** depending on your distribution) and try again."    1>&2
>     >           echo " *** "                                                  1>&2
>     >           exit 1
>     >       fi


-- 
~Randy

  reply	other threads:[~2018-02-28 18:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28  6:59 Arvind Prasanna
2018-02-28 15:04 ` Masahiro Yamada
2018-02-28 16:14   ` [PATCH v2] " Arvind Prasanna
2018-02-28 16:18     ` Arvind Prasanna
2018-02-28 17:31 ` [PATCH] " Randy Dunlap
2018-02-28 17:39   ` Arvind Prasanna
2018-02-28 18:59     ` Randy Dunlap [this message]
2018-02-28 19:59       ` Arvind Prasanna
2018-02-28 20:29         ` Arvind Prasanna
2018-02-28 20:53           ` Randy Dunlap
2018-02-28 21:20             ` Arvind Prasanna
2018-02-28 21:32               ` [PATCH v3] " Arvind Prasanna
2018-02-28 21:47                 ` Randy Dunlap
2018-02-28 22:32                   ` Arvind Prasanna
2018-03-01  0:16                   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e484c42f-4fe6-10f5-dab8-cfd749911486@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=arvindprasanna@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pombredanne@nexb.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®